All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Markus Koetter <koetter@rrzn.uni-hannover.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 5/5] trace: add log for packets
Date: Thu, 25 Jun 2015 15:38:31 +0200	[thread overview]
Message-ID: <20150625133831.GA6579@salvia> (raw)
In-Reply-To: <1434571657-20047-6-git-send-email-koetter@rrzn.uni-hannover.de>

Hi,

Sorry, it took me a while to look back to this because of the
Netfilter workshop.

On Wed, Jun 17, 2015 at 10:07:37PM +0200, Markus Koetter wrote:
> diff --git a/src/log.c b/src/log.c
> new file mode 100644
> index 0000000..410c21e
> --- /dev/null
> +++ b/src/log.c

This code has to go into libnetfilter_log, IIRC ulogd2 already has a
similar copy of this since it has a output plugin to display the logs
in the same way as the kernel does.

It would be great if both can use the same code. I'd basically like
not to see this code into nft.

      reply	other threads:[~2015-06-25 13:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17 20:07 [PATCH 0/5] nft trace Markus Koetter
2015-06-17 20:07 ` [PATCH 1/5] parser: add trace command Markus Koetter
2015-06-17 20:07 ` [PATCH 2/5] netlink: delinarize chain policy Markus Koetter
2015-06-26  8:09   ` Pablo Neira Ayuso
2015-06-17 20:07 ` [PATCH 3/5] rule: make cache creation a function Markus Koetter
2015-06-17 20:07 ` [PATCH 4/5] trace: implement commands action Markus Koetter
2015-06-25 14:11   ` Pablo Neira Ayuso
2015-06-17 20:07 ` [PATCH 5/5] trace: add log for packets Markus Koetter
2015-06-25 13:38   ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150625133831.GA6579@salvia \
    --to=pablo@netfilter.org \
    --cc=koetter@rrzn.uni-hannover.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.