From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8ML5-0008Hm-QL for qemu-devel@nongnu.org; Fri, 26 Jun 2015 01:38:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8ML4-0002nz-Kj for qemu-devel@nongnu.org; Fri, 26 Jun 2015 01:38:11 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:47763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8ML4-0002mw-9v for qemu-devel@nongnu.org; Fri, 26 Jun 2015 01:38:10 -0400 Date: Fri, 26 Jun 2015 15:07:40 +1000 From: David Gibson Message-ID: <20150626050740.GA22479@voom.redhat.com> References: <1435291564-14014-1-git-send-email-bharata@linux.vnet.ibm.com> <1435291564-14014-3-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qDbXVdCdHGoSgWSk" Content-Disposition: inline In-Reply-To: <1435291564-14014-3-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v3 2/5] pc, pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate routine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com, imammedo@redhat.com --qDbXVdCdHGoSgWSk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 26, 2015 at 09:36:01AM +0530, Bharata B Rao wrote: > pc_dimm_plug() has code that will be needed for memory plug handlers > in other archs too. Extract code from pc_dimm_plug() into a generic > routine pc_dimm_memory_plug() that resides in pc-dimm.c. Also > correspondingly refactor re-usable unplug code into pc_dimm_memory_unplug= (). >=20 > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --qDbXVdCdHGoSgWSk Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVjN4cAAoJEGw4ysog2bOSTDYQAIrWDHR9HGhGSpPdbDC24aL8 A5RmZ8PVDhCWpyswzPpbsLmINhwbq+IfH0mwVdx8k9kJDNyYzww2Z2Z32LgjH992 xTPh4N/Pyo2RlucMBlYISASMwAW31sQq63g1lVdvcpu9xcpoVmeALpmTUGGwEK4c aYK1qg9oaniA6fjVsmzzwkqQmOhQUYWtFNoJxPfu4AFkA7Gf6AFk1PA9jmnOxx7M w1LJOwXBy4y/UZOF58nx5nvXXDGfm+3U8FIb2oEsNtRgMEZRa7PbhWCAglM9s52d HIXydCKEanoihLNQDCV1YA9xcqpyWApYSt3LimburM371odBJOuZDidNj+1/+1bM A+UOGv1m/Wpp5HnSuWvJbo28Cozl27l0x/9qkvITRsObRADkkKTNpx7wc934+haG W6Wp5nssTVHRW/xDpdWPS7IE4XjWBVx7nhvL1b+vXl5rdc3AR1z8xDjqAA+3ZBX+ jibTJhqGDgGreb3A7ujLu5uqJJb4A3JNsHM0ZcLlAPvppK97RHl3It7DGYhtXSIx WuORIX/+FE9ViZbVyeyrJv718mVOPadJcMBcj5eyUKTYrexwATAfRC8AUC+h78el 6wxEMzwWZRucD0ZVHnlwJNiEiIgjFRhrR8NlDOs8vJkAGrYzFqQhKbgjgXAu8lN8 2qZElmYNnlp1xuAmuBy8 =kSnQ -----END PGP SIGNATURE----- --qDbXVdCdHGoSgWSk--