From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [v4][PATCH 13/19] tools/libxc: check to set
 args.mmio_size before call xc_hvm_build
Date: Fri, 26 Jun 2015 13:07:52 +0100
Message-ID: <20150626120752.GB1609@zion.uk.xensource.com>
References: <1435053450-25131-1-git-send-email-tiejun.chen@intel.com>
	<1435053450-25131-14-git-send-email-tiejun.chen@intel.com>
	<20150625110857.GI6545@zion.uk.xensource.com>
	<558CA352.7060701@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <558CA352.7060701@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, Jun 26, 2015 at 08:56:50AM +0800, Chen, Tiejun wrote:
> On 2015/6/25 19:08, Wei Liu wrote:
> >On Tue, Jun 23, 2015 at 05:57:24PM +0800, Tiejun Chen wrote:
> >>After commit 5dff8e9eedc7, "libxc/libxl: fill xc_hvm_build_args in
> >>libxl" is introduced, we won't check to set args.mmio_size inside
> >>xc_hvm_build as before. So instead, we need to do this before call
> >>that.
> >>
> >>CC: Ian Jackson <ian.jackson@eu.citrix.com>
> >>CC: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> >>CC: Ian Campbell <ian.campbell@citrix.com>
> >>CC: Wei Liu <wei.liu2@citrix.com>
> >>Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
> >
> >Acked-by: Wei Liu <wei.liu2@citrix.com>
> >
> >Sigh. I missed this because libxl doesn't use this function and there is
> >no in tree xend anymore.
> >
> >I think you should move this earlier in this series. Presumably your RDM
> >changes depend on this.
> >
> 
> Maybe this can be sent out independently since this is more like a fix,
> right?
> 

Yes. That's right. It's not tied to your RDM series.

> Thanks
> Tiejun