From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v9 2/5] ixgbe: add ops to support ethtool ops Date: Fri, 26 Jun 2015 18:32:48 -0700 Message-ID: <20150626183248.44a55e34@urahara> References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1435367948-20240-1-git-send-email-liang-min.wang@intel.com> <1435367948-20240-3-git-send-email-liang-min.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Liang-Min Larry Wang Return-path: Received: from mail-pd0-f177.google.com (mail-pd0-f177.google.com [209.85.192.177]) by dpdk.org (Postfix) with ESMTP id A6908CA18 for ; Sat, 27 Jun 2015 03:32:43 +0200 (CEST) Received: by pdbci14 with SMTP id ci14so83972330pdb.2 for ; Fri, 26 Jun 2015 18:32:43 -0700 (PDT) In-Reply-To: <1435367948-20240-3-git-send-email-liang-min.wang@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 26 Jun 2015 21:19:05 -0400 Liang-Min Larry Wang wrote: > +static int > +ixgbe_get_reg_length(struct rte_eth_dev *dev __rte_unused) > +{ > + struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private) The dev arg is used, and therefore should not be marked __rte_unused.