From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v9 2/5] ixgbe: add ops to support ethtool ops
Date: Fri, 26 Jun 2015 18:34:03 -0700
Message-ID: <20150626183403.6a3dc4fb@urahara>
References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com>
 <1435367948-20240-1-git-send-email-liang-min.wang@intel.com>
 <1435367948-20240-3-git-send-email-liang-min.wang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Liang-Min Larry Wang <liang-min.wang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com
 [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id D0A23CA5E
 for <dev@dpdk.org>; Sat, 27 Jun 2015 03:33:57 +0200 (CEST)
Received: by paceq1 with SMTP id eq1so76381615pac.3
 for <dev@dpdk.org>; Fri, 26 Jun 2015 18:33:57 -0700 (PDT)
In-Reply-To: <1435367948-20240-3-git-send-email-liang-min.wang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 26 Jun 2015 21:19:05 -0400
Liang-Min Larry Wang <liang-min.wang@intel.com> wrote:

> +	reg_group = reg_set[g_ind++];
> +	while (reg_group) {
> +		count += ixgbe_regs_group_count(reg_group);
> +		reg_group = reg_set[g_ind++];
> +	}

I don't care what checkpatch says, this an example of a loop
which reads better as:

        while ((reg_group = reg_set[g_ind++]))
               count += ixgbe_regs_group_count(reg_group);