From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750980AbbF3Hgs (ORCPT ); Tue, 30 Jun 2015 03:36:48 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:34295 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846AbbF3Hgi (ORCPT ); Tue, 30 Jun 2015 03:36:38 -0400 Date: Tue, 30 Jun 2015 13:05:57 +0530 From: Sudip Mukherjee To: Juston Li Cc: teddy.wang@siliconmotion.com, Greg KH , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators Message-ID: <20150630073557.GA5067@sudip-PC> References: <1435163120-3253-11-git-send-email-juston.h.li@gmail.com> <20150625115618.GC13366@sudip-PC> <20150626040543.GB3050@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 25, 2015 at 10:53:33PM -0700, Juston Li wrote: > On Thu, Jun 25, 2015 at 9:05 PM, Sudip Mukherjee > wrote: > > Usually I use the checkpatch which is in linux-next. That will be the > > latest version. If you compare, last commit on checkpatch of staging > > tree was on April 16th, where as last commit in linux-next is on > > June 19th. And if you use this checkpatch you will see these warnings > > also. :) > > Just wanted to clarify. So even with the linux-next checkpatch.pl, no > errors/warnings show for me. Only when I run checkpatch.pl with the > '--strict' option does it give the following checks for various operators: > CHECK: space preferred before that '|' (ctx:VxE) > > Are these the warnings you are referring too? Do you want me to fix all > of these for this patch? Hi, Sorry for the late reply, was a bit busy. since your commit message was saying "spacing around operators" and you were fixing the spacing around all types of operators so there is no point leaving few not fixed on the same line. But anyways, since you have already sent new series, its ok. regards sudip From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Date: Tue, 30 Jun 2015 07:47:57 +0000 Subject: Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators Message-Id: <20150630073557.GA5067@sudip-PC> List-Id: References: <1435163120-3253-11-git-send-email-juston.h.li@gmail.com> <20150625115618.GC13366@sudip-PC> <20150626040543.GB3050@sudip-PC> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Juston Li Cc: teddy.wang@siliconmotion.com, Greg KH , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Dan Carpenter On Thu, Jun 25, 2015 at 10:53:33PM -0700, Juston Li wrote: > On Thu, Jun 25, 2015 at 9:05 PM, Sudip Mukherjee > wrote: > > Usually I use the checkpatch which is in linux-next. That will be the > > latest version. If you compare, last commit on checkpatch of staging > > tree was on April 16th, where as last commit in linux-next is on > > June 19th. And if you use this checkpatch you will see these warnings > > also. :) > > Just wanted to clarify. So even with the linux-next checkpatch.pl, no > errors/warnings show for me. Only when I run checkpatch.pl with the > '--strict' option does it give the following checks for various operators: > CHECK: space preferred before that '|' (ctx:VxE) > > Are these the warnings you are referring too? Do you want me to fix all > of these for this patch? Hi, Sorry for the late reply, was a bit busy. since your commit message was saying "spacing around operators" and you were fixing the spacing around all types of operators so there is no point leaving few not fixed on the same line. But anyways, since you have already sent new series, its ok. regards sudip