From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v4] eal: Enable Port Hotplug as default in Linux and BSD Date: Tue, 30 Jun 2015 16:40:12 +0100 Message-ID: <20150630154011.GA6680@bricha3-MOBL3> References: <1435546610-4533-9-git-send-email-mukawa@igel.co.jp> <1435652811-3487-1-git-send-email-mukawa@igel.co.jp> <1435652811-3487-2-git-send-email-mukawa@igel.co.jp> <8CEF83825BEC744B83065625E567D7C204A435E7@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "dev@dpdk.org" To: "Iremonger, Bernard" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 6B92E5A87 for ; Tue, 30 Jun 2015 17:40:21 +0200 (CEST) Content-Disposition: inline In-Reply-To: <8CEF83825BEC744B83065625E567D7C204A435E7@IRSMSX108.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 30, 2015 at 04:08:08PM +0100, Iremonger, Bernard wrote: > > > -----Original Message----- > > From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] > > Sent: Tuesday, June 30, 2015 9:27 AM > > To: dev@dpdk.org > > Cc: Iremonger, Bernard; david.marchand@6wind.com; Richardson, Bruce; > > Tetsuya.Mukawa > > Subject: [PATCH v4] eal: Enable Port Hotplug as default in Linux and BSD > > > > From: "Tetsuya.Mukawa" > > > > This patch removes CONFIG_RTE_LIBRTE_EAL_HOTPLUG option, and enables > > it as default in both Linux and BSD. > > Also, to support port hotplug, rte_eal_pci_scan() and below missing symbols > > should be exported to ethdev library. > > - rte_eal_parse_devargs_str() > > - rte_eal_pci_close_one() > > - rte_eal_pci_probe_one() > > - rte_eal_pci_scan() > > - rte_eal_vdev_init() > > - rte_eal_vdev_uninit() > > > > Signed-off-by: Tetsuya Mukawa > > Hi Tetsuya, > > Would it be cleaner to add this patch to the [PATCH v7 12/12] patch set as patch 13 rather than having it as a separate patch? > The other patch set is cleanup, merging BSD and Linuxapp code, so I think it's best kept as a separate set. New features I'd suggest keeping separate from cleanup. That being said, it is only one patch, so it probably doesn't matter much either way. :-) /Bruce