From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753300AbbGATVP (ORCPT ); Wed, 1 Jul 2015 15:21:15 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36907 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750912AbbGATVI (ORCPT ); Wed, 1 Jul 2015 15:21:08 -0400 Date: Wed, 1 Jul 2015 21:21:02 +0200 From: Jan Kara To: Tejun Heo Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, jack@suse.cz, hch@infradead.org, hannes@cmpxchg.org, linux-fsdevel@vger.kernel.org, vgoyal@redhat.com, lizefan@huawei.com, cgroups@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.cz, clm@fb.com, fengguang.wu@intel.com, david@fromorbit.com, gthelen@google.com, khlebnikov@yandex-team.ru, Andrew Morton Subject: Re: [PATCH 49/51] buffer, writeback: make __block_write_full_page() honor cgroup writeback Message-ID: <20150701192102.GK7252@quack.suse.cz> References: <1432329245-5844-1-git-send-email-tj@kernel.org> <1432329245-5844-50-git-send-email-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432329245-5844-50-git-send-email-tj@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 22-05-15 17:14:03, Tejun Heo wrote: > [__]block_write_full_page() is used to implement ->writepage in > various filesystems. All writeback logic is now updated to handle > cgroup writeback and the block cgroup to issue IOs for is encoded in > writeback_control and can be retrieved from the inode; however, > [__]block_write_full_page() currently ignores the blkcg indicated by > inode and issues all bio's without explicit blkcg association. > > This patch adds submit_bh_blkcg() which associates the bio with the > specified blkio cgroup before issuing and uses it in > __block_write_full_page() so that the issued bio's are associated with > inode_to_wb_blkcg_css(inode). One comment below... > @@ -44,6 +45,9 @@ > #include > > static int fsync_buffers_list(spinlock_t *lock, struct list_head *list); > +static int submit_bh_blkcg(int rw, struct buffer_head *bh, > + unsigned long bio_flags, The argument bio_flags is unused. What is is good for? Honza -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by kanga.kvack.org (Postfix) with ESMTP id C25996B0254 for ; Wed, 1 Jul 2015 15:21:08 -0400 (EDT) Received: by wicgi11 with SMTP id gi11so54493953wic.0 for ; Wed, 01 Jul 2015 12:21:08 -0700 (PDT) Received: from mx2.suse.de (cantor2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id eg9si4936765wjd.184.2015.07.01.12.21.06 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 01 Jul 2015 12:21:07 -0700 (PDT) Date: Wed, 1 Jul 2015 21:21:02 +0200 From: Jan Kara Subject: Re: [PATCH 49/51] buffer, writeback: make __block_write_full_page() honor cgroup writeback Message-ID: <20150701192102.GK7252@quack.suse.cz> References: <1432329245-5844-1-git-send-email-tj@kernel.org> <1432329245-5844-50-git-send-email-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432329245-5844-50-git-send-email-tj@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Tejun Heo Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, jack@suse.cz, hch@infradead.org, hannes@cmpxchg.org, linux-fsdevel@vger.kernel.org, vgoyal@redhat.com, lizefan@huawei.com, cgroups@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.cz, clm@fb.com, fengguang.wu@intel.com, david@fromorbit.com, gthelen@google.com, khlebnikov@yandex-team.ru, Andrew Morton On Fri 22-05-15 17:14:03, Tejun Heo wrote: > [__]block_write_full_page() is used to implement ->writepage in > various filesystems. All writeback logic is now updated to handle > cgroup writeback and the block cgroup to issue IOs for is encoded in > writeback_control and can be retrieved from the inode; however, > [__]block_write_full_page() currently ignores the blkcg indicated by > inode and issues all bio's without explicit blkcg association. > > This patch adds submit_bh_blkcg() which associates the bio with the > specified blkio cgroup before issuing and uses it in > __block_write_full_page() so that the issued bio's are associated with > inode_to_wb_blkcg_css(inode). One comment below... > @@ -44,6 +45,9 @@ > #include > > static int fsync_buffers_list(spinlock_t *lock, struct list_head *list); > +static int submit_bh_blkcg(int rw, struct buffer_head *bh, > + unsigned long bio_flags, The argument bio_flags is unused. What is is good for? Honza -- Jan Kara SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org