From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Fix failure paths around initial
 fbdev allocation
Date: Thu, 2 Jul 2015 16:37:28 +0300
Message-ID: <20150702133728.GA5176@intel.com>
References: <1435655187-8769-1-git-send-email-tvrtko.ursulin@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id 8BEB67A118
 for <Intel-gfx@lists.freedesktop.org>; Thu,  2 Jul 2015 06:37:41 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1435655187-8769-1-git-send-email-tvrtko.ursulin@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBKdW4gMzAsIDIwMTUgYXQgMTA6MDY6MjdBTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g
d3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K
PiAKPiBXZSBoYWQgdGhyZWUgZmFpbHVyZSBtb2RlcyBoZXJlOgo+IAo+IDEuCj4gRGVhZGxvY2sg
aW4gaW50ZWxmYl9hbGxvYyBmYWlsdXJlIHBhdGggd2hlcmUgaXQgY2FsbHMKPiBkcm1fZnJhbWVi
dWZmZXJfcmVtb3ZlLCB3aGljaCBncmFicyB0aGUgc3RydWN0IG11dGV4IGFuZCBpbnRlbGZiX2Ny
ZWF0ZQo+IChjYWxsZXIgb2YgaW50ZWxmYl9hbGxvYykgd2FzIGFscmVhZHkgaG9sZGluZyBpdC4K
PiAKPiAyLgo+IERvdWJsZSB1bnJlZmVyZW5jZSBvbiB0aGUgb2JqZWN0IGlmIF9faW50ZWxfZnJh
bWVidWZmZXJfY3JlYXRlIGZhaWxzCj4gc2luY2UgYm90aCBpdCBhbmQgdGhlIGNhbGxlciAoaW50
ZWxmYl9hbGxvYykgZG8gdGhlIHVucmVmZXJlbmNlLgo+IAo+IDMuCj4gRGVhZGxvY2sgaW4gaW50
ZWxmYl9jcmVhdGUgZmFpbHVyZSBwYXRoIHdoZXJlIGl0IGNhbGxzCj4gZHJtX2ZyYW1lYnVmZmVy
X3VucmVmZXJlbmNlLCB3aGljaCBncmFicyB0aGUgc3RydWN0IG11dGV4IGFuZAo+IGludGVsZmJf
Y3JlYXRlIHdhcyBhbHJlYWR5IGhvbGRpbmcgaXQuCj4gCj4gdjI6Cj4gICAgKiBSZWZvcm1hdCBj
b21taXQgbXNnIHRvIDcyIGNoYXJzLiAoTHVrYXMgV3VubmVyKQo+ICAgICogQWRkZWQgdGhpcmQg
ZmFpbHVyZSBtb2RlLiAoTHVrYXMgV3VubmVyKQo+IAo+IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBV
cnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gRml4ZXM6IDYwYTVjYTAxNWZmZDJh
YWNmZTU2NzRiNWE0MDFjZDJhMzcxNTllMDcKPiBSZXBvcnRlZC1CeTogTHVrYXMgV3VubmVyIDxs
dWthc0B3dW5uZXIuZGU+Cj4gVGVzdGVkLUJ5OiBMdWthcyBXdW5uZXIgPGx1a2FzQHd1bm5lci5k
ZT4KPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IFZp
bGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEx1a2Fz
IFd1bm5lciA8bHVrYXNAd3VubmVyLmRlPgo+IC0tLQo+IFZpbGxlLCB5b3Ugc3VnZ2VzdGVkIHNv
bWUgY2hhbmdlcyBlYXJsaWVyOwo+IAo+ICIiIgo+IEkgc3VnZ2VzdCByZW1vdmluZyB0aGUgdW5y
ZWYgZnJvbSBfX2ludGVsX2ZyYW1lYnVmZmVyX2NyZWF0ZSgpLgo+ICIiIgo+IAo+IERvIHlvdSB2
aWV3IHRoYXQgYXMgYW4gaW1wcm92ZW1lbnQgaW4gY29kZSBjbGFyaXR5L29yZ2FuaXNhdGlvbiwK
PiBvciB5b3UgdGhpbmsgbXkgdmVyc2lvbiBpcyBhY3R1YWxseSB3cm9uZyBmb3Igc29tZSByZWFz
b24/CgpJIGZpbmQgaXQgcmF0aGVyIHVuZXhwZWN0ZWQgdGhhdCB0aGUgZnVuY3Rpb24gZHJvcHMg
dGhlIHBhc3NlZApyZWZlcmVuY2Ugb24gZXJyb3IuIE15IHVzdWFsIHJ1bGUgaXM6IGRvIG5vdGhp
bmcgb24gZXJyb3IsIGlmIHBvc3NpYmxlLgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfZmJkZXYuYyB8IDIxICsrKysrKysrKysrKystLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdl
ZCwgMTMgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJkZXYuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX2ZiZGV2LmMKPiBpbmRleCAyYTE3MjRlLi4xMTg0MjBiIDEwMDY0NAo+IC0tLSBhL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9mYmRldi5jCj4gQEAgLTE0MSw3ICsxNDEsNyBAQCBzdGF0aWMgaW50IGludGVsZmJf
YWxsb2Moc3RydWN0IGRybV9mYl9oZWxwZXIgKmhlbHBlciwKPiAgewo+ICAJc3RydWN0IGludGVs
X2ZiZGV2ICppZmJkZXYgPQo+ICAJCWNvbnRhaW5lcl9vZihoZWxwZXIsIHN0cnVjdCBpbnRlbF9m
YmRldiwgaGVscGVyKTsKPiAtCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiOwo+ICsJc3RydWN0
IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBOVUxMOwo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9
IGhlbHBlci0+ZGV2Owo+ICAJc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgbW9kZV9jbWQgPSB7fTsK
PiAgCXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmo7Cj4gQEAgLTE1OSw2ICsxNTksOCBA
QCBzdGF0aWMgaW50IGludGVsZmJfYWxsb2Moc3RydWN0IGRybV9mYl9oZWxwZXIgKmhlbHBlciwK
PiAgCW1vZGVfY21kLnBpeGVsX2Zvcm1hdCA9IGRybV9tb2RlX2xlZ2FjeV9mYl9mb3JtYXQoc2l6
ZXMtPnN1cmZhY2VfYnBwLAo+ICAJCQkJCQkJICBzaXplcy0+c3VyZmFjZV9kZXB0aCk7Cj4gIAo+
ICsJbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICsKPiAgCXNpemUgPSBtb2RlX2Nt
ZC5waXRjaGVzWzBdICogbW9kZV9jbWQuaGVpZ2h0Owo+ICAJc2l6ZSA9IFBBR0VfQUxJR04oc2l6
ZSk7Cj4gIAlvYmogPSBpOTE1X2dlbV9vYmplY3RfY3JlYXRlX3N0b2xlbihkZXYsIHNpemUpOwo+
IEBAIC0xNzIsOCArMTc0LDkgQEAgc3RhdGljIGludCBpbnRlbGZiX2FsbG9jKHN0cnVjdCBkcm1f
ZmJfaGVscGVyICpoZWxwZXIsCj4gIAo+ICAJZmIgPSBfX2ludGVsX2ZyYW1lYnVmZmVyX2NyZWF0
ZShkZXYsICZtb2RlX2NtZCwgb2JqKTsKPiAgCWlmIChJU19FUlIoZmIpKSB7Cj4gKwkJLyogRHJv
cHMgb2JqZWN0IHJlZmVyZW5jZSBvbiBmYWlsdXJlLiAqLwo+ICAJCXJldCA9IFBUUl9FUlIoZmIp
Owo+IC0JCWdvdG8gb3V0X3VucmVmOwo+ICsJCWdvdG8gb3V0Owo+ICAJfQo+ICAKPiAgCS8qIEZs
dXNoIGV2ZXJ5dGhpbmcgb3V0LCB3ZSdsbCBiZSBkb2luZyBHVFQgb25seSBmcm9tIG5vdyBvbiAq
Lwo+IEBAIC0xODMsMTUgKzE4NiwxOCBAQCBzdGF0aWMgaW50IGludGVsZmJfYWxsb2Moc3RydWN0
IGRybV9mYl9oZWxwZXIgKmhlbHBlciwKPiAgCQlnb3RvIG91dF9mYjsKPiAgCX0KPiAgCj4gKwlt
dXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiArCj4gIAlpZmJkZXYtPmZiID0gdG9f
aW50ZWxfZnJhbWVidWZmZXIoZmIpOwo+ICAKPiAgCXJldHVybiAwOwo+ICAKPiAgb3V0X2ZiOgo+
IC0JZHJtX2ZyYW1lYnVmZmVyX3JlbW92ZShmYik7Cj4gLW91dF91bnJlZjoKPiAgCWRybV9nZW1f
b2JqZWN0X3VucmVmZXJlbmNlKCZvYmotPmJhc2UpOwo+ICBvdXQ6Cj4gKwltdXRleF91bmxvY2so
JmRldi0+c3RydWN0X211dGV4KTsKPiArCWlmIChmYikKPiArCQlkcm1fZnJhbWVidWZmZXJfcmVt
b3ZlKGZiKTsKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gQEAgLTIwOSw4ICsyMTUsNiBAQCBz
dGF0aWMgaW50IGludGVsZmJfY3JlYXRlKHN0cnVjdCBkcm1fZmJfaGVscGVyICpoZWxwZXIsCj4g
IAlpbnQgc2l6ZSwgcmV0Owo+ICAJYm9vbCBwcmVhbGxvYyA9IGZhbHNlOwo+ICAKPiAtCW11dGV4
X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiAtCj4gIAlpZiAoaW50ZWxfZmIgJiYKPiAgCSAg
ICAoc2l6ZXMtPmZiX3dpZHRoID4gaW50ZWxfZmItPmJhc2Uud2lkdGggfHwKPiAgCSAgICAgc2l6
ZXMtPmZiX2hlaWdodCA+IGludGVsX2ZiLT5iYXNlLmhlaWdodCkpIHsKPiBAQCAtMjI1LDcgKzIy
OSw3IEBAIHN0YXRpYyBpbnQgaW50ZWxmYl9jcmVhdGUoc3RydWN0IGRybV9mYl9oZWxwZXIgKmhl
bHBlciwKPiAgCQlEUk1fREVCVUdfS01TKCJubyBCSU9TIGZiLCBhbGxvY2F0aW5nIGEgbmV3IG9u
ZVxuIik7Cj4gIAkJcmV0ID0gaW50ZWxmYl9hbGxvYyhoZWxwZXIsIHNpemVzKTsKPiAgCQlpZiAo
cmV0KQo+IC0JCQlnb3RvIG91dF91bmxvY2s7Cj4gKwkJCXJldHVybiByZXQ7Cj4gIAkJaW50ZWxf
ZmIgPSBpZmJkZXYtPmZiOwo+ICAJfSBlbHNlIHsKPiAgCQlEUk1fREVCVUdfS01TKCJyZS11c2lu
ZyBCSU9TIGZiXG4iKTsKPiBAQCAtMjM3LDYgKzI0MSw4IEBAIHN0YXRpYyBpbnQgaW50ZWxmYl9j
cmVhdGUoc3RydWN0IGRybV9mYl9oZWxwZXIgKmhlbHBlciwKPiAgCW9iaiA9IGludGVsX2ZiLT5v
Ymo7Cj4gIAlzaXplID0gb2JqLT5iYXNlLnNpemU7Cj4gIAo+ICsJbXV0ZXhfbG9jaygmZGV2LT5z
dHJ1Y3RfbXV0ZXgpOwo+ICsKPiAgCWluZm8gPSBmcmFtZWJ1ZmZlcl9hbGxvYygwLCAmZGV2LT5w
ZGV2LT5kZXYpOwo+ICAJaWYgKCFpbmZvKSB7Cj4gIAkJcmV0ID0gLUVOT01FTTsKPiBAQCAtMzA3
LDcgKzMxMyw2IEBAIHN0YXRpYyBpbnQgaW50ZWxmYl9jcmVhdGUoc3RydWN0IGRybV9mYl9oZWxw
ZXIgKmhlbHBlciwKPiAgb3V0X3VucGluOgo+ICAJaTkxNV9nZW1fb2JqZWN0X2dndHRfdW5waW4o
b2JqKTsKPiAgCWRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlKCZvYmotPmJhc2UpOwo+IC1vdXRf
dW5sb2NrOgo+ICAJbXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gIAlyZXR1cm4g
cmV0Owo+ICB9Cj4gLS0gCj4gMi40LjIKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt
YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==