From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v3 12/13] x86/altp2m: Add altp2mhvm HVM
	domain parameter.
Date: Mon, 6 Jul 2015 19:18:13 +0100
Message-ID: <20150706181813.GM1134@zion.uk.xensource.com>
References: <1435774177-6345-1-git-send-email-edmund.h.white@intel.com>
	<1435774177-6345-13-git-send-email-edmund.h.white@intel.com>
	<20150706174954.GJ1134@zion.uk.xensource.com>
	<559AC277.8050501@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <559AC277.8050501@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ed White <edmund.h.white@intel.com>
Cc: Ravi Sahita <ravi.sahita@intel.com>, Wei Liu <wei.liu2@citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, tlengyel@novetta.com, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

On Mon, Jul 06, 2015 at 11:01:27AM -0700, Ed White wrote:
> On 07/06/2015 10:49 AM, Wei Liu wrote:
> >> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> >> index 23f27d4..66a89cf 100644
> >> --- a/tools/libxl/libxl_types.idl
> >> +++ b/tools/libxl/libxl_types.idl
> >> @@ -437,6 +437,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
> >>                                         ("mmio_hole_memkb",  MemKB),
> >>                                         ("timer_mode",       libxl_timer_mode),
> >>                                         ("nested_hvm",       libxl_defbool),
> >> +                                       ("altp2mhvm",        libxl_defbool),
> > 
> > It's redundant to have "hvm" in the name of this field. Calling it
> > "altp2m" would be fine IMHO.
> > 
> 
> When I originally started writing this code, I modelled the naming
> and some of the structure on nestedhvm, which is why so many things
> had hvm in the name. I've now removed a lot of those, but in this
> instance I wonder if doing so would cause confusion, since we have
> a Xen command-line parameter called altp2m.
> 

I don't think it will cause confusion. This is part of guest
configuration which has nothing to do with Xen and in theory another
name space.

I asked you to remove hvm because it's redundant -- that field is a
sub-field of u.hvm already.

Wei.

> Ed