From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolin Chen <nicoleotsuka@gmail.com>
Date: Thu, 09 Jul 2015 14:59:47 +0000
Subject: Re: [patch] ASoC: fsl: fsl_spdif: signedness bug in fsl_spdif_startup()
Message-Id: <20150709145946.GA5692@Asurada>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20150709082103.GA13462@mwanda>
In-Reply-To: <20150709082103.GA13462@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Timur Tabi <timur@tabi.org>, Fabio Estevam <fabio.estevam@freescale.com>, Xiubo Li <Xiubo.Lee@gmail.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org

On Thu, Jul 09, 2015 at 11:21:03AM +0300, Dan Carpenter wrote:
> We need "i" to be signed or it leads to a forever loop in the error
> handling.
> 
> Fixes: fa3be9208dcb ('ASoC: fsl: fsl_spdif: Check for clk_prepare_enable() error')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>


Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>

Thank you

> diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
> index 3ee4539..7a92f30 100644
> --- a/sound/soc/fsl/fsl_spdif.c
> +++ b/sound/soc/fsl/fsl_spdif.c
> @@ -454,7 +454,8 @@ static int fsl_spdif_startup(struct snd_pcm_substream *substream,
>  	struct fsl_spdif_priv *spdif_priv = snd_soc_dai_get_drvdata(rtd->cpu_dai);
>  	struct platform_device *pdev = spdif_priv->pdev;
>  	struct regmap *regmap = spdif_priv->regmap;
> -	u32 scr, mask, i;
> +	u32 scr, mask;
> +	int i;
>  	int ret;
>  
>  	/* Reset module and interrupts only for first initialization */

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolin Chen <nicoleotsuka@gmail.com>
Subject: Re: [patch] ASoC: fsl: fsl_spdif: signedness bug in
 fsl_spdif_startup()
Date: Thu, 9 Jul 2015 07:59:47 -0700
Message-ID: <20150709145946.GA5692@Asurada>
References: <20150709082103.GA13462@mwanda>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <kernel-janitors-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20150709082103.GA13462@mwanda>
Sender: kernel-janitors-owner@vger.kernel.org
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Timur Tabi <timur@tabi.org>, Fabio Estevam <fabio.estevam@freescale.com>, Xiubo Li <Xiubo.Lee@gmail.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
List-Id: alsa-devel@alsa-project.org

On Thu, Jul 09, 2015 at 11:21:03AM +0300, Dan Carpenter wrote:
> We need "i" to be signed or it leads to a forever loop in the error
> handling.
> 
> Fixes: fa3be9208dcb ('ASoC: fsl: fsl_spdif: Check for clk_prepare_enable() error')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>


Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>

Thank you

> diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
> index 3ee4539..7a92f30 100644
> --- a/sound/soc/fsl/fsl_spdif.c
> +++ b/sound/soc/fsl/fsl_spdif.c
> @@ -454,7 +454,8 @@ static int fsl_spdif_startup(struct snd_pcm_substream *substream,
>  	struct fsl_spdif_priv *spdif_priv = snd_soc_dai_get_drvdata(rtd->cpu_dai);
>  	struct platform_device *pdev = spdif_priv->pdev;
>  	struct regmap *regmap = spdif_priv->regmap;
> -	u32 scr, mask, i;
> +	u32 scr, mask;
> +	int i;
>  	int ret;
>  
>  	/* Reset module and interrupts only for first initialization */