Re: [PATCH OSSTEST 08/12] ts-libvirt-build: run libvirt test suite

[Wei Liu <wei.liu2@citrix.com>]

On Wed, Mar 11, 2015 at 04:31:25PM +0000, Ian Campbell wrote:
> On Mon, 2015-02-09 at 11:10 +0000, Wei Liu wrote:
> > We're interested in xlconfigtest. Since we're running test anyway run
> > the whole suite.
> 
> This is run at build time? I take it doesn't (and will never) require an
> active system?
> 

Yes, build time. It doesn't require an active system.

"The internal test suite: present in the source code, it is run by
developers before submitting patches upstream, it is also suggested to
have it run and pass as part of the packaging process for
distributions."

What we do with libvirt is a bit like "packaging" so I would like to
have it run.

> > @@ -69,7 +61,10 @@ END
> >  sub build() {
> >      target_cmd_build($ho, 3600, $builddir, <<END);
> >          cd libvirt
> > -        (make $makeflags 2>&1 && touch ../build-ok-stamp) |tee ../log
> > +        (make $makeflags 2>&1 && \\
> > +         LD_LIBRARY_PATH=$xenprefix/lib/ \\
> > +           make check VIR_TEST_EXPENSIVE=1 2>&1 && \\
> > +         touch ../build-ok-stamp) |tee ../log
> 
> I think this would be preferable as a separate target_cmd_build
> invocation to run the tests, to make it clearer in the logs what
> happened.
> 

Ack.

Wei.