From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752653AbbGOMvA (ORCPT ); Wed, 15 Jul 2015 08:51:00 -0400 Received: from mail-bn1bon0117.outbound.protection.outlook.com ([157.56.111.117]:63714 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751800AbbGOMu4 (ORCPT ); Wed, 15 Jul 2015 08:50:56 -0400 X-Greylist: delayed 1115 seconds by postgrey-1.27 at vger.kernel.org; Wed, 15 Jul 2015 08:50:56 EDT Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none; Date: Wed, 15 Jul 2015 20:29:56 +0800 From: Dong Aisheng To: CC: Dong Aisheng , , , , , , , , , Subject: Re: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after Message-ID: <20150715122955.GB30570@shlinux1.ap.freescale.net> References: <1431610143-21853-1-git-send-email-aisheng.dong@freescale.com> <1431610143-21853-2-git-send-email-aisheng.dong@freescale.com> <20150528040919.22384.79189@quantum> <20150715122522.GA30570@shlinux1.ap.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150715122522.GA30570@shlinux1.ap.freescale.net> User-Agent: Mutt/1.5.20 (2009-06-14) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD020;1:3pWmcwnqFr7KYc6UQJK+KuTlj6Um7hMwZ9fS6EwtyjcYx2rdua3haY69UKG7no/ZeuFTM9jE263RdFiwNMmoSmTz+6vrgLmAs8Rsn5V0iR8z+HMt3db2+JFgJ42nSOo3Ou9bGskbtrMyZVVyK9qpRl0NoJEfrQE3wbj3cSU5LxurfGorR9J/RiFO/52v/4Sh2ZMldN3VR5GTwl0FLK4763GV0afo/SCb7AWzJCKmofpOtlbv0Xastjj5nzfqpD8T899tCBizzv5Sfr1OgogqqlV4kbRbwacMMAm/XeOGD7tgb086zHWUy05mzVtaPIp82J8e442x9o9IjBjpa1Jlk4Br+2/JWSROfyCo3ojPAbJn4Kgof3UtH0vLhgvHrsgRAxjt4mEm+kzk7+0vEU1FMtfZuOGY/IftHKpUdDa+oiFSJOCgFoc/TaQs2kc1kn17 X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(339900001)(199003)(189002)(24454002)(377424004)(85426001)(46102003)(46406003)(2351001)(104016003)(19580395003)(23726002)(93886004)(87936001)(76176999)(47776003)(19580405001)(50986999)(97756001)(6806004)(50466002)(62966003)(77156002)(105606002)(77096005)(54356999)(106466001)(189998001)(5001960100002)(110136002)(4001350100001)(92566002)(33656002)(107886002)(83506001)(2950100001)(5003600100002)(4001430100001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR0301MB1204;H:az84smr01.freescale.net;FPR:;SPF:Fail;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1204;2:7yNARtu+GtPwXxcDjCS45PTN98RCDxH5a6vuVB+5Atbq99+cFalCPVQV6OsO5qk8;3:SMSNOuPhGbRzOMBHEaN/L/zOzLEyWTZBadbxE1y31cD2cKj2VRZGxVinVAjZ7IwXxcJ/xTSwBjPaIII1v7ZAT+NgEATdEik32oBFkFtxK38UoQb4C84l2Aoeb44mpcgh+rJiISjxsaiQXVnDmSIfYvzhMiHgOof4TQ0ae+g9PaZg7cybT/Gm87brNDwW7atqBfq7N3uPCrz6XeB3af0VOrQAGWqWGlMnT+fQGiH2+xc=;25:kl6zk0SYp4dycrYlTiSN4zKIJA3BrC5tTsSMop5ud41W14ARTDHRm87k8yLxusm3dTjiSwF2MS+e28+mD2nSH6SaNtxJbNy01eWdCPC0cPAZdqpEqrqm1hFqruySrSsh83aEO28JoWpyVg04lDxSM/iDns+VZaZ4bAUsURclvg+H6MY3RmnoksLs1+BsbglVE2vQm0Xx4udC0CHrNq1I5yHn3ecgaZHDNrPgwD7ix+HgBoCOOMzJeWeyXpWDIoL4XgnaddEERrdx+qPcmQWvIA==;20:hWV0v65UwGO/b0BG8LT6J9od6OhCdPi5AvY3XFIpsXg2kzPZX33qDmsv9P13mm057p6tOIoLQRSQFlaBghRmYgCFUgSPVQPs0PPotWtV+KhZbOmTkvkmJv4HiPT4MyflVqbq1nkP5DiYvQ5RqdC2QIGzQkxbrKXD+SmiTubNtMHsuVvLiVdwJa7XyklltlqycoZDmP+QGgQMbdKgbT6BeJRgBpsygBZrUHtL/Ier5QoWx38+qnz7Ti5Hh9fN9SC0QarewbT6dCFh2P6DXTgrOy42fBZj56I3cq4EC0A5JKcPEHNe4NVTUozvFUuPHzTn0KIJaxEBMdSXXynL4+eiZYhFzv8angprBciA9pODpDk= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB1204; BN3PR0301MB1204: X-MS-Exchange-Organization-RulesExecuted X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BN3PR0301MB1204;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB1204; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1204;4:Bp0B+rJQA8/lC2mQ2DZ6OG2Rhk9Xtiebpd5Ucc4sEjZl146hh6c8e+QCLP1FgaHcYK81D5oP76hItba9uSAPYQye8oO9HNlu+OzzGopU9vBKfEpSorBJSmfUviTuIZwDeC0Ij1H/4/U7vI+Vawap1sEmLX9FYH55P7jFolL5p7Xqpsul6OUZleyl2Ub7Rz/dZRA87bUiZaOKThfW9Gh38ypP0NN23Xg3klfJpHr/I3MpBoppvhFsKWGcozPdcV6rjNjIe0TNm6wxI2ZOYcL57bDXfnpuZi99ry++TULsXO0= X-Forefront-PRVS: 0638FD5066 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR0301MB1204;23:Km0LksNkelzYg+NUSqGB1xfxY03IrWoFz1tiXmg?= =?us-ascii?Q?w9RzqhZ3v80QryMWnTG2AEnHeQ5Q7djGGjHJTeeExrSPpFnTE49AlDHLz1EB?= =?us-ascii?Q?VI2UbPeInG+fhBe2aUFAWMDpUM6U34poYTo4bAoED8hWRf/CVRW3Feawr5nf?= =?us-ascii?Q?KoFCNzJR0Yhalg8lwIIPjgJq1x2mGiDp9We4boj33tKzQ/WONEBrR6dgceGg?= =?us-ascii?Q?rcYvZvmkqFYn3rQ7/8P7gnc0mfCM2gthghFEKhdCo04ulQy1+eouQZEbigQq?= =?us-ascii?Q?8IHwJeRlBFjYJGKJLVnB/2DbLbvs/+N0OD0unKs2UxmdVOn7craSeBv0GIvk?= =?us-ascii?Q?q03SQM1FV/azQy+IJg+95wjfjTXZahV95Ku6O8Rp1AqnNCLb6EbBe9DtAkgf?= =?us-ascii?Q?AoLG6G5hovBSTq2sHuP8F511u0Ajdw09uln0cCfs9efLj8SgIm5NnLHDH6Q5?= =?us-ascii?Q?vLxYhBqAxhwH78mQAi+RZW4hEQyH31jvt3gUQ1FH0pevYkr1nNR0TSHjcTDE?= =?us-ascii?Q?rpryNAN5lM/nTqMh96mTe0yqYMLAAPwyAWCkV0PJiVY4a9zOGG7x3+yuBDNu?= =?us-ascii?Q?l6ksjGMGiAUOto1Ggd7RgGjpyDCVCSA/47jzQh9V87NQkTxw/TMrH9aou30p?= =?us-ascii?Q?VfvLemnYvx71JlKtdkZnK69hazYa2Q/1j63mUX1DH0PYeT+gvjDMMlVHULsi?= =?us-ascii?Q?w1Y1cYaRG4EBMtNoH/XUgwmbF+MCOSmZt3jvDVCyrNmFn8RNxjjru4W9S2oD?= =?us-ascii?Q?0BhIY2AWTx3eVuyQRqlZXM3C3Mtizy6F9W+BZFF9Qj1m8Waqbn2aDzwYhCDr?= =?us-ascii?Q?1s22CCqOoTKxtBBEe7i8AufCR2/OyUj0WGjoJx6NqyWOCLLuGOtvl53QEnzi?= =?us-ascii?Q?/5cz+8VZwnue14YH/wzypY3aJaCfbz/m/t9/zE5s0/aW5T6/TxquVOGyfmJq?= =?us-ascii?Q?tZtqhLPPR/JyPnMvcTqXveW3LZi75gIoKd87Zc/Bvs8O1jap9E/hmLs26iGq?= =?us-ascii?Q?FFJNGxRXsa9YuCvU5eUkTb6ummKxLzKegMTUk2HybCRQZKyVDh0UCf+4YbvR?= =?us-ascii?Q?jnzFRocVAsswlPTIu/g9tEpLRmAb0?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1204;5:eoPFpG2HBm7+OyRzzA18NPZmQG69Vt8P8oYWLwI1xhZwQEwZD81vf/HVihEB9ukQoF/+acFMMSY2Z3m0tVQJvOac0e5dw7pF70d+gS4PBk9D0A8kE4nYQUT6wq+vDbDyM/vzrXcM6po1abJd1rF3qA==;24:IRl5neexQKf8c+HpKMPz73AyxsWH71GLulwN4wePHTzJ36gP5CJwEjOR4lQykSz6RY69t8I2bautHNnzrx7+W2bkMOQfCHEl2KjmN/ICSak=;20:5m5odFvGjKciLhQv6aEkX8S9IWfBfxnA+jlkfXKuTQc/sSEYRJWEwMfsacTlLBUMqgNCm71uq8TnQmsaPsxHCg== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2015 12:36:50.1264 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0301MB1204 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 15, 2015 at 08:25:24PM +0800, Dong Aisheng wrote: > Hi Mike, > > On Wed, May 27, 2015 at 09:09:19PM -0700, Michael Turquette wrote: > > Quoting Dong Aisheng (2015-05-14 06:28:59) > > > __clk_set_parent_after() actually used the second argument then we > > > could put this duplicate logic in there and call it with a different > > > order of arguments in the success vs. error paths in this function. > > > > > > Cc: Mike Turquette > > > Cc: Stephen Boyd > > > Suggested-by: Stephen Boyd > > > Signed-off-by: Dong Aisheng > > > > Patch looks good to me. > > > > Also just noticed that the second argument to __clk_set_parent_after is > > never used :-( > > > > Ping... > > I did not see this patch series in your tree for v4.2 rc. > Is this got missed? > Updated Mike's email address. Regards Dong Aisheng > Regards > Dong Aisheng > > > Regards, > > Mike > > > > > --- > > > drivers/clk/clk.c | 8 +------- > > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > > > index 659f2b0..0e813ea 100644 > > > --- a/drivers/clk/clk.c > > > +++ b/drivers/clk/clk.c > > > @@ -1159,14 +1159,8 @@ static int __clk_set_parent(struct clk_core *core, struct clk_core *parent, > > > flags = clk_enable_lock(); > > > clk_reparent(core, old_parent); > > > clk_enable_unlock(flags); > > > + __clk_set_parent_after(core, old_parent, parent); > > > > > > - if (core->prepare_count) { > > > - flags = clk_enable_lock(); > > > - clk_core_disable(core); > > > - clk_core_disable(parent); > > > - clk_enable_unlock(flags); > > > - clk_core_unprepare(parent); > > > - } > > > return ret; > > > } > > > > > > -- > > > 1.9.1 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 15 Jul 2015 20:29:56 +0800 From: Dong Aisheng To: Subject: Re: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after Message-ID: <20150715122955.GB30570@shlinux1.ap.freescale.net> References: <1431610143-21853-1-git-send-email-aisheng.dong@freescale.com> <1431610143-21853-2-git-send-email-aisheng.dong@freescale.com> <20150528040919.22384.79189@quantum> <20150715122522.GA30570@shlinux1.ap.freescale.net> MIME-Version: 1.0 In-Reply-To: <20150715122522.GA30570@shlinux1.ap.freescale.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dong Aisheng , Ranjani.Vaidyanathan@freescale.com, b20596@freescale.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, r64343@freescale.com, b20788@freescale.com, shawn.guo@linaro.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+mturquette=linaro.org@lists.infradead.org List-ID: On Wed, Jul 15, 2015 at 08:25:24PM +0800, Dong Aisheng wrote: > Hi Mike, > > On Wed, May 27, 2015 at 09:09:19PM -0700, Michael Turquette wrote: > > Quoting Dong Aisheng (2015-05-14 06:28:59) > > > __clk_set_parent_after() actually used the second argument then we > > > could put this duplicate logic in there and call it with a different > > > order of arguments in the success vs. error paths in this function. > > > > > > Cc: Mike Turquette > > > Cc: Stephen Boyd > > > Suggested-by: Stephen Boyd > > > Signed-off-by: Dong Aisheng > > > > Patch looks good to me. > > > > Also just noticed that the second argument to __clk_set_parent_after is > > never used :-( > > > > Ping... > > I did not see this patch series in your tree for v4.2 rc. > Is this got missed? > Updated Mike's email address. Regards Dong Aisheng > Regards > Dong Aisheng > > > Regards, > > Mike > > > > > --- > > > drivers/clk/clk.c | 8 +------- > > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > > > index 659f2b0..0e813ea 100644 > > > --- a/drivers/clk/clk.c > > > +++ b/drivers/clk/clk.c > > > @@ -1159,14 +1159,8 @@ static int __clk_set_parent(struct clk_core *core, struct clk_core *parent, > > > flags = clk_enable_lock(); > > > clk_reparent(core, old_parent); > > > clk_enable_unlock(flags); > > > + __clk_set_parent_after(core, old_parent, parent); > > > > > > - if (core->prepare_count) { > > > - flags = clk_enable_lock(); > > > - clk_core_disable(core); > > > - clk_core_disable(parent); > > > - clk_enable_unlock(flags); > > > - clk_core_unprepare(parent); > > > - } > > > return ret; > > > } > > > > > > -- > > > 1.9.1 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: b29396@freescale.com (Dong Aisheng) Date: Wed, 15 Jul 2015 20:29:56 +0800 Subject: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after In-Reply-To: <20150715122522.GA30570@shlinux1.ap.freescale.net> References: <1431610143-21853-1-git-send-email-aisheng.dong@freescale.com> <1431610143-21853-2-git-send-email-aisheng.dong@freescale.com> <20150528040919.22384.79189@quantum> <20150715122522.GA30570@shlinux1.ap.freescale.net> Message-ID: <20150715122955.GB30570@shlinux1.ap.freescale.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jul 15, 2015 at 08:25:24PM +0800, Dong Aisheng wrote: > Hi Mike, > > On Wed, May 27, 2015 at 09:09:19PM -0700, Michael Turquette wrote: > > Quoting Dong Aisheng (2015-05-14 06:28:59) > > > __clk_set_parent_after() actually used the second argument then we > > > could put this duplicate logic in there and call it with a different > > > order of arguments in the success vs. error paths in this function. > > > > > > Cc: Mike Turquette > > > Cc: Stephen Boyd > > > Suggested-by: Stephen Boyd > > > Signed-off-by: Dong Aisheng > > > > Patch looks good to me. > > > > Also just noticed that the second argument to __clk_set_parent_after is > > never used :-( > > > > Ping... > > I did not see this patch series in your tree for v4.2 rc. > Is this got missed? > Updated Mike's email address. Regards Dong Aisheng > Regards > Dong Aisheng > > > Regards, > > Mike > > > > > --- > > > drivers/clk/clk.c | 8 +------- > > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > > > index 659f2b0..0e813ea 100644 > > > --- a/drivers/clk/clk.c > > > +++ b/drivers/clk/clk.c > > > @@ -1159,14 +1159,8 @@ static int __clk_set_parent(struct clk_core *core, struct clk_core *parent, > > > flags = clk_enable_lock(); > > > clk_reparent(core, old_parent); > > > clk_enable_unlock(flags); > > > + __clk_set_parent_after(core, old_parent, parent); > > > > > > - if (core->prepare_count) { > > > - flags = clk_enable_lock(); > > > - clk_core_disable(core); > > > - clk_core_disable(parent); > > > - clk_enable_unlock(flags); > > > - clk_core_unprepare(parent); > > > - } > > > return ret; > > > } > > > > > > -- > > > 1.9.1 > > >