From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59157)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZFNSA-00046O-50
	for qemu-devel@nongnu.org; Wed, 15 Jul 2015 10:14:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZFNS9-000350-AS
	for qemu-devel@nongnu.org; Wed, 15 Jul 2015 10:14:30 -0400
Date: Wed, 15 Jul 2015 17:14:20 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150715141419.GA15232@redhat.com>
References: <1436938201-16766-1-git-send-email-jasowang@redhat.com>
	<1436938201-16766-4-git-send-email-jasowang@redhat.com>
	<20150715151941-mutt-send-email-mst@redhat.com>
	<55A6565C.2060509@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55A6565C.2060509@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi
	passthrough by default
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, qemu-block@nongnu.org, Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com, cornelia.huck@de.ibm.com

On Wed, Jul 15, 2015 at 02:47:24PM +0200, Paolo Bonzini wrote:
> 
> 
> On 15/07/2015 14:21, Michael S. Tsirkin wrote:
> >> > Disable scsi passthrough by default since it was incompatible with
> >> > virtio 1.0. For legacy machine types, keep this on by default.
> >> > 
> >> > Cc: Stefan Hajnoczi <stefanha@redhat.com>
> >> > Cc: Kevin Wolf <kwolf@redhat.com>
> >> > Cc: qemu-block@nongnu.org
> >> > Signed-off-by: Jason Wang <jasowang@redhat.com>
> > Seems risky for 2.4.  modern is off by default for now. Can't we limit
> > the change to when modern is enabled?
> 
> That would have the effect of disabling a feature when you turn on modern.

What's wrong with that?

> > I suggested changing this from bool to on/off/auto, and
> > make auto mean !modern.
> 
> No, please do it like Jason did.  The SCSI feature effectively had to be
> enabled explicitly already, the requests were marked as unsupported.
> 
> Paolo

I didn't know. How is it enabled?

-- 
MST