From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH v4] drm/i915: Add soft-pinning API for execbuffer Date: Wed, 15 Jul 2015 16:06:15 +0100 Message-ID: <20150715150615.GJ9115@nuc-i3427.alporthouse.com> References: <1425635047-25214-1-git-send-email-chris@chris-wilson.co.uk> <1435673593-28127-1-git-send-email-thomas.daniel@intel.com> <55A6745B.2000103@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id 6DE876E5C9 for ; Wed, 15 Jul 2015 08:06:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: <55A6745B.2000103@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Goel, Akash" Cc: "intel-gfx@lists.freedesktop.org" , "Belgaumkar, Vinay" List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdWwgMTUsIDIwMTUgYXQgMDg6MjU6MjNQTSArMDUzMCwgR29lbCwgQWthc2ggd3Jv dGU6Cj4gPj4raW50Cj4gPj4raTkxNV9nZW1fZXZpY3RfZm9yX3ZtYShzdHJ1Y3QgaTkxNV92bWEg KnRhcmdldCkKPiA+Pit7Cj4gPj4rCXN0cnVjdCBkcm1fbW1fbm9kZSAqbm9kZSwgKm5leHQ7Cj4g Pj4rCj4gPj4rCWxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZShub2RlLCBuZXh0LAo+ID4+KwkJCSZ0 YXJnZXQtPnZtLT5tbS5oZWFkX25vZGUubm9kZV9saXN0LAo+ID4+KwkJCW5vZGVfbGlzdCkgewo+ ID4+KwkJc3RydWN0IGk5MTVfdm1hICp2bWE7Cj4gPj4rCQlpbnQgcmV0Owo+ID4+Kwo+ID4+KwkJ aWYgKG5vZGUtPnN0YXJ0ICsgbm9kZS0+c2l6ZSA8PSB0YXJnZXQtPm5vZGUuc3RhcnQpCj4gPj4r CQkJY29udGludWU7Cj4gPj4rCQlpZiAobm9kZS0+c3RhcnQgPj0gdGFyZ2V0LT5ub2RlLnN0YXJ0 ICsgdGFyZ2V0LT5ub2RlLnNpemUpCj4gPj4rCQkJYnJlYWs7Cj4gPj4rCj4gPj4rCQl2bWEgPSBj b250YWluZXJfb2Yobm9kZSwgdHlwZW9mKCp2bWEpLCBub2RlKTsKPiA+PisKPiA+PisJCWlmICh2 bWEtPnBpbl9jb3VudCkgewo+ID4+KwkJCS8qIFdlIG1heSBuZWVkIHRvIGV2aWN0IGEgYnVmZmVy IGluIHRoZSBzYW1lIGJhdGNoICovCj4gPj4rCQkJaWYgKCF2bWEtPmV4ZWNfZW50cnkpCj4gPj4r CQkJCXJldHVybiAtRUJVU1k7Cj4gPj4rCj4gPj4rCQkJaWYgKHZtYS0+ZXhlY19lbnRyeS0+Zmxh Z3MgJiBFWEVDX09CSkVDVF9QSU5ORUQpCj4gPj4rCQkJCS8qIE92ZXJsYXBwaW5nIGZpeGVkIG9i amVjdHMgaW4gdGhlIHNhbWUgYmF0Y2gKPiA+PiovCj4gPj4rCQkJCXJldHVybiAtRUlOVkFMOwo+ ID4+Kwo+ID4+KwkJCXJldHVybiAtRU5PU1BDOwo+IAo+IENhbiB3ZSBhY3R1YWxseSBoaXQgdGhp cyBjb25kaXRpb24sIGNvbnNpZGVyaW5nIHRoZSBzb2Z0IHBpbm5lZAo+IG9iamVjdHMgYXJlIG5v dyBvbiB0aGUgZnJvbnQgc2lkZSBvZiAnZWItPnZtYXMnIGxpc3QgPwo+IElmIHdlIGRvIGVuY291 bnRlciBzdWNoIGEgY2FzZSwgaXQgcHJvYmFibHkgbWVhbnMgdGhhdCB0aGUKPiBvdmVybGFwcGlu ZyBvYmplY3QgaXMgYWxyZWFkeSBwaW5uZWQgZnJvbSBzb21lIG90aGVyIHBhdGguCgpOb3RlIHRo YXQgc29mdHBpbm5lZCBvYmplY3RzIGFyZSBvbmx5IGZpcnN0IG9uIHRoZSBzZWNvbmQgcGFzcyB0 aHJvdWdoCnRoZSByZXNlcnZhdGlvbi4KIAo+IElzIHRoZXJlIGEgc2NvcGUgb2YgYW4gYWRkaXRp b25hbCBjaGVjayBoZXJlID8KPiBpLmUuIGlmICh2bWEtPnBpbl9jb3VudCkgaXMgPiAxLCB0aGlz IGluZGljYXRlcyB0aGF0IHRoZSBvYmplY3QgaXMKPiBub3Qgb25seSBwaW5uZWQgZHVlIHRvIGV4 ZWNidWZmZXIsIGhlbmNlIGNhbm5vdCBiZSBldmljdGVkLCBzbwo+IC1FQlVTWSBjYW4gYmUgc3Ry YWlnaHQgYXdheSByZXR1cm5lZCB0byBVc2VyLgoKQ29uc2lkZXIgdGhpcyBpbnN0ZWFkOgoKaW50 Cmk5MTVfZ2VtX2V2aWN0X2Zvcl92bWEoc3RydWN0IGk5MTVfdm1hICp0YXJnZXQsIHVuc2lnbmVk IGZsYWdzKQp7CiAgICAgICAgc3RydWN0IGxpc3RfaGVhZCBldmljdGlvbl9saXN0OwogICAgICAg IHN0cnVjdCBpbnRlcnZhbF90cmVlX25vZGUgKml0OwogICAgICAgIHU2NCBlbmQgPSB0YXJnZXQt Pm5vZGUuc3RhcnQgKyB0YXJnZXQtPm5vZGUuc2l6ZTsKICAgICAgICBzdHJ1Y3QgZHJtX21tX25v ZGUgKm5vZGU7CiAgICAgICAgc3RydWN0IGk5MTVfdm1hICp2bWEsICpuZXh0OwogICAgICAgIGlu dCByZXQ7CgogICAgICAgIGl0ID0gaW50ZXJ2YWxfdHJlZV9pdGVyX2ZpcnN0KCZ0YXJnZXQtPnZt LT5tbS5pbnRlcnZhbF90cmVlLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHRhcmdldC0+bm9kZS5zdGFydCwgZW5kIC0xKTsKICAgICAgICBpZiAoaXQgPT0gTlVMTCkKICAg ICAgICAgICAgICAgIHJldHVybiAwOwoKICAgICAgICBJTklUX0xJU1RfSEVBRCgmZXZpY3Rpb25f bGlzdCk7CiAgICAgICAgbm9kZSA9IGNvbnRhaW5lcl9vZihpdCwgdHlwZW9mKCpub2RlKSwgaXQp OwogICAgICAgIGxpc3RfZm9yX2VhY2hfZW50cnlfZnJvbShub2RlLAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAmdGFyZ2V0LT52bS0+bW0uaGVhZF9ub2RlLm5vZGVfbGlzdCwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbm9kZV9saXN0KSB7CiAgICAgICAgICAgICAg ICBpZiAobm9kZS0+c3RhcnQgPj0gZW5kKQogICAgICAgICAgICAgICAgICAgICAgICBicmVhazsK CiAgICAgICAgICAgICAgICB2bWEgPSBjb250YWluZXJfb2Yobm9kZSwgdHlwZW9mKCp2bWEpLCBu b2RlKTsKICAgICAgICAgICAgICAgIGlmIChmbGFncyAmIFBJTl9OT05CTE9DSyAmJgogICAgICAg ICAgICAgICAgICAgICh2bWEtPnBpbl9jb3VudCB8fCB2bWEtPmFjdGl2ZS5yZXF1ZXN0KSkgewog ICAgICAgICAgICAgICAgICAgICAgICByZXQgPSAtRU5PU1BDOwogICAgICAgICAgICAgICAgICAg ICAgICBicmVhazsKICAgICAgICAgICAgICAgIH0KCiAgICAgICAgICAgICAgICBpZiAodm1hLT5l eGVjX2VudHJ5ICYmCiAgICAgICAgICAgICAgICAgICAgdm1hLT5leGVjX2VudHJ5LT5mbGFncyAm IEVYRUNfT0JKRUNUX1BJTk5FRCkgewogICAgICAgICAgICAgICAgICAgICAgICAvKiBPdmVybGFw cGluZyBwaW5uZWQgb2JqZWN0cyBpbiB0aGUgc2FtZSBiYXRjaCAqLwogICAgICAgICAgICAgICAg ICAgICAgICByZXQgPSAtRUlOVkFMOwogICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKICAg ICAgICAgICAgICAgIH0KCiAgICAgICAgICAgICAgICBpZiAodm1hLT5waW5fY291bnQpIHsKICAg ICAgICAgICAgICAgICAgICAgICAgLyogV2UgbWF5IG5lZWQgdG8gZXZpY3QgYW4gYnVmZmVyIGlu IHRoZSBzYW1lIGJhdGNoICovCiAgICAgICAgICAgICAgICAgICAgICAgIHJldCA9IHZtYS0+ZXhl Y19lbnRyeSA/IC1FTk9TUEMgOiAtRUJVU1k7CiAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFr OwogICAgICAgICAgICAgICAgfQoKICAgICAgICAgICAgICAgIGxpc3RfYWRkKCZ2bWEtPmV4ZWNf bGlzdCwgJmV2aWN0aW9uX2xpc3QpOwogICAgICAgICAgICAgICAgZHJtX2dlbV9vYmplY3RfcmVm ZXJlbmNlKCZ2bWEtPm9iai0+YmFzZSk7CiAgICAgICAgfQoKICAgICAgICByZXQgPSAwOwogICAg ICAgIGxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZSh2bWEsIG5leHQsICZldmljdGlvbl9saXN0LCBl eGVjX2xpc3QpIHsKICAgICAgICAgICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpv YmogPSB2bWEtPm9iajsKICAgICAgICAgICAgICAgIGlmIChyZXQgPT0gMCkKICAgICAgICAgICAg ICAgICAgICAgICAgcmV0ID0gaTkxNV92bWFfdW5iaW5kKHZtYSk7CiAgICAgICAgICAgICAgICBk cm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZSgmb2JqLT5iYXNlKTsKICAgICAgICB9CgogICAgICAg IHJldHVybiByZXQ7Cn0KLUNocmlzCgotLSAKQ2hyaXMgV2lsc29uLCBJbnRlbCBPcGVuIFNvdXJj ZSBUZWNobm9sb2d5IENlbnRyZQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=