From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@infradead.org (Christoph Hellwig) Date: Thu, 16 Jul 2015 02:26:46 -0700 Subject: [PATCH 3/3] block: Refuse adding appending a gapped integrity page to a bio In-Reply-To: <55A67C17.4080706@kernel.dk> References: <1436966356-8979-1-git-send-email-sagig@mellanox.com> <1436966356-8979-4-git-send-email-sagig@mellanox.com> <55A67C17.4080706@kernel.dk> Message-ID: <20150716092646.GA17712@infradead.org> On Wed, Jul 15, 2015@09:28:23AM -0600, Jens Axboe wrote: > This chunk of code largely ends up being duplicated in several places with > your patches, might be a good idea to pull that into a helper function. Then > you can add the comment in one place as well :-) Basically all the bio_vec-related code in block-integrity is copy & paste of the I/O path. In the long run we'll need to refactor it by adding bio_vec iteration helpers that can pick different anchors from the bio. But for now I think I'd rather have this quick fix.