From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753134AbbGSKsd (ORCPT <rfc822;w@1wt.eu>);
	Sun, 19 Jul 2015 06:48:33 -0400
Received: from mail-pd0-f175.google.com ([209.85.192.175]:32999 "EHLO
	mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752794AbbGSKsb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 19 Jul 2015 06:48:31 -0400
Date: Sun, 19 Jul 2015 19:46:12 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, linux-kernel@vger.kernel.org,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
        Jiri Olsa <jolsa@kernel.org>, Borislav Petkov <bp@suse.de>,
        Hemant Kumar <hemant@linux.vnet.ibm.com>
Subject: Re: [RFC PATCH perf/core v2 15/16] perf buildid-cache: Scan and
 import user SDT events to probe cache
Message-ID: <20150719104612.GB25163@danjae.kornet>
References: <20150715091352.8915.87480.stgit@localhost.localdomain>
 <20150715091537.8915.63535.stgit@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150715091537.8915.63535.stgit@localhost.localdomain>
User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 15, 2015 at 06:15:37PM +0900, Masami Hiramatsu wrote:
> perf buildid-cache --add <binary> scans given binary and add
> the SDT events to probe cache. It is possible to use the cached
> SDT events as other cached events (perf probe <provider>:<event>=<event>).

That means lookup the cached SDT events only using event name, right?
What if same event names are used by more than one providers?


> 
> e.g.
>   ----
>   # perf buildid-cache --add /lib/libc-2.17.so
>   # perf probe --cache --list | head -n 5
>   /usr/lib/libc-2.17.so (a6fb821bdf53660eb2c29f778757aef294d3d392):
>   libc:setjmp=setjmp
>   libc:longjmp=longjmp
>   libc:longjmp_target=longjmp_target
>   libc:memory_heap_new=memory_heap_new

I expected something like this instead..

    libc:memory_heap_new=new_heap+183


Thanks,
Namhyung


>   # perf probe -x /usr/lib/libc-2.17.so \
>     -a libc:memory_heap_new=memory_heap_new
>   Added new event:
>     libc:memory_heap_new (on memory_heap_new
>    in /usr/lib/libc-2.17.so)
> 
>   You can now use it in all perf tools, such as:
> 
>           perf record -e libc:memory_heap_new -aR sleep 1
> 
>   # perf probe -l
>     libc:memory_heap_new (on new_heap+183 in /usr/lib/libc-2.17.so)
>   ----
> 
> Note that SDT event entries in probe-cache file is somewhat different
> from normal cached events. Normal one starts with "#", but SDTs are
> starting with "%".
> 
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>