From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753512AbbGSK4Y (ORCPT <rfc822;w@1wt.eu>);
	Sun, 19 Jul 2015 06:56:24 -0400
Received: from mail-pa0-f47.google.com ([209.85.220.47]:35753 "EHLO
	mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753229AbbGSK4X (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 19 Jul 2015 06:56:23 -0400
Date: Sun, 19 Jul 2015 19:53:59 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, linux-kernel@vger.kernel.org,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
        Jiri Olsa <jolsa@kernel.org>, Borislav Petkov <bp@suse.de>,
        Hemant Kumar <hemant@linux.vnet.ibm.com>
Subject: Re: [RFC PATCH perf/core v2 16/16] perf probe: Accept %sdt and
 %cached event name
Message-ID: <20150719105359.GC25163@danjae.kornet>
References: <20150715091352.8915.87480.stgit@localhost.localdomain>
 <20150715091544.8915.18843.stgit@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150715091544.8915.18843.stgit@localhost.localdomain>
User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 15, 2015 at 06:15:44PM +0900, Masami Hiramatsu wrote:
> To improbe usability, support %[PROVIDER:]SDTEVENT format to
> add new probes on SDT and cached events.

Ah, you meant we can skip the provider if the event name is unique..


> 
> e.g.
>   ----
>   # perf probe -x /lib/libc-2.17.so  %lll_lock_wait_private

Maybe we can also skip the target path (-x) too in this case.

Thanks,
Namhyung


>   Added new event:
>     libc:lll_lock_wait_private (on %lll_lock_wait_private in
>   /usr/lib/libc-2.17.so)
> 
>   You can now use it in all perf tools, such as:
> 
>           perf record -e libc:lll_lock_wait_private -aR sleep 1
> 
>   # perf probe -l | more
>     libc:lll_lock_wait_private (on __lll_lock_wait_private+21
>    in /usr/lib/libc-2.17.so)
>   ----
> 
> Note that this is not only for SDT events, but also normal
> events with event-name.
> 
> e.g. define "myevent" on cache (-n doesn't add the real probe)
>   ----
>   # perf probe -x ./perf --cache -n --add 'myevent=dso__load $params'
>   ----
>   Reuse the "myevent" from cache as below.
>   ----
>   # perf probe -x ./perf %myevent
>   ----
> 
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>