All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Borislav Petkov <bp@suse.de>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	akpm@linux-foundation.org, jkosina@suse.cz, vgoyal@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Do not reserve crashkernel high memory if crashkernel low memory reserving failed
Date: Sun, 19 Jul 2015 22:23:25 +0800	[thread overview]
Message-ID: <20150719142325.GA9968@dhcp-17-102.nay.redhat.com> (raw)
In-Reply-To: <20150719134003.GC27557@nazgul.tnic>

On 07/19/15 at 03:40pm, Borislav Petkov wrote:
> ...
> 
> > @@ -552,7 +552,7 @@ static void __init reserve_crashkernel_low(void)
> >  		if (!auto_set)
> >  			pr_info("crashkernel low reservation failed - No suitable area found.\n");
> >  
> > -		return;
> > +		return EINVAL;
> 
> Error values are negative:
> 
> 		return -EINVAL;

Yes, will repost. Thanks a lot.

Thanks
Baoquan

  reply	other threads:[~2015-07-19 14:23 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-19 11:07 [PATCH] Do not reserve crashkernel high memory if crashkernel low memory reserving failed Baoquan He
2015-07-19 13:40 ` Borislav Petkov
2015-07-19 14:23   ` Baoquan He [this message]
2015-07-19 14:53 ` [PATCH v2] " Baoquan He
2015-07-21  7:31   ` Dave Young
2015-07-21  7:38     ` Ingo Molnar
2015-07-21  8:19       ` Dave Young
2015-07-22  1:13       ` Baoquan He
2015-07-27 14:45       ` Joerg Roedel
2015-07-21  7:50     ` Baoquan He
2015-07-21  8:23       ` Dave Young
2015-07-21  8:58         ` Baoquan He
2015-07-21 19:22           ` Yinghai Lu
2015-07-22  0:59             ` Baoquan He
2015-07-22 23:47               ` Yinghai Lu
2015-07-28  0:52                 ` Baoquan He
2015-07-28  2:45                   ` Yinghai Lu
2015-07-28  9:19                     ` Baoquan He
2015-07-22  4:47             ` Minfei Huang
2015-07-22 23:44               ` Yinghai Lu
2015-07-22 10:11             ` Joerg Roedel
2015-07-22 23:41               ` Yinghai Lu
2015-07-27 14:03                 ` Joerg Roedel
2015-07-27 18:31     ` Yinghai Lu
2015-07-27 23:32       ` Baoquan He
2015-07-27 14:41   ` Joerg Roedel
2015-09-24  3:24 [PATCH] " Baoquan He
2015-10-14  6:16 ` Baoquan He
2015-10-14  8:43 ` Joerg Roedel
2015-10-14 10:43   ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150719142325.GA9968@dhcp-17-102.nay.redhat.com \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.