From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932483AbbGSTRZ (ORCPT <rfc822;w@1wt.eu>);
	Sun, 19 Jul 2015 15:17:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48885 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755024AbbGSTRV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 19 Jul 2015 15:17:21 -0400
Date: Sun, 19 Jul 2015 21:17:17 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Sergei Trofimovich <siarheit@google.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: fix makefile generation under dash
Message-ID: <20150719191717.GB27893@krava.brq.redhat.com>
References: <1437298205-29305-1-git-send-email-siarheit@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1437298205-29305-1-git-send-email-siarheit@google.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jul 19, 2015 at 10:30:05AM +0100, Sergei Trofimovich wrote:
> Under dash 'echo -n' yields '-n' to stdout.
> Use printf "" instead.

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> 
> CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
> CC: Ingo Molnar <mingo@redhat.com>
> CC: Arnaldo Carvalho de Melo <acme@kernel.org>
> CC: Jiri Olsa <jolsa@redhat.com>
> CC: Namhyung Kim <namhyung@kernel.org>
> CC: Adrian Hunter <adrian.hunter@intel.com>
> CC: linux-kernel@vger.kernel.org
> Signed-off-by: Sergei Trofimovich <siarheit@google.com>
> ---
>  tools/perf/config/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 094ddae..bc0b59e 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -11,7 +11,7 @@ ifneq ($(obj-perf),)
>  obj-perf := $(abspath $(obj-perf))/
>  endif
>  
> -$(shell echo -n > $(OUTPUT).config-detected)
> +$(shell printf "" > $(OUTPUT).config-detected)
>  detected     = $(shell echo "$(1)=y"       >> $(OUTPUT).config-detected)
>  detected_var = $(shell echo "$(1)=$($(1))" >> $(OUTPUT).config-detected)
>  
> -- 
> 2.4.6
>