From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: roopa@cumulusnetworks.com, rshearma@brocade.com,
ebiederm@xmission.com, hannes@stressinduktion.org,
pshelar@nicira.com, jesse@nicira.com, davem@davemloft.net,
daniel@iogearbox.net, tom@herbertland.com, edumazet@google.com,
jiri@resnulli.us, stephen@networkplumber.org, jpettit@nicira.com,
kaber@trash.net, simon.horman@netronome.com,
joestringer@nicira.com, ja@ssi.bg, ast@plumgrid.com,
weichunc@plumgrid.com, netdev@vger.kernel.org,
dev@openvswitch.org
Subject: Re: [PATCH net-next 14/22] vxlan: Flow based tunneling
Date: Mon, 20 Jul 2015 14:15:22 -0300 [thread overview]
Message-ID: <20150720171522.GA14393@localhost.localdomain> (raw)
In-Reply-To: <f5cf9490a8f114416ec24e9e1de190d6640f25f0.1437137396.git.tgraf@suug.ch>
On Fri, Jul 17, 2015 at 02:55:33PM +0200, Thomas Graf wrote:
[ snip ]
> @@ -2373,6 +2470,12 @@ static void vxlan_setup(struct net_device *dev)
> netif_keep_dst(dev); ---> (a)
> dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
>
> + /* If in flow based mode, keep the dst including encapsulation
> + * instructions for vxlan_xmit().
> + */
> + if (vxlan->flags & VXLAN_F_FLOW_BASED)
> + netif_keep_dst(dev); ---> (b)
> +
> INIT_LIST_HEAD(&vxlan->next);
> spin_lock_init(&vxlan->hash_lock);
>
Sounds like after 0287587884b1 ("net: better IFF_XMIT_DST_RELEASE
support"), which introduced (a) above, (b) is not needed?
Marcelo
next prev parent reply other threads:[~2015-07-20 17:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 12:55 [PATCH net-next 00/22] Lightweight & flow based encapsulation Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 01/22] rtnetlink: introduce new RTA_ENCAP_TYPE and RTA_ENCAP attributes Thomas Graf
[not found] ` <cover.1437137396.git.tgraf-G/eBtMaohhA@public.gmane.org>
2015-07-17 12:55 ` [PATCH net-next 02/22] lwtunnel: infrastructure for handling light weight tunnels like mpls Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 03/22] ipv4: support for fib route lwtunnel encap attributes Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 04/22] ipv6: " Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 05/22] lwtunnel: support dst output redirect function Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 07/22] ipv6: rt6_info output redirect to tunnel output Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 09/22] mpls: ip tunnel support Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 11/22] icmp: Don't leak original dst into ip_route_input() Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 06/22] ipv4: redirect dst output to lwtunnel output Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 08/22] mpls: export mpls functions for use by mpls iptunnels Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 10/22] ip_tunnel: Make ovs_tunnel_info and ovs_key_ipv4_tunnel generic Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 12/22] dst: Metadata destinations Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 13/22] arp: Inherit metadata dst when creating ARP requests Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 14/22] vxlan: Flow based tunneling Thomas Graf
2015-07-17 18:41 ` Alexei Starovoitov
2015-07-20 11:49 ` Thomas Graf
2015-07-20 17:15 ` Marcelo Ricardo Leitner [this message]
2015-07-20 17:41 ` Marcelo Ricardo Leitner
2015-07-17 12:55 ` [PATCH net-next 15/22] route: Extend flow representation with tunnel key Thomas Graf
[not found] ` <d8d4304d6c32149bdf34466925b520f82a024ec2.1437137396.git.tgraf-G/eBtMaohhA@public.gmane.org>
2015-07-17 20:25 ` Julian Anastasov
2015-07-20 12:27 ` Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 16/22] route: Per route IP tunnel metadata via lightweight tunnel Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 17/22] fib: Add fib rule match on tunnel id Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 18/22] vxlan: Factor out device configuration Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 19/22] openvswitch: Make tunnel set action attach a metadata dst Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 20/22] openvswitch: Move dev pointer into vport itself Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 21/22] openvswitch: Abstract vport name through ovs_vport_name() Thomas Graf
2015-07-17 12:55 ` [PATCH net-next 22/22] openvswitch: Use regular VXLAN net_device device Thomas Graf
2015-07-21 8:43 [PATCH net-next 00/22 v2] Lightweight & flow based encapsulation Thomas Graf
2015-07-21 8:43 ` [PATCH net-next 14/22] vxlan: Flow based tunneling Thomas Graf
2015-07-21 17:30 ` Alexei Starovoitov
2015-07-21 17:53 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720171522.GA14393@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=ja@ssi.bg \
--cc=jesse@nicira.com \
--cc=jiri@resnulli.us \
--cc=joestringer@nicira.com \
--cc=jpettit@nicira.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=roopa@cumulusnetworks.com \
--cc=rshearma@brocade.com \
--cc=simon.horman@netronome.com \
--cc=stephen@networkplumber.org \
--cc=tgraf@suug.ch \
--cc=tom@herbertland.com \
--cc=weichunc@plumgrid.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.