All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: borneo.antonio@gmail.com
Cc: paul.gortmaker@windriver.com, netdev@vger.kernel.org,
	linux-next@vger.kernel.org, alchark@gmail.com
Subject: Re: [PATCH] net: via/Kconfig: GENERIC_PCI_IOMAP required if PCI not selected
Date: Wed, 22 Jul 2015 11:08:36 -0700 (PDT)	[thread overview]
Message-ID: <20150722.110836.422018977846427052.davem@davemloft.net> (raw)
In-Reply-To: <1437582854-3320-1-git-send-email-borneo.antonio@gmail.com>

From: Antonio Borneo <borneo.antonio@gmail.com>
Date: Thu, 23 Jul 2015 00:34:14 +0800

> -	depends on (PCI || OF_IRQ)
> +	depends on (PCI || (OF_IRQ && GENERIC_PCI_IOMAP))

Having GENERIC_PCI_IOMAP withut PCI makes absolutely no sense to me.

I can't see why a platform would provide GENERIC_PCI_IOMAP when it
does not have PCI enabled.

You need to explain this.

When PCI is not enabled, you should not be using any interface
pci_*() whatsoever.  Especially such a core interface as pci_iomap().

ALTERNATIVELY, NOP versions of pci_iomap() and friends should be
provided when PCI is disabled, which just return errors and
non-success statuses.

  reply	other threads:[~2015-07-22 18:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22 16:34 [PATCH] net: via/Kconfig: GENERIC_PCI_IOMAP required if PCI not selected Antonio Borneo
2015-07-22 18:08 ` David Miller [this message]
2015-07-23  1:35   ` Antonio Borneo
2015-07-23 15:33     ` Alexey Charkov
2015-07-26 23:36     ` David Miller
2015-09-24 10:16 Sudip Mukherjee
2015-09-25 18:03 ` Sergei Shtylyov
2015-09-25 19:37   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150722.110836.422018977846427052.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alchark@gmail.com \
    --cc=borneo.antonio@gmail.com \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.