From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 0BBC31C1093 for ; Fri, 24 Jul 2015 20:36:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 0574326770 for ; Fri, 24 Jul 2015 20:36:59 +0000 (UTC) Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LRQY5h3mS1Z1 for ; Fri, 24 Jul 2015 20:36:58 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by silver.osuosl.org (Postfix) with ESMTPS id 45529264FE for ; Fri, 24 Jul 2015 20:36:58 +0000 (UTC) Date: Fri, 24 Jul 2015 13:36:57 -0700 From: Greg KH Subject: Re: [PATCH 2/7] staging: unisys: add simple error-check into visornic receive path Message-ID: <20150724203657.GB15778@kroah.com> References: <1437753625-28701-1-git-send-email-benjamin.romer@unisys.com> <1437753625-28701-3-git-send-email-benjamin.romer@unisys.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1437753625-28701-3-git-send-email-benjamin.romer@unisys.com> List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Benjamin Romer Cc: Jes.Sorensen@redhat.com, sparmaintainer@unisys.com, driverdev-devel@linuxdriverproject.org, Tim Sell On Fri, Jul 24, 2015 at 12:00:20PM -0400, Benjamin Romer wrote: > From: Tim Sell > > Add an error check here for use with dynamic debugging. > > Signed-off-by: Benjamin Romer > Signed-off-by: Tim Sell > --- > drivers/staging/unisys/visornic/visornic_main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c > index aeecb14..6ce3fc2 100644 > --- a/drivers/staging/unisys/visornic/visornic_main.c > +++ b/drivers/staging/unisys/visornic/visornic_main.c > @@ -1253,13 +1253,13 @@ visornic_rx(struct uiscmdrsp *cmdrsp) > curr->data_len = 0; > off += currsize; > } > -#ifdef DEBUG > /* assert skb->len == off */ > if (skb->len != off) { > dev_err(&devdata->netdev->dev, > - "%s something wrong; skb->len:%d != off:%d\n", > - netdev->name, skb->len, off); > + "something wrong; skb->len:%d != off:%d\n", > + skb->len, off); The changelog comment doesn't match what you are doing here. Also, shouldn't this be netdev_err() instead? thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel