From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: [PATCH] code cleanups for crypto/blkcipher.c Date: Sat, 25 Jul 2015 09:56:11 +0800 Message-ID: <20150725015611.GB29321@gondor.apana.org.au> References: <1437746672.19489.2.camel@My-Computer> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org To: Ahmed Mohamed Abd EL Mawgood Return-path: Received: from helcar.hengli.com.au ([209.40.204.226]:44452 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752928AbbGYB4Q (ORCPT ); Fri, 24 Jul 2015 21:56:16 -0400 Content-Disposition: inline In-Reply-To: <1437746672.19489.2.camel@My-Computer> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Fri, Jul 24, 2015 at 04:04:32PM +0200, Ahmed Mohamed Abd EL Mawgood wrote: > > @@ -68,6 +68,7 @@ static inline void blkcipher_unmap_dst(struct blkcipher_walk *walk) > static inline u8 *blkcipher_get_spot(u8 *start, unsigned int len) > { > u8 *end_page = (u8 *)(((unsigned long)(start + len - 1)) & PAGE_MASK); > + > return max(start, end_page); > } Nack. This makes the code less readable. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt