From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <driverdev-devel-bounces@linuxdriverproject.org>
Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])
 by ash.osuosl.org (Postfix) with ESMTP id 8A5691BFC06
 for <driverdev-devel@linuxdriverproject.org>;
 Mon, 27 Jul 2015 08:17:44 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
 by silver.osuosl.org (Postfix) with ESMTP id 85C1531E45
 for <driverdev-devel@linuxdriverproject.org>;
 Mon, 27 Jul 2015 08:17:44 +0000 (UTC)
Received: from silver.osuosl.org ([127.0.0.1])
 by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id jljyFbFdSbax
 for <driverdev-devel@linuxdriverproject.org>;
 Mon, 27 Jul 2015 08:17:44 +0000 (UTC)
Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69])
 by silver.osuosl.org (Postfix) with ESMTPS id DE6B632111
 for <driverdev-devel@linuxdriverproject.org>;
 Mon, 27 Jul 2015 08:17:43 +0000 (UTC)
Date: Mon, 27 Jul 2015 11:17:44 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 6/7] staging: unisys: visornic - consolidate+simplify
 xmit watermark checks
Message-ID: <20150727081744.GC5371@mwanda>
References: <1437753625-28701-1-git-send-email-benjamin.romer@unisys.com>
 <1437753625-28701-7-git-send-email-benjamin.romer@unisys.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1437753625-28701-7-git-send-email-benjamin.romer@unisys.com>
List-Id: Linux Driver Project Developer List
 <driverdev-devel.linuxdriverproject.org>
List-Unsubscribe: <http://driverdev.linuxdriverproject.org/mailman/options/driverdev-devel>,
 <mailto:driverdev-devel-request@linuxdriverproject.org?subject=unsubscribe>
List-Archive: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/>
List-Post: <mailto:driverdev-devel@linuxdriverproject.org>
List-Help: <mailto:driverdev-devel-request@linuxdriverproject.org?subject=help>
List-Subscribe: <http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel>,
 <mailto:driverdev-devel-request@linuxdriverproject.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: driverdev-devel-bounces@linuxdriverproject.org
Sender: "devel" <driverdev-devel-bounces@linuxdriverproject.org>
To: Benjamin Romer <benjamin.romer@unisys.com>
Cc: gregkh@linuxfoundation.org, sparmaintainer@unisys.com, driverdev-devel@linuxdriverproject.org, Tim Sell <Timothy.Sell@unisys.com>, Jes.Sorensen@redhat.com

On Fri, Jul 24, 2015 at 12:00:24PM -0400, Benjamin Romer wrote:
> -		max(2, devdata->max_outstanding_net_xmits - 1);
> +		max(2UL, (devdata->max_outstanding_net_xmits - 1));

It's weird here to treat ->max_outstanding_net_xmits equals zero as a
ULONG_MAX but it looks deliberate...  Perhaps add a comment?

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel