All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Neil Brown <neilb@suse.de>, Liu Bo <bo.li.liu@oracle.com>,
	linux-raid@vger.kernel.org, dm-devel@redhat.com,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: add a bi_error field to struct bio
Date: Tue, 28 Jul 2015 13:12:49 +0200	[thread overview]
Message-ID: <20150728111249.GA19647@lst.de> (raw)
In-Reply-To: <55B2699D.6010400@kernel.dk>

On Fri, Jul 24, 2015 at 10:36:45AM -0600, Jens Axboe wrote:
> Right, I don't think we need to do that though. If you look at the flags 
> usage, it's all over the map. Some use test/set_bit, some set it just by 
> OR'ing the mask. There's no reason we can't make this work without relying 
> on set/test_bit, and then shrink it to an unsigned int.

Yes, the current mess doesn't look kosher.  The bvec pool bits don't
really make it better.

But do we really need the cmpxchg hack? Seems like most flags aren't
exposed to concurrency at all, althugh this would need a careful audit.

  reply	other threads:[~2015-07-28 11:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20 13:29 add a bi_error field to struct bio V3 Christoph Hellwig
2015-07-20 13:29 ` [PATCH] block: add a bi_error field to struct bio Christoph Hellwig
2015-07-21  8:19   ` [dm-devel] " Hannes Reinecke
2015-07-22  5:00   ` NeilBrown
2015-07-22 18:51   ` Jens Axboe
2015-07-22 21:59     ` Jens Axboe
2015-07-24 10:49       ` Christoph Hellwig
2015-07-24 16:36         ` Jens Axboe
2015-07-28 11:12           ` Christoph Hellwig [this message]
2015-07-28 14:33             ` Jens Axboe
2015-07-29  2:15   ` Liu Bo
  -- strict thread matches above, loose matches on Subject: below --
2015-06-11 15:54 add a bi_error field to struct bio V2 Christoph Hellwig
2015-06-11 15:54 ` [PATCH] block: add a bi_error field to struct bio Christoph Hellwig
2015-06-03 13:42 [RFC] add a bi_error field Christoph Hellwig
2015-06-03 13:42 ` [PATCH] block: add a bi_error field to struct bio Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150728111249.GA19647@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=bo.li.liu@oracle.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.