From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752668AbbG1Qht (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Jul 2015 12:37:49 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:42110 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751000AbbG1Qhs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Jul 2015 12:37:48 -0400
Date: Tue, 28 Jul 2015 18:37:42 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Vikas Shivappa <vikas.shivappa@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, vikas.shivappa@intel.com, x86@kernel.org,
        hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, tj@kernel.org,
        matt.fleming@intel.com, will.auld@intel.com,
        glenn.p.williamson@intel.com, kanaka.d.juvva@intel.com
Subject: Re: [PATCH 6/9] x86/intel_rdt: Add support for cache bit mask
 management
Message-ID: <20150728163742.GT25159@twins.programming.kicks-ass.net>
References: <1435789270-27010-1-git-send-email-vikas.shivappa@linux.intel.com>
 <1435789270-27010-7-git-send-email-vikas.shivappa@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1435789270-27010-7-git-send-email-vikas.shivappa@linux.intel.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 01, 2015 at 03:21:07PM -0700, Vikas Shivappa wrote:
> +static int cbm_validate(struct intel_rdt *ir, unsigned long cbmvalue)
> +{
> +	struct cgroup_subsys_state *css;
> +	struct intel_rdt *par, *c;
> +	unsigned long *cbm_tmp;
> +	int err = 0;
> +
> +	if (!cbm_is_contiguous(cbmvalue)) {
> +		pr_err("bitmask should have >= 1 bit and be contiguous\n");
> +		err = -EINVAL;
> +		goto out_err;
> +	}

> +static struct cftype rdt_files[] = {
> +	{
> +		.name		= "l3_cache_mask",
> +		.seq_show	= intel_cache_alloc_cbm_read,
> +		.write_u64	= intel_cache_alloc_cbm_write,
> +		.mode		= 0666,

So this file is world writable? How is the above pr_err() not a DoS ?

> +	},
> +	{ }	/* terminate */
> +};