From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chen Subject: Re: Bug: shared usb dt document is incorrect Date: Wed, 29 Jul 2015 08:27:03 +0800 Message-ID: <20150729002702.GA8703@shlinux2> References: <55B82716.1060008@sonymobile.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <55B82716.1060008-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tim Bird Cc: Rob Herring , antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, "linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Greg Kroah-Hartman , Bjorn Andersson List-Id: linux-arm-msm@vger.kernel.org On Tue, Jul 28, 2015 at 06:06:30PM -0700, Tim Bird wrote: > Antoine and Rob, > > I was just doing some testing with USB on a Qualcomm SoC. > > I followed the instructions in the binding document: > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > > which has a compatible for "qcom,ci-hdrc", and is, in general, > for chipidea-based USB controllers. > > It says in the document that the property usb-phy is deprecated, and to > use phys and phy-names instead. However, the Qualcomm > driver for this still uses usb-phy. That driver is in: > drivers/usb/chipidea/ci_hdrc_msm.c > > I'm guessing I should update the Qualcomm driver to use > phys and phy-names, but wanted to check with you-all to > verify that this is the preferred method of getting > phys by phandle now. It's either change the driver > or make an exception in the binding document, I believe. > > I presume I should be changing devm_usb_get_phy_by_phandle() > to of_phy_get(), but let me know if there's more to it than that. > > In case I change the driver, do I then update the binding doc > to remove the information about the deprecated property, or not? > > Please advise. In my opinion, you can just keep both driver and binding doc unchanging until the generic PHY supports all things the current USB PHY supports, eg, .notify_disconnect is used in your PHY driver, but it is not supported in generic PHY framework. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752065AbbG2BhD (ORCPT ); Tue, 28 Jul 2015 21:37:03 -0400 Received: from mail-by2on0148.outbound.protection.outlook.com ([207.46.100.148]:42432 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750945AbbG2BhB (ORCPT ); Tue, 28 Jul 2015 21:37:01 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; sonymobile.com; dkim=none (message not signed) header.d=none; Date: Wed, 29 Jul 2015 08:27:03 +0800 From: Peter Chen To: Tim Bird CC: Rob Herring , , "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , , Greg Kroah-Hartman , Bjorn Andersson Subject: Re: Bug: shared usb dt document is incorrect Message-ID: <20150729002702.GA8703@shlinux2> References: <55B82716.1060008@sonymobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <55B82716.1060008@sonymobile.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11OLC013;1:584i2fdvMeVM5U0osvfTzEgIL244DWO3J5SahjRf/+O6vCW8GKRdabz3x559NoJaZFqKPXuuJEM2FPKDHLQq/rvteaiA0pbVnS/ugdUtQtiINIwvOkU6ehDkFeLHiIFGiGK/ad7fsX3TybFfyjd4Y4nbuIa/esgfVBvKVD0AwMkAe52F0T6hlBdttdZOaOvyAgPEaXgiYfkYNwbVW4GWnLAVhFmS46ZNgZ8/5UmeM4aUwbp3rcSYsDbHiXsIQ0jQQ/3VqDwqGTDCGnpvqN1UOA== X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(339900001)(24454002)(51164003)(189002)(199003)(2950100001)(105606002)(189998001)(110136002)(92566002)(85426001)(83506001)(46102003)(4001350100001)(97756001)(87936001)(33716001)(62966003)(5001960100002)(106466001)(77096005)(5001920100001)(77156002)(23726002)(76176999)(19580395003)(54356999)(86362001)(6806004)(46406003)(47776003)(50466002)(50986999)(104016003)(33656002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR0301MB1271;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1271;2:/r792mtKTPr8t9elyTemNEf1kKu2eVFarjdx2K6R7HtDtz9WIAAf+yxS4PftarY/;3:wDUmIDeeBiqOeKLw4i4ypAHePPwWWRGlqdjjAHRBtkaFQW9fX9EXAT0RfRn7Kzr6V1F5r6zBEINyGs/UWy2+VQFw046v/daCVe29j2S2ORH0uJP2bYwtxJRV9XUhHk5ZXGR4hcwjxWWnRsp7MRuOkp9tOaDmglFJoPC6Sgtog9n4xdb3GF34ie9lsN2WprB2n6Wqd/9fqAaaOwUUNlwrwHcyLblXPZU4fJbvyXkSql0=;25:g/wnUWByrJHs58erPnhs0LVxJqwXkIRykCUGBVykgpicgk1ul3f6P4zuBxOIKf5uo58tfa7r/XQ8D+v+GeYyzmo1Gv3MAV507K2sjLMsIYPwV7VVLsarvI0dMreoQ6M7q788DvsflO07bNaeTVbVL5RsVPkY+oRxSEayRXZ9h8/kQPbUJDAi4Y429dwVIHCIXhaBqedq9Ulw4gcdPwWitz83S/W+Xyn5dKMeyj4Nc3scXvbkFc5fEnK5dx7k+oao2kc+dZA65uh48W1lXb5sdQ==;20:LQi0aN0ZLVUKFQ0qiJQnvBzPnldk07c6+7wgaDjI2UQwJ4HYxniLR+6yumseifsNJUq58lrSF79v065nfcsMn1jnLSyKQTmHAxY7yiTRYhReA9j/skU5/GyHA13lgODuw/q9zrOuL3ZG7nLnqDOQeUf3z/M1u3f3Lu7gS+VCYE7KC32froTLB+20jkmLXafrUig1a+riPo1CQ44dYlJLFB0wlWcbzPO5VqSL77++rS5yxuE1wTOsLRThfNH6lJgYRjnqnUJxM0lKAA/xvs0Sxwv0fF6qMlvV8w8PrTwqP9+PhsOkHrGoTnKhE7p2AxQu3ZX7WKUxFU6Il/xeDqWq2UU88R9hr4gMqErNR2JRifk= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB1271; BY1PR0301MB1271: X-MS-Exchange-Organization-RulesExecuted X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BY1PR0301MB1271;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB1271; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1271;4:BccJE7s8+DvgyKR/8aaM3wueotsLTKpsfB0XyQukC2fMMJYT6808WDMIh5L7ywoIMixCA/awGq71N/rJuDo8XNrsOrLUsUpxvmeeQg381Ehgrzg2IbVKZUpmNG8K5cMotyusxzmeZcga+8oEsb+p9gvV/8fwdbm5bElDQKgkmbHuU9Rku5TUu6awoW+imcUawQpIKUIWte8+i9UvLgHz0xTJuf78hu1g+Vz6gjIEr9OwjKNIFy5VZmQJrsiYBRlZBrcl6NEDr7c38365aasi8hs4xenBL4z/t9lZT7DDGFc= X-Forefront-PRVS: 0652EA5565 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY1PR0301MB1271;23:igi4I7gB3tlKhAVCkA2ecbHD9phWzXQeRLPc6/8?= =?us-ascii?Q?WJKSyo7o9GBwvikdWPB+fYFWDQN6HnGGLmk7SAdi8qPuxmkIHkj846tsaQ2s?= =?us-ascii?Q?Z283OpBL0D5Iq1vDDApJmlCg9Os/IZFQ4RAOSH0eO93qYGD4e8PL1QVH4Upt?= =?us-ascii?Q?AXaiAKTgtUf0+vaLn0JsU20OHRBQqORiuwjt7/UdJKhF7uPRPpqAGK4oGeZf?= =?us-ascii?Q?+qDuuvzDcVkzM88lnNAbApPM0ZsesJ9dk2RHP5GiNXJNLNQR82v8xnMfNH3g?= =?us-ascii?Q?7h6jv2YHDdW4kLTNUl7pMQzx5tZOeisojWIhleJnDXVbQW3E103AkDYcr7kx?= =?us-ascii?Q?XcCVM2M2eK8hjUO6WfIk+RupsvmDV3w+EeTgC67NU55a37HjI64Ezcwmdn9d?= =?us-ascii?Q?1QMLYwAvYTosLA45GPZzIYvxWSNK+JD2H05whk6q9VZXKXEQbb5BBzNvo/MH?= =?us-ascii?Q?QU12ne/G/hTal/aG0TLOYrzlycAQ/kTnTE1U/uJCKCuZ6tVPz8eJnlk5g4sp?= =?us-ascii?Q?W+ukPOApjKOszM1QJ/HXJfVzB8/ShYuiHxhED5HqitpGG9e+MUCe3bN6o19s?= =?us-ascii?Q?Unin33PMAZzjcP0ORLQ0zvckWd9LBxvNnlP49MIIq4YOCT44mgX6+cBm+e1Z?= =?us-ascii?Q?tLnNuyjBFOZ5NBV71BclgjQQqmSt7pvfn670cgfTBoI1bu/duKn8BoP40r8/?= =?us-ascii?Q?s3pi9fGBsEEVoZ8dxRsQrIK8rxaocFhSwGWMs2bFGYIkf8Hjl0L+izc6W0fS?= =?us-ascii?Q?pha0Hm3pfyEBk29E/0GZGaEurWdxJ03mqGZyBtXwjsxM8Hz0PB5qO1nrTILx?= =?us-ascii?Q?ZFzwRV/Lb0zLjmpIhkqDUtAgL7BJBsiUVqzGePJ4kFU2veimL+947jkXRYP8?= =?us-ascii?Q?+9bNrs0OHvkOoYdbfAmO3s8OLyGkJ63Lw7cV7mVxzlawVZQJ8VsMwM99Au6P?= =?us-ascii?Q?Ey4n3hVubApRu87Ojv4SPY0XEOCWaXyS0PdYxkP6cHGplj46dCwySgFWOKyP?= =?us-ascii?Q?ochU=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1271;5:fNWKGw5gwOTRuR+dr8bzNmoKF1BizuW6hbtoCKcImsfrjgiCGpD/+LxhkGdVdRKg4cg0y1VwI4eXG6tokbqpQnTrHZKhWJAPm3k55PTuip9p6uogjflVqAnXKC9zf+ZN91py96OpuldC0UR5fnt0bg==;24:QKUXPGmwHhUQRxYhIR23FhZV5RfnorVAdu2f7k3BOzA9tKxJ0L5LJMbOXSfR4ICgUI+4YUdYy08ZAre+tIgEpq8w6Hkz0CmbEBYRNLRQ1ws=;20:y8PxmjoYOBelXK1sMPZwRIfkGtCLh5ea3l80G7ZdBLrvBCXvVgwOsCWCChVFPt5otda6O3+fgoYIbuaZZ2Jy+Q== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2015 01:36:58.4980 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0301MB1271 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 28, 2015 at 06:06:30PM -0700, Tim Bird wrote: > Antoine and Rob, > > I was just doing some testing with USB on a Qualcomm SoC. > > I followed the instructions in the binding document: > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > > which has a compatible for "qcom,ci-hdrc", and is, in general, > for chipidea-based USB controllers. > > It says in the document that the property usb-phy is deprecated, and to > use phys and phy-names instead. However, the Qualcomm > driver for this still uses usb-phy. That driver is in: > drivers/usb/chipidea/ci_hdrc_msm.c > > I'm guessing I should update the Qualcomm driver to use > phys and phy-names, but wanted to check with you-all to > verify that this is the preferred method of getting > phys by phandle now. It's either change the driver > or make an exception in the binding document, I believe. > > I presume I should be changing devm_usb_get_phy_by_phandle() > to of_phy_get(), but let me know if there's more to it than that. > > In case I change the driver, do I then update the binding doc > to remove the information about the deprecated property, or not? > > Please advise. In my opinion, you can just keep both driver and binding doc unchanging until the generic PHY supports all things the current USB PHY supports, eg, .notify_disconnect is used in your PHY driver, but it is not supported in generic PHY framework. -- Best Regards, Peter Chen