Re: [PATCH 09/21] staging: wilc1000: #ifdef conditionals cover entire functions

From: Greg KH <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Tony Cho <tony.cho@atmel.com>,
	devel@driverdev.osuosl.org, rachel.kim@atmel.com,
	chris.park@atmel.com, austin.shin@atmel.com,
	linux-wireless@vger.kernel.org, johnny.kim@atmel.com,
	Nicolas.FERRE@atmel.com, robin.hwang@atmel.com,
	jude.lee@atmel.com, leo.kim@atmel.com
Subject: Re: [PATCH 09/21] staging: wilc1000: #ifdef conditionals cover entire functions
Date: Wed, 29 Jul 2015 14:29:07 -0700	[thread overview]
Message-ID: <20150729212907.GA16614@kroah.com> (raw)
In-Reply-To: <20150729211408.GL5180@mwanda>

On Thu, Jul 30, 2015 at 12:14:08AM +0300, Dan Carpenter wrote:
> On Wed, Jul 29, 2015 at 01:54:54PM -0700, Greg KH wrote:
> > On Tue, Jul 28, 2015 at 05:47:28PM +0900, Tony Cho wrote:
> > >  	/**
> > >  	 *      Disable power sequencer
> > >  	 **/
> > > -	if (!sdio_read_reg(WILC_MISC, &reg)) {
> > > +	if(!sdio_read_reg(WILC_MISC, &reg)) {
> > 
> 
> I noticed this style change during my review, but I didn't comment
> because I was feeling in a happy mood and because it got fixed again in
> patch 13.  Normally, of course we don't allow people to break and then
> fix things in later patches but this was a white space issue.

What this shows is that Tony isn't syncing up properly with other
changes that have happened in the upstream tree from his tree, which is
indicitive of not doing development properly, which is why I rejected
this.  And it shouldn't be done anyway, but that's a minor issue
overall.

thanks,

greg k-h