From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753827AbbHCQV7 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 3 Aug 2015 12:21:59 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:60119 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752054AbbHCQV6 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 3 Aug 2015 12:21:58 -0400
Date: Mon, 3 Aug 2015 09:21:58 -0700
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Drokin, Oleg" <oleg.drokin@intel.com>
Cc: Shraddha Barke <shraddha.6596@gmail.com>,
        "<devel@driverdev.osuosl.org> SUBSYSTEM" <devel@driverdev.osuosl.org>,
        "Dilger, Andreas" <andreas.dilger@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "HPDD-discuss@lists.01.org" <HPDD-discuss@ml01.01.org>,
        Julia Lawall <Julia.Lawall@lip6.fr>, Al Viro <viro@zeniv.linux.org.uk>,
        "Hammond, John" <john.hammond@intel.com>, Frank Zago <fzago@cray.com>
Subject: Re: about ENOSYS
Message-ID: <20150803162158.GA30867@kroah.com>
References: <1438582739-2626-1-git-send-email-shraddha.6596@gmail.com>
 <D7ABD589-0012-4CA2-BB2B-A7D4B9F589D6@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <D7ABD589-0012-4CA2-BB2B-A7D4B9F589D6@intel.com>
User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 03, 2015 at 06:41:22AM +0000, Drokin, Oleg wrote:
> subject have been missing, so I filled in something.
> 
> On Aug 3, 2015, at 2:18 AM, Shraddha Barke wrote:
> 
> > From b67c6c20455b04b77447ab4561e44f1a75dd978d Mon Sep 17 00:00:00 2001
> > From: Shraddha Barke <shraddha.6596@gmail.com>
> > Date: Mon, 3 Aug 2015 11:34:19 +0530
> > Subject: [PATCH] Staging : lustre : Use -EINVAL instead of -ENOSYS
> > 
> > ENOSYS means that a nonexistent system call was called. This should
> > not be used for invalid operations on otherwise valid syscalls.
> > 
> > Use -EINVAL instead of -ENOSYS. This fixes checkpatch warning message:
> > 
> > WARNING: ENOSYS means 'invalid syscall nr' and nothing else
> 
> Is this really true, though?
> I know you are working off what the tool reports.
> But in reality people have been using ENOSYS to indicate
> "this thing that you want is not really available" 
> Reading the define file we can see:
> /usr/include/asm-generic/errno.h:#define	ENOSYS		38	/* Function not implemented */
> 
> $ grep -r 'ENOSYS;' fs/ | wc -l
> 75
> 
> So it's extensively used in the fs tree by existing code.
> 
> Hmm…. Searching some more I arrived at commit e15f431f
> that changes the in-kernel comment and claims the "system call only stuff".
> 
> So Greg, do you want Lustre to get rid of use of ENOSYS (all 16 users we have),
> or is it ok to leave them in?

For now I'd just leave it as-is.