From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755964AbbHDAlP (ORCPT ); Mon, 3 Aug 2015 20:41:15 -0400 Received: from one.firstfloor.org ([193.170.194.197]:45245 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751338AbbHDAlO (ORCPT ); Mon, 3 Aug 2015 20:41:14 -0400 Date: Tue, 4 Aug 2015 02:41:11 +0200 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, eranian@google.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 2/4] perf, tools, stat: Abstract stat metrics printing Message-ID: <20150804004111.GV1747@two.firstfloor.org> References: <1438215700-5530-1-git-send-email-andi@firstfloor.org> <1438215700-5530-3-git-send-email-andi@firstfloor.org> <20150730134755.GP9606@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150730134755.GP9606@krava.brq.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > because we already need to make the print_metric callback global, > would it be better to make this struct global, having all the > needed callbacks defined within? something like: It's actually not global, but static. I skipped this change. After some other changes there is only a single function call with these arguments left, so it's not an issue to pass it around. -Andi