From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMb9t-0005sR-0r for qemu-devel@nongnu.org; Tue, 04 Aug 2015 08:17:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMb9r-0006Q8-TC for qemu-devel@nongnu.org; Tue, 04 Aug 2015 08:17:28 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:40812) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMb9r-0006Pw-MX for qemu-devel@nongnu.org; Tue, 04 Aug 2015 08:17:27 -0400 Date: Tue, 4 Aug 2015 14:17:24 +0200 From: Aurelien Jarno Message-ID: <20150804121724.GA8421@aurel32.net> References: <1438593291-27109-1-git-send-email-alex.bennee@linaro.org> <1438593291-27109-7-git-send-email-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <1438593291-27109-7-git-send-email-alex.bennee@linaro.org> Subject: Re: [Qemu-devel] [PATCH v4 06/11] qemu-log: support simple pid substitution in logfile List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex =?iso-8859-15?Q?Benn=E9e?= Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, crosthwaitepeter@gmail.com, qemu-devel@nongnu.org, rth@twiddle.net On 2015-08-03 10:14, Alex Benn=E9e wrote: > When debugging stuff that occurs over several forks it would be useful > not to keep overwriting the one logfile you've set-up. This allows a > simple %d to be included once in the logfile parameter which is > substituted with getpid(). >=20 > Signed-off-by: Alex Benn=E9e > Reviewed-by: Leandro Dorileo > --- > qemu-log.c | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) >=20 > diff --git a/qemu-log.c b/qemu-log.c > index 7036076..77ed7bc 100644 > --- a/qemu-log.c > +++ b/qemu-log.c > @@ -70,11 +70,24 @@ void do_qemu_set_log(int log_flags, bool use_own_buff= ers) > qemu_log_close(); > } > } > - > +/* > + * Allow the user to include %d in their logfile which will be > + * substituted with the current PID. This is useful for debugging many > + * nested linux-user tasks but will result in lots of logs. > + */ > void qemu_set_log_filename(const char *filename) > { > g_free(logfilename); > - logfilename =3D g_strdup(filename); > + if (g_strrstr(filename, "%d")) { > + /* if we are going to format this we'd better validate first */ > + if (g_regex_match_simple("^[^%]+%d[^%]+$", filename, 0, 0)) { > + logfilename =3D g_strdup_printf(filename, getpid()); > + } else { > + g_error("Bad logfile format: %s", filename); > + } > + } else { > + logfilename =3D g_strdup(filename); > + } > qemu_log_close(); > qemu_set_log(qemu_loglevel); > } Reviewed-by: Aurelien Jarno --=20 Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net