From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [SKL-DMC-BUGFIX 1/5] drm/i915/gen9: Removed byte swapping for csr firmware Date: Wed, 5 Aug 2015 11:01:50 +0200 Message-ID: <20150805090150.GN17734@phenom.ffwll.local> References: <1438619136-18268-1-git-send-email-animesh.manna@intel.com> <1438619136-18268-2-git-send-email-animesh.manna@intel.com> <55C053DC.3080303@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1002C6E46E for ; Wed, 5 Aug 2015 02:01:57 -0700 (PDT) Received: by wicgj17 with SMTP id gj17so183264679wic.1 for ; Wed, 05 Aug 2015 02:01:53 -0700 (PDT) Content-Disposition: inline In-Reply-To: <55C053DC.3080303@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Animesh Manna Cc: "intel-gfx@lists.freedesktop.org" , "Vetter, Daniel" List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBdWcgMDQsIDIwMTUgYXQgMTE6MjU6NDBBTSArMDUzMCwgQW5pbWVzaCBNYW5uYSB3 cm90ZToKPiAKPiAKPiBPbiA4LzQvMjAxNSA5OjE2IEFNLCBOYWdhcmFqdSwgVmF0aHNhbGEgd3Jv dGU6Cj4gPiJUaGlzIHBhdGNoIGNvbnRhaW5zIHRoZSBjaGFuZ2VzIHRvIHJlbW92ZSB0aGUgYnl0 ZSBzd2FwcGluZyBsb2dpYyBpbnRyb2R1Y2VkIHdpdGggb2xkIGRtYyBmaXJtd2FyZS4iCj4gPldo aWNoIHZlcnNpb24gb2YgRE1DIG5lZWQgcmV2ZXJzYWwgIGxvZ2ljPyAgQXRsZWFzdCAsIDQsMS4x NiwxLjE4IGZvbGxvdyB0aGUgc2FtZSBmb3JtYXQuCj4gCj4gUGFja2FnaW5nIG9mIGZpcm13YXJl IGJpbmFyeSBjb21wbGV0ZWx5IGNoYW5nZWQgYWZ0ZXIgYXBpIHZlcnNpb24gMS4wLCBzbyBieSBv bGQgZmlybXdhcmUgSSB3YW50IHRvIG1lYW4KPiB0aGUgaW5pdGlhbCB2ZXJzaW9uIGJlZm9yZSBk bWMgMS4wLgoKVGhpcyBraW5kIG9mIGluZm9ybWF0aW9uIHJlYWxseSBtdXN0IGJlIGluY2x1ZGVk IGluIHRoZSBjb21taXQgbWVzc2FnZS4KVmVyeSBsaWtlbHkgc29tZW9uZSB3aXRoIG9sZCBmaXJt d2FyZSB3aWxsIGJpc2VjdCB0byB0aGlzIGNvbW1pdCwgYW5kIGlmCnlvdSBkb24ndCBpbmNsdWRl IHRoYXQgcGVvcGxlIG5lZWQgbGF0ZXN0IGRtYyBmaXJtd2FyZSB0aGVyZSB3aWxsIGJlCmNvbmZ1 c2lvbi4KCkNvbW1pdCBtZXNzYWdlIF9tdXN0XyBiZSBjb21wbGV0ZSBhbmQgY29udGFpbiBldmVy eXRoaW5nIHRoYXQgd2FzCmRpc2N1c3NlZCB3aGlsZSByZXZpZXdpbmcgYW5kIGRldmVsb3Bpbmcg YSBwYXRjaC4KCkkgYWRkZWQgYSBub3RlIHdoaWxlIG1lcmdpbmcgdGhlIHBhdGNoLgotRGFuaWVs Cgo+IAo+ID4KPiA+LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+RnJvbTogTWFubmEsIEFu aW1lc2gKPiA+U2VudDogTW9uZGF5LCBBdWd1c3QgMywgMjAxNSA5OjU2IFBNCj4gPlRvOiBpbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPkNjOiBNYW5uYSwgQW5pbWVzaDsgVmV0dGVy LCBEYW5pZWw7IExlc3BpYXUsIERhbWllbjsgRGVhaywgSW1yZTsgS2FtYXRoLCBTdW5pbDsgTmFn YXJhanUsIFZhdGhzYWxhCj4gPlN1YmplY3Q6IFtTS0wtRE1DLUJVR0ZJWCAxLzVdIGRybS9pOTE1 L2dlbjk6IFJlbW92ZWQgYnl0ZSBzd2FwcGluZyBmb3IgY3NyIGZpcm13YXJlCj4gPgo+ID5UaGlz IHBhdGNoIGNvbnRhaW5zIHRoZSBjaGFuZ2VzIHRvIHJlbW92ZSB0aGUgYnl0ZSBzd2FwcGluZyBs b2dpYyBpbnRyb2R1Y2VkIHdpdGggb2xkIGRtYyBmaXJtd2FyZS4KPiA+V2hpbGUgZGVidWdnaW5n IFBDMTAgZW50cnkgaXNzdWUgZm9yIHNreWxha2UgZm91bmQgd2l0aCBsYXRlc3QgZG1jIGZpcm13 YXJlIHZlcnNpb24gMS4xOCB3aXRob3V0IGJ5dGUgc3dhcHBpbmcgZG1jIGlzIHdvcmtpbmcgZmlu ZSBhbmQgYWJsZSB0byBlbnRlciBQQzEwLgo+ID4KPiA+djE6IEluaXRpYWwgdmVyc2lvbi4KPiA+ Cj4gPnYyOiBDb3JyZWN0ZWQgZmlybXdhcmUgc2l6ZSBkdXJpbmcgbWVtY3B5KCkuIChTdWdnZXN0 ZWQgYnkgU3VuaWwpCj4gPgo+ID5DYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRl bC5jb20+Cj4gPkNjOiBEYW1pZW4gTGVzcGlhdSA8ZGFtaWVuLmxlc3BpYXVAaW50ZWwuY29tPgo+ ID5DYzogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+ID5DYzogU3VuaWwgS2FtYXRo IDxzdW5pbC5rYW1hdGhAaW50ZWwuY29tPgo+ID5TaWduZWQtb2ZmLWJ5OiBBbmltZXNoIE1hbm5h IDxhbmltZXNoLm1hbm5hQGludGVsLmNvbT4KPiA+U2lnbmVkLW9mZi1ieTogVmF0aHNhbGEgTmFn YXJhanUgPHZhdGhzYWxhLm5hZ2FyYWp1QGludGVsLmNvbT4KPiA+LS0tCj4gPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgfCAgMiArLSAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfY3NyLmMgfCAxNiArKysrLS0tLS0tLS0tLS0tCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCA1IGlu c2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+ID4KPiA+ZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5o IGluZGV4IGI5NGFkYTkuLjlkMGVlNTggMTAwNjQ0Cj4gPi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmgKPiA+KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ ID5AQCAtNzQyLDcgKzc0Miw3IEBAIGVudW0gY3NyX3N0YXRlIHsKPiA+ICBzdHJ1Y3QgaW50ZWxf Y3NyIHsKPiA+ICAJY29uc3QgY2hhciAqZndfcGF0aDsKPiA+LQlfX2JlMzIgKmRtY19wYXlsb2Fk Owo+ID4rCXVpbnQzMl90ICpkbWNfcGF5bG9hZDsKPiA+ICAJdWludDMyX3QgZG1jX2Z3X3NpemU7 Cj4gPiAgCXVpbnQzMl90IG1taW9fY291bnQ7Cj4gPiAgCXVpbnQzMl90IG1taW9hZGRyWzhdOwo+ ID5kaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3NyLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9jc3IuYwo+ID5pbmRleCA2ZDhhN2JmLi5iYTFhZTAzIDEwMDY0 NAo+ID4tLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jc3IuYwo+ID4rKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jc3IuYwo+ID5AQCAtMjQ0LDcgKzI0NCw3IEBAIHZvaWQg aW50ZWxfY3NyX2xvYWRfc3RhdHVzX3NldChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYsICB2b2lkIGludGVsX2Nzcl9sb2FkX3Byb2dyYW0oc3RydWN0IGRybV9kZXZpY2UgKmRldikg IHsKPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJp dmF0ZTsKPiA+LQlfX2JlMzIgKnBheWxvYWQgPSBkZXZfcHJpdi0+Y3NyLmRtY19wYXlsb2FkOwo+ ID4rCXUzMiAqcGF5bG9hZCA9IGRldl9wcml2LT5jc3IuZG1jX3BheWxvYWQ7Cj4gPiAgCXVpbnQz Ml90IGksIGZ3X3NpemU7Cj4gPiAgCWlmICghSVNfR0VOOShkZXYpKSB7Cj4gPkBAIC0yNTYsNyAr MjU2LDcgQEAgdm9pZCBpbnRlbF9jc3JfbG9hZF9wcm9ncmFtKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYpCj4gPiAgCWZ3X3NpemUgPSBkZXZfcHJpdi0+Y3NyLmRtY19md19zaXplOwo+ID4gIAlmb3Ig KGkgPSAwOyBpIDwgZndfc2l6ZTsgaSsrKQo+ID4gIAkJSTkxNV9XUklURShDU1JfUFJPR1JBTV9C QVNFICsgaSAqIDQsCj4gPi0JCQkodTMyIF9fZm9yY2UpcGF5bG9hZFtpXSk7Cj4gPisJCQlwYXls b2FkW2ldKTsKPiA+ICAJZm9yIChpID0gMDsgaSA8IGRldl9wcml2LT5jc3IubW1pb19jb3VudDsg aSsrKSB7Cj4gPiAgCQlJOTE1X1dSSVRFKGRldl9wcml2LT5jc3IubW1pb2FkZHJbaV0sCj4gPkBA IC0yNzksNyArMjc5LDcgQEAgc3RhdGljIHZvaWQgZmluaXNoX2Nzcl9sb2FkKGNvbnN0IHN0cnVj dCBmaXJtd2FyZSAqZncsIHZvaWQgKmNvbnRleHQpCj4gPiAgCWNoYXIgc3Vic3RlcHBpbmcgPSBp bnRlbF9nZXRfc3Vic3RlcHBpbmcoZGV2KTsKPiA+ICAJdWludDMyX3QgZG1jX29mZnNldCA9IENT Ul9ERUZBVUxUX0ZXX09GRlNFVCwgcmVhZGNvdW50ID0gMCwgbmJ5dGVzOwo+ID4gIAl1aW50MzJf dCBpOwo+ID4tCV9fYmUzMiAqZG1jX3BheWxvYWQ7Cj4gPisJdWludDMyX3QgKmRtY19wYXlsb2Fk Owo+ID4gIAlib29sIGZ3X2xvYWRlZCA9IGZhbHNlOwo+ID4gIAlpZiAoIWZ3KSB7Cj4gPkBAIC0z NzUsMTUgKzM3NSw3IEBAIHN0YXRpYyB2b2lkIGZpbmlzaF9jc3JfbG9hZChjb25zdCBzdHJ1Y3Qg ZmlybXdhcmUgKmZ3LCB2b2lkICpjb250ZXh0KQo+ID4gIAl9Cj4gPiAgCWRtY19wYXlsb2FkID0g Y3NyLT5kbWNfcGF5bG9hZDsKPiA+LQlmb3IgKGkgPSAwOyBpIDwgZG1jX2hlYWRlci0+Zndfc2l6 ZTsgaSsrKSB7Cj4gPi0JCXVpbnQzMl90ICp0bXAgPSAodTMyICopJmZ3LT5kYXRhW3JlYWRjb3Vu dCArIGkgKiA0XTsKPiA+LQkJLyoKPiA+LQkJICogVGhlIGZpcm13YXJlIHBheWxvYWQgaXMgYW4g YXJyYXkgb2YgMzIgYml0IHdvcmRzIHN0b3JlZCBpbgo+ID4tCQkgKiBsaXR0bGUtZW5kaWFuIGZv cm1hdCBpbiB0aGUgZmlybXdhcmUgaW1hZ2UgYW5kIHByb2dyYW1tZWQKPiA+LQkJICogYXMgMzIg Yml0IGJpZy1lbmRpYW4gZm9ybWF0IHRvIG1lbW9yeS4KPiA+LQkJICovCj4gPi0JCWRtY19wYXls b2FkW2ldID0gY3B1X3RvX2JlMzIoKnRtcCk7Cj4gPi0JfQo+ID4rCW1lbWNweShkbWNfcGF5bG9h ZCwgJmZ3LT5kYXRhW3JlYWRjb3VudF0sIG5ieXRlcyk7Cj4gPiAgCS8qIGxvYWQgY3NyIHByb2dy YW0gZHVyaW5nIHN5c3RlbSBib290LCBhcyBuZWVkZWQgZm9yIERDIHN0YXRlcyAqLwo+ID4gIAlp bnRlbF9jc3JfbG9hZF9wcm9ncmFtKGRldik7Cj4gPi0tCj4gPjIuMC4yCj4gPgo+IAo+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVs IFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cu ZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK