From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [SKL-DMC-BUGFIX 2/5] drm/i915/skl: Making DC6 entry is the last call in suspend flow. Date: Wed, 5 Aug 2015 11:05:51 +0200 Message-ID: <20150805090550.GO17734@phenom.ffwll.local> References: <1438619136-18268-1-git-send-email-animesh.manna@intel.com> <1438619136-18268-3-git-send-email-animesh.manna@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id D253E88065 for ; Wed, 5 Aug 2015 02:05:54 -0700 (PDT) Received: by wibxm9 with SMTP id xm9so57052217wib.1 for ; Wed, 05 Aug 2015 02:05:53 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1438619136-18268-3-git-send-email-animesh.manna@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Animesh Manna Cc: Rajneesh Bhardwaj , intel-gfx@lists.freedesktop.org, Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBBdWcgMDMsIDIwMTUgYXQgMDk6NTU6MzNQTSArMDUzMCwgQW5pbWVzaCBNYW5uYSB3 cm90ZToKPiBNbWlvIHJlZ2lzdGVyIGFjY2VzcyBhZnRlciBkYzYvZGM1IGVudHJ5IGlzIG5vdCBh bGxvd2VkIHdoZW4KPiBEQzYgcG93ZXIgc3RhdGVzIGFyZSBlbmFibGVkIGFjY29yZGluZyB0byBi c3BlYyAoYnNwZWMtaWQgMDUyNyksCj4gc28gZW5hYmxpbmcgZGM2IGFzIHRoZSBsYXN0IGNhbGwg aW4gc3VzcGVuZCBmbG93Lgo+IAo+IHYxOiBJbml0aWFsIHZlcnNpb24uCj4gCj4gdjI6IGNvbW1p dCBtZXNzYWdlIHVwZGF0ZWQgYmFzZWQgb24gY29tbWVudCBmcm9tIFZhdGhzYWxhLgo+IAo+IENj OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiBDYzogRGFtaWVuIExl c3BpYXUgPGRhbWllbi5sZXNwaWF1QGludGVsLmNvbT4KPiBDYzogSW1yZSBEZWFrIDxpbXJlLmRl YWtAaW50ZWwuY29tPgo+IENjOiBTdW5pbCBLYW1hdGggPHN1bmlsLmthbWF0aEBpbnRlbC5jb20+ Cj4gU2lnbmVkLW9mZi1ieTogQW5pbWVzaCBNYW5uYSA8YW5pbWVzaC5tYW5uYUBpbnRlbC5jb20+ Cj4gU2lnbmVkLW9mZi1ieTogVmF0aHNhbGEgTmFnYXJhanUgPHZhdGhzYWxhLm5hZ2FyYWp1QGlu dGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBSYWpuZWVzaCBCaGFyZHdhaiA8cmFqbmVlc2guYmhh cmR3YWpAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5j ICAgICAgICAgfCAxMiArKysrKystLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHJ2LmggICAgICAgIHwgIDIgKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGlt ZV9wbS5jIHwgMzMgKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDMgZmlsZXMg Y2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMzEgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2Rydi5jCj4gaW5kZXggMGQ2Nzc1YS4uZTFkMDEwMiAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kcnYuYwo+IEBAIC0xMDE3LDE0ICsxMDE3LDExIEBAIHN0YXRpYyBpbnQgc2tsX3N1c3Bl bmRfY29tcGxldGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7Cj4gIAkv KiBFbmFibGluZyBEQzYgaXMgbm90IGEgaGFyZCByZXF1aXJlbWVudCB0byBlbnRlciBydW50aW1l IEQzICovCj4gIAo+IC0JLyoKPiAtCSAqIFRoaXMgaXMgdG8gZW5zdXJlIHRoYXQgQ1NSIGlzbid0 IGlkZW50aWZpZWQgYXMgbG9hZGVkIGJlZm9yZQo+IC0JICogQ1NSLWxvYWRpbmcgcHJvZ3JhbSBp cyBjYWxsZWQgZHVyaW5nIHJ1bnRpbWUtcmVzdW1lLgo+IC0JICovCj4gLQlpbnRlbF9jc3JfbG9h ZF9zdGF0dXNfc2V0KGRldl9wcml2LCBGV19VTklOSVRJQUxJWkVEKTsKClNlZW1zIGxpa2UgYW4g dW5yZWxhdGVkIGh1bmsuIFNlcGFyYXRlIHBhdGNoIChpbiB0aGUgZG1jIGxvYWRlciByZXdvcmsK c2VyaWVzKSBvciBhbiBleHBsYW5hdGlvbiB3aHkgd2UgbmVlZCB0aGlzLgoKPiAtCj4gIAlza2xf dW5pbml0X2NkY2xrKGRldl9wcml2KTsKPiAgCj4gKwlpZiAoaW50ZWxfY3NyX2xvYWRfc3RhdHVz X2dldChkZXZfcHJpdikgPT0gRldfTE9BREVEKQo+ICsJCXNrbF9lbmFibGVfZGM2KGRldl9wcml2 KTsKPiArCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiBAQCAtMTA3MSw2ICsxMDY4LDkgQEAgc3Rh dGljIGludCBza2xfcmVzdW1lX3ByZXBhcmUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gZGV2X3ByaXYtPmRldjsKPiAg Cj4gKwlpZiAoaW50ZWxfY3NyX2xvYWRfc3RhdHVzX2dldChkZXZfcHJpdikgPT0gRldfTE9BREVE KQo+ICsJCXNrbF9kaXNhYmxlX2RjNihkZXZfcHJpdik7Cj4gKwo+ICAJc2tsX2luaXRfY2RjbGso ZGV2X3ByaXYpOwo+ICAJaW50ZWxfY3NyX2xvYWRfcHJvZ3JhbShkZXYpOwo+ICAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4IDQ3Y2VmMGUuLjA2ZjM0NmYgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcnYuaAo+IEBAIC0xMTE3LDYgKzExMTcsOCBAQCB2b2lkIGJ4dF9lbmFibGVf ZGM5KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4gIHZvaWQgYnh0X2Rpc2Fi bGVfZGM5KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4gIHZvaWQgc2tsX2lu aXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiAgdm9pZCBza2xf dW5pbml0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4gK3ZvaWQg c2tsX2VuYWJsZV9kYzYoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiArdm9p ZCBza2xfZGlzYWJsZV9kYzYoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiAg dm9pZCBpbnRlbF9kcF9nZXRfbV9uKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAJCSAgICAg IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZyk7Cj4gIHZvaWQgaW50ZWxfZHBf c2V0X21fbihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywgZW51bSBsaW5rX21fbl9zZXQgbV9uKTsK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jCj4gaW5kZXggNjM5M2I3Ni4u YzY2MDI0NSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1l X3BtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiBA QCAtNTMyLDcgKzUzMiw3IEBAIHN0YXRpYyB2b2lkIGFzc2VydF9jYW5fZGlzYWJsZV9kYzYoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJCSJEQzYgYWxyZWFkeSBwcm9ncmFt bWVkIHRvIGJlIGRpc2FibGVkLlxuIik7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIHNrbF9lbmFi bGVfZGM2KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArdm9pZCBza2xfZW5h YmxlX2RjNihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHsKPiAgCXVpbnQz Ml90IHZhbDsKPiAgCj4gQEAgLTU0OSw3ICs1NDksNyBAQCBzdGF0aWMgdm9pZCBza2xfZW5hYmxl X2RjNihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAlQT1NUSU5HX1JFQUQo RENfU1RBVEVfRU4pOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9pZCBza2xfZGlzYWJsZV9kYzYoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICt2b2lkIHNrbF9kaXNhYmxlX2RjNihz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHsKPiAgCXVpbnQzMl90IHZhbDsK CkV2ZXJ5dGhpbmcgYWJvdmUgc2VlbXMgdG8gcm91Z2hseSBiZSBtYXRjaGluZyB5b3VyIHBhdGNo IGRlc2NyaXB0aW9uLCBidXQKbm90IHBlcmZlY3RseTogWW91IHRhbGsgYWJvdXQgc3VzcGVuZCBm bG93IGJ1dCBhbHNvIHRvdWNoIHJlc3VtZSBmbG93LgoKQnV0IHRoZSBodW5rcyBiZWxvdyBhcmUg Y29tcGxldGVseSB1bmV4cGxhaW5lZCBtYWdpYyBhZmFpY3QuIEVpdGhlciB0aGlzCm5lZWRzIGEg c2VwYXJhdGUgcGF0Y2ggb3IgaXQgbmVlZHMgc2VyaW91c2x5IG1vcmUgZXhwbGFuYXRpb24gb2Yg d2hhdCdzCmdvaW5nIG9uLgoKPiAgCj4gQEAgLTYxMCwxMCArNjEwLDEwIEBAIHN0YXRpYyB2b2lk IHNrbF9zZXRfcG93ZXJfd2VsbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4g IAkJCQkhSTkxNV9SRUFEKEhTV19QV1JfV0VMTF9CSU9TKSwKPiAgCQkJCSJJbnZhbGlkIGZvciBw b3dlciB3ZWxsIHN0YXR1cyB0byBiZSBlbmFibGVkLCB1bmxlc3MgZG9uZSBieSB0aGUgQklPUywg XAo+ICAJCQkJd2hlbiByZXF1ZXN0IGlzIHRvIGRpc2FibGUhXG4iKTsKPiAtCQkJaWYgKChHRU45 X0VOQUJMRV9EQzUoZGV2KSB8fCBTS0xfRU5BQkxFX0RDNihkZXYpKSAmJgo+IC0JCQkJcG93ZXJf d2VsbC0+ZGF0YSA9PSBTS0xfRElTUF9QV18yKSB7Cj4gKwkJCWlmIChwb3dlcl93ZWxsLT5kYXRh ID09IFNLTF9ESVNQX1BXXzIpIHsKPiArCQkJCWlmIChHRU45X0VOQUJMRV9EQzUoZGV2KSkKPiAr CQkJCQlnZW45X2Rpc2FibGVfZGM1KGRldl9wcml2KTsKPiAgCQkJCWlmIChTS0xfRU5BQkxFX0RD NihkZXYpKSB7Cj4gLQkJCQkJc2tsX2Rpc2FibGVfZGM2KGRldl9wcml2KTsKPiAgCQkJCQkvKgo+ ICAJCQkJCSAqIERESSBidWZmZXIgcHJvZ3JhbW1pbmcgdW5uZWNlc3NhcnkgZHVyaW5nIGRyaXZl ci1sb2FkL3Jlc3VtZQo+ICAJCQkJCSAqIGFzIGl0J3MgYWxyZWFkeSBkb25lIGR1cmluZyBtb2Rl c2V0IGluaXRpYWxpemF0aW9uIHRoZW4uCj4gQEAgLTYyMSw4ICs2MjEsNiBAQCBzdGF0aWMgdm9p ZCBza2xfc2V0X3Bvd2VyX3dlbGwoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ ICAJCQkJCSAqLwo+ICAJCQkJCWlmICghZGV2X3ByaXYtPnBvd2VyX2RvbWFpbnMuaW5pdGlhbGl6 aW5nKQo+ICAJCQkJCQlpbnRlbF9wcmVwYXJlX2RkaShkZXYpOwo+IC0JCQkJfSBlbHNlIHsKPiAt CQkJCQlnZW45X2Rpc2FibGVfZGM1KGRldl9wcml2KTsKPiAgCQkJCX0KPiAgCQkJfQo+ICAJCQlJ OTE1X1dSSVRFKEhTV19QV1JfV0VMTF9EUklWRVIsIHRtcCB8IHJlcV9tYXNrKTsKPiBAQCAtNjQy LDI0ICs2NDAsOSBAQCBzdGF0aWMgdm9pZCBza2xfc2V0X3Bvd2VyX3dlbGwoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCQlQT1NUSU5HX1JFQUQoSFNXX1BXUl9XRUxMX0RS SVZFUik7Cj4gIAkJCURSTV9ERUJVR19LTVMoIkRpc2FibGluZyAlc1xuIiwgcG93ZXJfd2VsbC0+ bmFtZSk7Cj4gIAo+IC0JCQlpZiAoKEdFTjlfRU5BQkxFX0RDNShkZXYpIHx8IFNLTF9FTkFCTEVf REM2KGRldikpICYmCj4gLQkJCQlwb3dlcl93ZWxsLT5kYXRhID09IFNLTF9ESVNQX1BXXzIpIHsK PiAtCQkJCWVudW0gY3NyX3N0YXRlIHN0YXRlOwo+IC0JCQkJLyogVE9ETzogd2FpdCBmb3IgYSBj b21wbGV0aW9uIGV2ZW50IG9yCj4gLQkJCQkgKiBzaW1pbGFyIGhlcmUgaW5zdGVhZCBvZiBidXN5 Cj4gLQkJCQkgKiB3YWl0aW5nIHVzaW5nIHdhaXRfZm9yIGZ1bmN0aW9uLgo+IC0JCQkJICovCj4g LQkJCQl3YWl0X2Zvcigoc3RhdGUgPSBpbnRlbF9jc3JfbG9hZF9zdGF0dXNfZ2V0KGRldl9wcml2 KSkgIT0KPiAtCQkJCQkJRldfVU5JTklUSUFMSVpFRCwgMTAwMCk7Cj4gLQkJCQlpZiAoc3RhdGUg IT0gRldfTE9BREVEKQo+IC0JCQkJCURSTV9FUlJPUigiQ1NSIGZpcm13YXJlIG5vdCByZWFkeSAo JWQpXG4iLAo+IC0JCQkJCQkJc3RhdGUpOwo+IC0JCQkJZWxzZQo+IC0JCQkJCWlmIChTS0xfRU5B QkxFX0RDNihkZXYpKQo+IC0JCQkJCQlza2xfZW5hYmxlX2RjNihkZXZfcHJpdik7Cj4gLQkJCQkJ ZWxzZQo+IC0JCQkJCQlnZW45X2VuYWJsZV9kYzUoZGV2X3ByaXYpOwo+IC0JCQl9Cj4gKwkJCWlm IChHRU45X0VOQUJMRV9EQzUoZGV2KSAmJgo+ICsJCQkJcG93ZXJfd2VsbC0+ZGF0YSA9PSBTS0xf RElTUF9QV18yKQo+ICsJCQkJCWdlbjlfZW5hYmxlX2RjNShkZXZfcHJpdik7Cj4gIAkJfQo+ICAJ fQo+ICAKPiAtLSAKPiAyLjAuMgo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwg SW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK