From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752898AbbHGK7P (ORCPT ); Fri, 7 Aug 2015 06:59:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43629 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752198AbbHGK7N (ORCPT ); Fri, 7 Aug 2015 06:59:13 -0400 Date: Fri, 7 Aug 2015 12:59:10 +0200 From: Jiri Olsa To: Dean Nelson Cc: a.p.zijlstra@chello.org, mingo@redhat.com, rostedt@goodmis.org, acme@kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, Namhyung Kim Subject: Re: [PATCH] tools lib traceevent: add checks for returned EVENT_ERROR type Message-ID: <20150807105910.GE8624@krava.brq.redhat.com> References: <20150803170804.22235.88475.email-sent-by-dnelson@teal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150803170804.22235.88475.email-sent-by-dnelson@teal> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 03, 2015 at 01:08:05PM -0400, Dean Nelson wrote: > Running the following perf-stat command on an arm64 system produces the > following result... > > [root@aarch64 ~]# perf stat -e kmem:mm_page_alloc -a sleep 1 > Warning: [kmem:mm_page_alloc] function sizeof not defined > Warning: Error: expected type 4 but read 0 > Segmentation fault > [root@aarch64 ~]# hum, what kernel are you running on? I dont see that warning on my system: [jolsa@krava perf]$ sudo ./perf stat -e kmem:mm_page_alloc -a sleep 1 Performance counter stats for 'system wide': 227 kmem:mm_page_alloc 1.000762466 seconds time elapsed Cc-ing Namhyung jirka > > The second warning message and SIGSEGV stem from the issue expressed in the > first warning message, and are the result of ignoring the EVENT_ERROR type > returned back through the call chain. > > Dealing with the first warning message is beyond the scope of this patch. But > the second warning is addressed by this patch's first hunk. And the SIGSEGV is > eliminated by its second hunk. > > Signed-off-by: Dean Nelson > --- > tools/lib/traceevent/event-parse.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c > index cc25f05..72e2933 100644 > --- a/tools/lib/traceevent/event-parse.c > +++ b/tools/lib/traceevent/event-parse.c > @@ -1680,6 +1680,9 @@ process_cond(struct event_format *event, struct print_arg *top, char **tok) > type = process_arg(event, left, &token); > > again: > + if (type == EVENT_ERROR) > + goto out_free; > + > /* Handle other operations in the arguments */ > if (type == EVENT_OP && strcmp(token, ":") != 0) { > type = process_op(event, left, &token); > @@ -1940,7 +1943,7 @@ process_op(struct event_format *event, struct print_arg *arg, char **tok) > > type = process_arg_token(event, right, tok, type); > > - if (right->type == PRINT_OP && > + if (type != EVENT_ERROR && right->type == PRINT_OP && > get_op_prio(arg->op.op) < get_op_prio(right->op.op)) { > struct print_arg tmp; >