From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 2/2] drm/panel: correct minimum hsync length of the HannStar HSD070PWW1 panel Date: Fri, 7 Aug 2015 14:43:17 +0200 Message-ID: <20150807124316.GD25792@ulmo> References: <1435314429-10511-1-git-send-email-l.stach@pengutronix.de> <1435314429-10511-2-git-send-email-l.stach@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0831551337==" Return-path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F76F6E1CB for ; Fri, 7 Aug 2015 05:44:02 -0700 (PDT) Received: by wicgj17 with SMTP id gj17so60088122wic.1 for ; Fri, 07 Aug 2015 05:44:00 -0700 (PDT) In-Reply-To: <1435314429-10511-2-git-send-email-l.stach@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lucas Stach Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org, patchwork-lst@pengutronix.de List-Id: dri-devel@lists.freedesktop.org --===============0831551337== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5p8PegU4iirBW1oA" Content-Disposition: inline --5p8PegU4iirBW1oA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 26, 2015 at 12:27:09PM +0200, Lucas Stach wrote: > From: Philipp Zabel >=20 > According to the data sheet, the minimum horizontal blanking interval > is 54 clocks (1 + 52 + 1), but tests with a Nitrogen6X have shown the > minimum working horizontal blanking interval to be 60 clocks. >=20 > Signed-off-by: Philipp Zabel > Signed-off-by: Lucas Stach > --- > drivers/gpu/drm/panel/panel-simple.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel= /panel-simple.c > index dc6a923c89d7..7196b940a928 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -713,7 +713,12 @@ static const struct display_timing hannstar_hsd070pw= w1_timing =3D { > .hactive =3D { 1280, 1280, 1280 }, > .hfront_porch =3D { 1, 1, 10 }, > .hback_porch =3D { 1, 1, 10 }, > - .hsync_len =3D { 52, 158, 661 }, > + /* > + * According to the data sheet, the minimum horizontal blanking interval > + * is 54 clocks (1 + 52 + 1), but tests with a Nitrogen6X have shown the > + * minimum working horizontal blanking interval to be 60 clocks. > + */ > + .hsync_len =3D { 58, 158, 661 }, 58 !=3D 60, so which one is the truth here? Thierry --5p8PegU4iirBW1oA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVxKfjAAoJEN0jrNd/PrOh2r0P/Rby+AkH5NbP+7OvGRWODbZl hJ/C3CVgQ7SGD+r1fcJ04l3q5AejWthaosIsFWGjEVUoC6Ulu0LJAy28g06QoqEX FV2QqTUu6fdrgnhkystmrcmDDoLL9cZmt2BsrDxaE2v18KRgUjPizAo0KwLwqzWQ 6ASWYSoEB8kPmA4AcQtA4VZzOMMVyWcsM1fe+0eSwpsiQ5t1nW5XK1mgw7/3PT2n VqfkjlK0HJeH/RdJwVrXC7KzDQy+e66D9CTnkq9dlQb5jClphthqI3yhAkQUKR4M UmzDZW/Z2593SUm824MyMstQK//PyQEaD9S7z1/CJuu5AAKcGcE8UCu/H4dyOqgX wwBsIMjfVMYbAkZ1TvVVQPArq6LxaqWggXVWULwy4FfmT3l1j6m46LN/iwL+l8V7 Rv5SyWmHqvyYuv698k0IfGFiorin3kgKEN0s9pdFMuIh1Fzf2jseg6UFVRjhu4NO UKzTTCWHYT5S06ex7DvpfFtZhdRCT1+h2WCaf+wYJJycIpwTT5PfEKYJxJ3/V/GO dWEp9Oa001bcNNjN5RaRNe5BT3/tTe6UDCGhNpTlCHjD9rVCf9rDAf2d0OerMBcw EvcUxGTb+iyvfHwS5H5uKM6EbWMxQHePw46dMb6LgDd7cg8UW3Hn+HH/5VFf9rvf POa0orbrNWVvVjvmg+yO =kH9G -----END PGP SIGNATURE----- --5p8PegU4iirBW1oA-- --===============0831551337== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0831551337==--