From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 1/2] drm/panel: simple: Add bus format for HannStar HSD070PWW1 LVDS panel Date: Fri, 7 Aug 2015 15:22:55 +0200 Message-ID: <20150807132254.GA27996@ulmo> References: <1435314429-10511-1-git-send-email-l.stach@pengutronix.de> <20150807124243.GC25792@ulmo> <1438952798.3638.30.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1663446707==" Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTPS id C04204A007 for ; Fri, 7 Aug 2015 06:23:39 -0700 (PDT) Received: by wibxm9 with SMTP id xm9so65779784wib.1 for ; Fri, 07 Aug 2015 06:23:38 -0700 (PDT) In-Reply-To: <1438952798.3638.30.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philipp Zabel Cc: patchwork-lst@pengutronix.de, dri-devel@lists.freedesktop.org, kernel@pengutronix.de List-Id: dri-devel@lists.freedesktop.org --===============1663446707== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd" Content-Disposition: inline --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 07, 2015 at 03:06:38PM +0200, Philipp Zabel wrote: > Am Freitag, den 07.08.2015, 14:42 +0200 schrieb Thierry Reding: > > On Fri, Jun 26, 2015 at 12:27:08PM +0200, Lucas Stach wrote: > > > From: Philipp Zabel > > >=20 > >=20 > > Can you be more specific here? What kind of bus format is this? >=20 > The bus_format contains more information than just the bpc. In this > case, the SPWG default format for RGB666 via 3-pair LVDS specifies how > the 18 color bits are serialized in the 7 time slots for each pixel > clock. See > http://linuxtv.org/downloads/v4l-dvb-apis/subdev.html#v4l2-mbus-pixelcode= -rgb-lvds > for details. >=20 > > Why is it that .bpc =3D 6 doesn't work here? >=20 > In this case a LVDS driver could indeed still decide itself that > bpc =3D=3D 6 should be translated to MEDIA_BUS_FMT_RGB666_1X7X3_SPWG (and > not MEDIA_BUS_FMT_RGB666_1X18, or MEDIA_BUS_FMT_RGB666_1X24_CPADHI, for > example). But in the bpc =3D=3D 8 case there are two different standard w= ays > to order the bits (SPWG/VESA vs JEIDA). > For consistency, I'd prefer to set bus_format to the correct value > everywhere. Now if we can put that into a commit message, that'd be perfect. Thierry --ZPt4rx8FFjLCG7dd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVxLEuAAoJEN0jrNd/PrOh9FIP/iNQWQZoxpJ5cGLHQa9X2n5I 3z0FHElyBo2bDubtT9au1pu2SASFFrHKI6nNDVlz00GaWaq2yZQzbcc8ZxtL5Yie GjXn0SmvkLNr8xg8Qpwsnu18CZGlYTpbCGua5I4ouiG75Qq2PxmHKhIMejWSzeV6 hzLUBuGngo6eVhPs81TGKtCyJrJ5fa8AsDXdVBn3MpklIjpPcNhZ8wLU64RGMaAB AUlJrZFKA1ftpw7FntHm21vKlwGe2B5UibnCPxgPyGxOnJfK1PgZ98TmPrF73yV/ mIKU9jLiiVQgDJXrq4DBMI5bVmh4OCu9CrdJZDunjH6gZP6grcC6FLjij31VOGMU 2X6PC8tumn4AqG2+FaZXWkEox80sEjHewea5wbqU3JtsSMNwSrmc/wiLYthcPpyL j++0Ukt/Y1+XhuBC9Tu9S/BK8xN6OCF96Etx6R/owfeDIsSBZK2lxgmTiHPdKnpI fCNBJGKS9ZuXKslSIOPLFFdnfMy9PyXtR+RD7iUCbPsumQlWhqyIacNq55FBSAG7 UiYHt5jeQ0WJM9k0QKo0jqH/0uJFu+17zrSuRsqSkW1LTFmXvU3baeWsaaOS+8mL YzZoubaF4+CM7KRI/l5ir3fqJ6LlJ2zhv3vrx+AVpr/nMJKTSQKBMnTlSfz73m/D NvEQeRJ2UTUYAM36qPdT =eMWc -----END PGP SIGNATURE----- --ZPt4rx8FFjLCG7dd-- --===============1663446707== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1663446707==--