From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH for-4.6] tools: Don't try to update the
 firmware directory on ARM
Date: Sat, 8 Aug 2015 16:16:32 +0100
Message-ID: <20150808151632.GC14214@zion.uk.xensource.com>
References: <1438968438-23074-1-git-send-email-julien.grall@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6550d3289=wei.liu2@citrix.com>)
	id 1ZO9WK-0000e9-Qh
	for xen-devel@lists.xenproject.org; Sat, 08 Aug 2015 19:11:04 +0000
Content-Disposition: inline
In-Reply-To: <1438968438-23074-1-git-send-email-julien.grall@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>
Cc: Wei.Liu2@citrix.com, ian.campbell@citrix.com, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Fri, Aug 07, 2015 at 06:27:18PM +0100, Julien Grall wrote:
> The firmware directory is not built at all on ARM. Attempting to update
> it using the target subtree-force-update will fail when try to update
> seabios.
> 
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
> 
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> 
>     I've noticed it while trying to update the QEMU tree used by Xen on
>     a platform where iasl is not present (required by seabios in order
>     to update it).
> 
>     I think this should go in Xen 4.6 and possibly backport to Xen 4.5
> ---
>  tools/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/Makefile b/tools/Makefile
> index 45cb4b2..2618559 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -305,7 +305,9 @@ endif
>  ifeq ($(CONFIG_QEMU_TRAD),y)
>  	$(MAKE) qemu-xen-traditional-dir-force-update
>  endif
> +ifeq ($(CONFIG_X86),y)
>  	$(MAKE) -C firmware subtree-force-update
> +endif
>  

This is not optimal. What if you want to build OVMF on arm in the
future? You also can't preclude you don't have any other firmwares that
need to be built on ARM in the future.

I think a proper way of doing this is to make CONFIG_SEABIOS=n when
you're building on ARM. See tools/configure.ac.

Wei.

>  subtree-force-update-all:
>  	$(MAKE) qemu-xen-dir-force-update
> -- 
> 2.1.4