From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOdoT-0006Ll-4J for qemu-devel@nongnu.org; Sun, 09 Aug 2015 23:31:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZOdoQ-0001FH-1W for qemu-devel@nongnu.org; Sun, 09 Aug 2015 23:31:49 -0400 Received: from e28smtp02.in.ibm.com ([122.248.162.2]:56898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOdoP-0001El-Ci for qemu-devel@nongnu.org; Sun, 09 Aug 2015 23:31:45 -0400 Received: from /spool/local by e28smtp02.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 10 Aug 2015 09:01:41 +0530 Date: Mon, 10 Aug 2015 09:01:26 +0530 From: Bharata B Rao Message-ID: <20150810033126.GC23976@in.ibm.com> References: <1438838837-28504-1-git-send-email-bharata@linux.vnet.ibm.com> <55C31DDD.6080802@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55C31DDD.6080802@cn.fujitsu.com> Subject: Re: [Qemu-devel] [RFC PATCH v4 00/11] sPAPR CPU hotplug Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhu Guihua Cc: mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, imammedo@redhat.com, nfont@linux.vnet.ibm.com, afaerber@suse.de, david@gibson.dropbear.id.au On Thu, Aug 06, 2015 at 04:42:05PM +0800, Zhu Guihua wrote: > > On 08/06/2015 01:27 PM, Bharata B Rao wrote: > >Hi, > > > >This is the next version of CPU hotplug support patchset for PowerPC > >sPAPR guests. This is a split-out from the previous version (v3) that > >was carrying CPU and memory hotplug together. This patchset applies on > >spapr-next branch of David Gibson's tree. > > > >In the previous version, I was doing CPU addition at socket granularity. > >One hotplug request would add one complete CPU socket with all the cores > >and threads as per the boot time topology specification. Based on the > >feedback for v3, I am switching back to earlier method wherein I don't > >have the notion of socket device. In this version I don't create any > >additional device abstraction over CPU device, but use the existing > >CPU device and add full cores at once. One hotplug request will add > >a complete core with all the underlying threads. > > So the new generic infrastructure is generic socket or generic core? In this implementation, it is neither, meaning it is not generic as you can see from the device_add semantics at the end of this mail. > > Cc: Andreas > What about hot-adding a core device for x86 too? Hot-plug per core seems to > handle all cases. > > thanks, > Zhu > > >I have enabled device_add based hotplug for POWER8 family for processors > >and currently the semantics looks like this: > > > >(qemu) device_add POWER8-powerpc64-cpu,id=cpu8