From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754799AbbHJPtM (ORCPT ); Mon, 10 Aug 2015 11:49:12 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:49461 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753696AbbHJPtE (ORCPT ); Mon, 10 Aug 2015 11:49:04 -0400 Date: Mon, 10 Aug 2015 16:48:48 +0100 From: Russell King - ARM Linux To: linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Fabio Estevam , Takashi Iwai , Sascha Hauer , Jaroslav Kysela , David Airlie , Mark Brown , Philipp Zabel , Yakir Yang , Andy Yan , Jon Nettleton Subject: Re: [PATCH 9/9] drm: bridge/dw_hdmi-i2s-audio: add audio driver Message-ID: <20150810154848.GV7557@n2100.arm.linux.org.uk> References: <20150808160936.GN7557@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 08, 2015 at 05:10:47PM +0100, Russell King wrote: > From: Yakir Yang > > Add ALSA based HDMI I2S audio driver for dw_hdmi. Sound card > driver could connect to this codec through the codec dai name > "dw-hdmi-i2s-audio". > > [Fixed IRQ name, MODULE_DESCRIPTION, MODULE_ALIAS in > dw-hdmi-i2s-audio.c, and platform device name in dw-hdmi.c --rmk] > > Signed-off-by: Yakir Yang > Signed-off-by: Russell King I'm dropping this patch after all as it no longer builds against modern kernels due to the reference to the removed snd_soc_jack_new(). Its replacement is at card level, and I don't think it's a simple case of replacing it here. > +static int snd_dw_hdmi_audio_probe(struct snd_soc_codec *codec) > +{ > + struct snd_dw_hdmi *dw = snd_soc_codec_get_drvdata(codec); > + int ret; > + > + ret = snd_soc_jack_new(codec, "dw Jack", SND_JACK_LINEOUT, > + &dw->jack); ... > +static const struct snd_soc_codec_driver dw_hdmi_audio = { > + .probe = snd_dw_hdmi_audio_probe, > + .dapm_widgets = snd_dw_hdmi_audio_widgets, > + .num_dapm_widgets = ARRAY_SIZE(snd_dw_hdmi_audio_widgets), > + .dapm_routes = snd_dw_hdmi_audio_routes, > + .num_dapm_routes = ARRAY_SIZE(snd_dw_hdmi_audio_routes), > +}; > + > +static int dw_hdmi_audio_probe(struct platform_device *pdev) > +{ > + struct dw_hdmi_audio_data *data = pdev->dev.platform_data; > + struct snd_dw_hdmi *dw; > + int ret; > + > + dw = devm_kzalloc(&pdev->dev, sizeof(*dw), GFP_KERNEL); > + if (!dw) > + return -ENOMEM; > + > + dw->data = *data; > + dw->dev = &pdev->dev; > + dw->is_jack_ready = false; > + platform_set_drvdata(pdev, dw); > + > + ret = request_irq(dw->data.irq, snd_dw_hdmi_irq, IRQF_SHARED, > + DRIVER_NAME, dw); > + if (ret) { > + dev_err(&pdev->dev, "request irq failed (%d)\n", ret); > + return -EINVAL; > + } > + > + ret = snd_soc_register_codec(&pdev->dev, &dw_hdmi_audio, > + &dw_hdmi_audio_dai, 1); -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 9/9] drm: bridge/dw_hdmi-i2s-audio: add audio driver Date: Mon, 10 Aug 2015 16:48:48 +0100 Message-ID: <20150810154848.GV7557@n2100.arm.linux.org.uk> References: <20150808160936.GN7557@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Fabio Estevam , Jaroslav Kysela , Mark Brown , Yakir Yang , Andy Yan List-Id: alsa-devel@alsa-project.org T24gU2F0LCBBdWcgMDgsIDIwMTUgYXQgMDU6MTA6NDdQTSArMDEwMCwgUnVzc2VsbCBLaW5nIHdy b3RlOgo+IEZyb206IFlha2lyIFlhbmcgPHlra0Byb2NrLWNoaXBzLmNvbT4KPiAKPiBBZGQgQUxT QSBiYXNlZCBIRE1JIEkyUyBhdWRpbyBkcml2ZXIgZm9yIGR3X2hkbWkuIFNvdW5kIGNhcmQKPiBk cml2ZXIgY291bGQgY29ubmVjdCB0byB0aGlzIGNvZGVjIHRocm91Z2ggdGhlIGNvZGVjIGRhaSBu YW1lCj4gImR3LWhkbWktaTJzLWF1ZGlvIi4KPiAKPiBbRml4ZWQgSVJRIG5hbWUsIE1PRFVMRV9E RVNDUklQVElPTiwgTU9EVUxFX0FMSUFTIGluCj4gIGR3LWhkbWktaTJzLWF1ZGlvLmMsIGFuZCBw bGF0Zm9ybSBkZXZpY2UgbmFtZSBpbiBkdy1oZG1pLmMgLS1ybWtdCj4gCj4gU2lnbmVkLW9mZi1i eTogWWFraXIgWWFuZyA8eWtrQHJvY2stY2hpcHMuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFJ1c3Nl bGwgS2luZyA8cm1rK2tlcm5lbEBhcm0ubGludXgub3JnLnVrPgoKSSdtIGRyb3BwaW5nIHRoaXMg cGF0Y2ggYWZ0ZXIgYWxsIGFzIGl0IG5vIGxvbmdlciBidWlsZHMgYWdhaW5zdCBtb2Rlcm4Ka2Vy bmVscyBkdWUgdG8gdGhlIHJlZmVyZW5jZSB0byB0aGUgcmVtb3ZlZCBzbmRfc29jX2phY2tfbmV3 KCkuICBJdHMKcmVwbGFjZW1lbnQgaXMgYXQgY2FyZCBsZXZlbCwgYW5kIEkgZG9uJ3QgdGhpbmsg aXQncyBhIHNpbXBsZSBjYXNlIG9mCnJlcGxhY2luZyBpdCBoZXJlLgoKPiArc3RhdGljIGludCBz bmRfZHdfaGRtaV9hdWRpb19wcm9iZShzdHJ1Y3Qgc25kX3NvY19jb2RlYyAqY29kZWMpCj4gK3sK PiArCXN0cnVjdCBzbmRfZHdfaGRtaSAqZHcgPSBzbmRfc29jX2NvZGVjX2dldF9kcnZkYXRhKGNv ZGVjKTsKPiArCWludCByZXQ7Cj4gKwo+ICsJcmV0ID0gc25kX3NvY19qYWNrX25ldyhjb2RlYywg ImR3IEphY2siLCBTTkRfSkFDS19MSU5FT1VULAo+ICsJCQkgICAgICAgJmR3LT5qYWNrKTsKLi4u Cj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3Qgc25kX3NvY19jb2RlY19kcml2ZXIgZHdfaGRtaV9hdWRp byA9IHsKPiArCS5wcm9iZSA9IHNuZF9kd19oZG1pX2F1ZGlvX3Byb2JlLAo+ICsJLmRhcG1fd2lk Z2V0cyA9IHNuZF9kd19oZG1pX2F1ZGlvX3dpZGdldHMsCj4gKwkubnVtX2RhcG1fd2lkZ2V0cyA9 IEFSUkFZX1NJWkUoc25kX2R3X2hkbWlfYXVkaW9fd2lkZ2V0cyksCj4gKwkuZGFwbV9yb3V0ZXMg PSBzbmRfZHdfaGRtaV9hdWRpb19yb3V0ZXMsCj4gKwkubnVtX2RhcG1fcm91dGVzID0gQVJSQVlf U0laRShzbmRfZHdfaGRtaV9hdWRpb19yb3V0ZXMpLAo+ICt9Owo+ICsKPiArc3RhdGljIGludCBk d19oZG1pX2F1ZGlvX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gK3sKPiAr CXN0cnVjdCBkd19oZG1pX2F1ZGlvX2RhdGEgKmRhdGEgPSBwZGV2LT5kZXYucGxhdGZvcm1fZGF0 YTsKPiArCXN0cnVjdCBzbmRfZHdfaGRtaSAqZHc7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCWR3ID0g ZGV2bV9remFsbG9jKCZwZGV2LT5kZXYsIHNpemVvZigqZHcpLCBHRlBfS0VSTkVMKTsKPiArCWlm ICghZHcpCj4gKwkJcmV0dXJuIC1FTk9NRU07Cj4gKwo+ICsJZHctPmRhdGEgPSAqZGF0YTsKPiAr CWR3LT5kZXYgPSAmcGRldi0+ZGV2Owo+ICsJZHctPmlzX2phY2tfcmVhZHkgPSBmYWxzZTsKPiAr CXBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYsIGR3KTsKPiArCj4gKwlyZXQgPSByZXF1ZXN0X2ly cShkdy0+ZGF0YS5pcnEsIHNuZF9kd19oZG1pX2lycSwgSVJRRl9TSEFSRUQsCj4gKwkJCSAgRFJJ VkVSX05BTUUsIGR3KTsKPiArCWlmIChyZXQpIHsKPiArCQlkZXZfZXJyKCZwZGV2LT5kZXYsICJy ZXF1ZXN0IGlycSBmYWlsZWQgKCVkKVxuIiwgcmV0KTsKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiAr CX0KPiArCj4gKwlyZXQgPSBzbmRfc29jX3JlZ2lzdGVyX2NvZGVjKCZwZGV2LT5kZXYsICZkd19o ZG1pX2F1ZGlvLAo+ICsJCQkJICAgICAmZHdfaGRtaV9hdWRpb19kYWksIDEpOwoKLS0gCkZUVEMg YnJvYWRiYW5kIGZvciAwLjhtaWxlIGxpbmU6IGN1cnJlbnRseSBhdCAxMC41TWJwcyBkb3duIDQw MGticHMgdXAKYWNjb3JkaW5nIHRvIHNwZWVkdGVzdC5uZXQuCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Mon, 10 Aug 2015 16:48:48 +0100 Subject: [PATCH 9/9] drm: bridge/dw_hdmi-i2s-audio: add audio driver In-Reply-To: References: <20150808160936.GN7557@n2100.arm.linux.org.uk> Message-ID: <20150810154848.GV7557@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Aug 08, 2015 at 05:10:47PM +0100, Russell King wrote: > From: Yakir Yang > > Add ALSA based HDMI I2S audio driver for dw_hdmi. Sound card > driver could connect to this codec through the codec dai name > "dw-hdmi-i2s-audio". > > [Fixed IRQ name, MODULE_DESCRIPTION, MODULE_ALIAS in > dw-hdmi-i2s-audio.c, and platform device name in dw-hdmi.c --rmk] > > Signed-off-by: Yakir Yang > Signed-off-by: Russell King I'm dropping this patch after all as it no longer builds against modern kernels due to the reference to the removed snd_soc_jack_new(). Its replacement is at card level, and I don't think it's a simple case of replacing it here. > +static int snd_dw_hdmi_audio_probe(struct snd_soc_codec *codec) > +{ > + struct snd_dw_hdmi *dw = snd_soc_codec_get_drvdata(codec); > + int ret; > + > + ret = snd_soc_jack_new(codec, "dw Jack", SND_JACK_LINEOUT, > + &dw->jack); ... > +static const struct snd_soc_codec_driver dw_hdmi_audio = { > + .probe = snd_dw_hdmi_audio_probe, > + .dapm_widgets = snd_dw_hdmi_audio_widgets, > + .num_dapm_widgets = ARRAY_SIZE(snd_dw_hdmi_audio_widgets), > + .dapm_routes = snd_dw_hdmi_audio_routes, > + .num_dapm_routes = ARRAY_SIZE(snd_dw_hdmi_audio_routes), > +}; > + > +static int dw_hdmi_audio_probe(struct platform_device *pdev) > +{ > + struct dw_hdmi_audio_data *data = pdev->dev.platform_data; > + struct snd_dw_hdmi *dw; > + int ret; > + > + dw = devm_kzalloc(&pdev->dev, sizeof(*dw), GFP_KERNEL); > + if (!dw) > + return -ENOMEM; > + > + dw->data = *data; > + dw->dev = &pdev->dev; > + dw->is_jack_ready = false; > + platform_set_drvdata(pdev, dw); > + > + ret = request_irq(dw->data.irq, snd_dw_hdmi_irq, IRQF_SHARED, > + DRIVER_NAME, dw); > + if (ret) { > + dev_err(&pdev->dev, "request irq failed (%d)\n", ret); > + return -EINVAL; > + } > + > + ret = snd_soc_register_codec(&pdev->dev, &dw_hdmi_audio, > + &dw_hdmi_audio_dai, 1); -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.