From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZOpck-0002W8-Tn for mharc-grub-devel@gnu.org; Mon, 10 Aug 2015 12:08:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOpch-0002Rn-VG for grub-devel@gnu.org; Mon, 10 Aug 2015 12:08:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZOpcd-0004PV-Ic for grub-devel@gnu.org; Mon, 10 Aug 2015 12:08:27 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:41977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOpcd-0004P1-Bi for grub-devel@gnu.org; Mon, 10 Aug 2015 12:08:23 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t7AG82K4022231 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 10 Aug 2015 16:08:03 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t7AG81ZI007807 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 10 Aug 2015 16:08:02 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t7AG813r025512; Mon, 10 Aug 2015 16:08:01 GMT Received: from l.oracle.com (/10.137.176.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 10 Aug 2015 09:07:40 -0700 Received: by l.oracle.com (Postfix, from userid 1000) id 3C1476A4B89; Mon, 10 Aug 2015 12:07:37 -0400 (EDT) Date: Mon, 10 Aug 2015 12:07:37 -0400 From: Konrad Rzeszutek Wilk To: Daniel Kiper Subject: Re: [PATCH v2 01/23] x86/boot: remove unneeded instruction Message-ID: <20150810160737.GB12807@l.oracle.com> References: <1437402558-7313-1-git-send-email-daniel.kiper@oracle.com> <1437402558-7313-2-git-send-email-daniel.kiper@oracle.com> <20150724162257.GB2220@l.oracle.com> <20150727194608.GB3492@olila.local.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150727194608.GB3492@olila.local.net-space.pl> User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: userv0021.oracle.com [156.151.31.71] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 141.146.126.69 Cc: jgross@suse.com, grub-devel@gnu.org, wei.liu2@citrix.com, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, roy.franz@linaro.org, ning.sun@intel.com, david.vrabel@citrix.com, jbeulich@suse.com, phcoder@gmail.com, xen-devel@lists.xenproject.org, qiaowei.ren@intel.com, richard.l.maliszewski@intel.com, gang.wei@intel.com, fu.wei@linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2015 16:08:29 -0000 On Mon, Jul 27, 2015 at 09:46:08PM +0200, Daniel Kiper wrote: > On Fri, Jul 24, 2015 at 12:22:57PM -0400, Konrad Rzeszutek Wilk wrote: > > On Mon, Jul 20, 2015 at 04:28:56PM +0200, Daniel Kiper wrote: > > > Signed-off-by: Daniel Kiper > > > > Don't you use it in: > > > > /* Switch to low-memory stack. */ > > 193 mov sym_phys(trampoline_phys),%edi > > 194 lea 0x10000(%edi),%esp > > 195 lea trampoline_boot_cpu_entry-trampoline_start(%edi),%eax > > ? > > Yep, but... > > > > --- > > > xen/arch/x86/boot/head.S | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S > > > index cfd59dc..f63b349 100644 > > > --- a/xen/arch/x86/boot/head.S > > > +++ b/xen/arch/x86/boot/head.S > > > @@ -169,7 +169,6 @@ __start: > > > /* Apply relocations to bootstrap trampoline. */ > > > mov sym_phys(trampoline_phys),%edx > > ...relevant value is stored in sym_phys(trampoline_phys) earlier then it is > read into %edx here and... > > > > mov $sym_phys(__trampoline_rel_start),%edi > > > - mov %edx,sym_phys(trampoline_phys) > > ...it is put back to sym_phys(trampoline_phys) without any change here :-))). > So, I suppose this is remnant from something which was removed once but > somebody forgot to remove this instruction too... This patch fixes it. Reviewed-by: Konrad Rzeszutek Wilk