Re: [RESEND PATCH 2/3 v6] cpufreq: mediatek: Add MT8173 cpufreq driver

From: Viresh Kumar <viresh.kumar@linaro.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Pi-Cheng Chen <pi-cheng.chen@linaro.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Michael Turquette <mturquette@baylibre.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linaro-kernel@lists.linaro.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [RESEND PATCH 2/3 v6] cpufreq: mediatek: Add MT8173 cpufreq driver
Date: Tue, 18 Aug 2015 15:54:28 +0530	[thread overview]
Message-ID: <20150818102428.GD31148@linux> (raw)
In-Reply-To: <18468574.WHJNqYO5N4@amdc1976>

On 18-08-15, 12:09, Bartlomiej Zolnierkiewicz wrote:
> > +	pdev = platform_device_register_simple("mt8173-cpufreq", -1, NULL, 0);
> 
> This is not very friendly for multiplatform support
> (mt8173_cpufreq_driver_init() can be called on other platforms,
> i.e. Samsung Exynos7 one if ARCH_EXYNOS7 is also enabled in
> the kernel config).
> 
> Why can't it be fixed with checking Device Tree with
> of_machine_is_compatible("mediatek,mt8173")
> (assuming that it can be used on arm64 like on arm32)?

Because I asked him to remove that in v5 :( as I somehow had in mind
that this wouldn't even compile for other platforms.

@Pi-cheng: Please send v7 only for this patch and add the DT platform
check you were doing earlier. Sorry.

-- 
viresh