All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <treding@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 2/2] ARM: tegra: Add p2371-0000 board
Date: Wed, 19 Aug 2015 15:56:52 +0200	[thread overview]
Message-ID: <20150819135651.GE15607@ulmo.nvidia.com> (raw)
In-Reply-To: <1438200993-14056-2-git-send-email-swarren@wwwdotorg.org>

On Wed, Jul 29, 2015 at 02:16:33PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> v2: Use named constants for PMIC I2C and register addresses.
> ---
>  arch/arm/dts/Makefile                              |   1 +
>  arch/arm/dts/tegra210-p2371-0000.dts               |  59 +++++
>  arch/arm/mach-tegra/tegra210/Kconfig               |   6 +
>  board/nvidia/p2371-0000/Kconfig                    |  12 +
>  board/nvidia/p2371-0000/MAINTAINERS                |   6 +
>  board/nvidia/p2371-0000/Makefile                   |   8 +
>  board/nvidia/p2371-0000/p2371-0000.c               |  51 ++++
>  board/nvidia/p2371-0000/pinmux-config-p2371-0000.h | 260 +++++++++++++++++++++
>  configs/p2371-0000_defconfig                       |  16 ++
>  include/configs/p2371-0000.h                       |  72 ++++++
>  10 files changed, 491 insertions(+)
>  create mode 100644 arch/arm/dts/tegra210-p2371-0000.dts
>  create mode 100644 board/nvidia/p2371-0000/Kconfig
>  create mode 100644 board/nvidia/p2371-0000/MAINTAINERS
>  create mode 100644 board/nvidia/p2371-0000/Makefile
>  create mode 100644 board/nvidia/p2371-0000/p2371-0000.c
>  create mode 100644 board/nvidia/p2371-0000/pinmux-config-p2371-0000.h
>  create mode 100644 configs/p2371-0000_defconfig
>  create mode 100644 include/configs/p2371-0000.h

Sorry for being late on this. I just rebased my tree on origin/master
and got rid of my preliminary P2371 patches in favour of this only to
notice that it doesn't work the way it used to. For example I used to
use:

	# ums 0 mmc 1

to upload kernel, DTB and such to the external SD card. Unfortunately
that no longer works with this version of the patches. I tried to see
what the differences are but couldn't spot anything. I see that dmesg
shows a bunch of USB device reset messages, and failures to read the
superblock on /dev/sdc, which is what the mass storage shows up as. I
also tried porting a couple of changes from my earlier tree over to
master, but to no avail.

Any ideas what could be the reason here? Does the external SD card work
for anybody else?

I also noticed two other things:

> diff --git a/configs/p2371-0000_defconfig b/configs/p2371-0000_defconfig
[...]
> +CONFIG_USE_PRIVATE_LIBGCC=y

Why do we need this?

> diff --git a/include/configs/p2371-0000.h b/include/configs/p2371-0000.h
[...]
> +#define COUNTER_FREQUENCY	38400000

As far as I know the system counter is actually clocked by clk_m, which
on most (all?) Tegra210 platforms will be configured to run at half the
oscillator frequency (19.2 MHz). This is corroborated by the fact that
running:

	# sleep 5

actually takes 10 seconds rather than the expected 5. Changing the above
to 19200000 fixes that.

Thierry

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150819/3905eed4/attachment.sig>

  reply	other threads:[~2015-08-19 13:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-29 20:16 [U-Boot] [PATCH V2 1/2] ARM: tegra: Add e2220-1170 board Stephen Warren
2015-07-29 20:16 ` [U-Boot] [PATCH V2 2/2] ARM: tegra: Add p2371-0000 board Stephen Warren
2015-08-19 13:56   ` Thierry Reding [this message]
2015-08-19 17:41     ` Stephen Warren
2015-08-19 21:01       ` Stephen Warren
2015-08-19 23:07       ` Stephen Warren
2015-08-20  8:40       ` Thierry Reding
2015-07-29 23:00 ` [U-Boot] [PATCH V2 1/2] ARM: tegra: Add e2220-1170 board Tom Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150819135651.GE15607@ulmo.nvidia.com \
    --to=treding@nvidia.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.