From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752612AbbHUSlM (ORCPT ); Fri, 21 Aug 2015 14:41:12 -0400 Received: from foss.arm.com ([217.140.101.70]:60558 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbbHUSlK (ORCPT ); Fri, 21 Aug 2015 14:41:10 -0400 Date: Fri, 21 Aug 2015 19:40:59 +0100 From: Mark Rutland To: Leo Yan Cc: Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon , Jassi Brar , Bintian Wang , Haojian Zhuang , Yiping Xu , Wei Xu , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "guodong.xu@linaro.org" , Jian Zhang , Zhenwei Wang , Haoju Mo , Dan Zhao , "kongfei@hisilicon.com" , Guangyue Zeng Subject: Re: [PATCH v1 3/3] arm64: dts: add Hi6220 mailbox node Message-ID: <20150821184059.GB2000@svinekod> References: <1439977055-1747-1-git-send-email-leo.yan@linaro.org> <1439977055-1747-4-git-send-email-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439977055-1747-4-git-send-email-leo.yan@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 19, 2015 at 10:37:35AM +0100, Leo Yan wrote: > On Hi6220, below memory regions in DDR have specific purpose: > > 0x05e0,0000 - 0x05ef,ffff: For MCU firmware using at runtime; > 0x0740,f000 - 0x0740,ffff: For MCU firmware's section; > 0x06df,f000 - 0x06df,ffff: For mailbox message data. > > This patch reserves these memory regions and add device node for > mailbox in dts. > > Signed-off-by: Leo Yan > --- > arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 20 +++++++++++++++++--- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 8 ++++++++ > 2 files changed, 25 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > index e36a539..d5470d3 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > @@ -7,9 +7,6 @@ > > /dts-v1/; > > -/*Reserved 1MB memory for MCU*/ > -/memreserve/ 0x05e00000 0x00100000; > - > #include "hi6220.dtsi" > > / { > @@ -28,4 +25,21 @@ > device_type = "memory"; > reg = <0x0 0x0 0x0 0x40000000>; > }; > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + mcu-buf@05e00000 { > + no-map; > + reg = <0x0 0x05e00000 0x0 0x00100000>, /* MCU firmware buffer */ > + <0x0 0x0740f000 0x0 0x00001000>; /* MCU firmware section */ > + }; > + > + mbox-buf@06dff000 { > + no-map; > + reg = <0x0 0x06dff000 0x0 0x00001000>; /* Mailbox message buf */ > + }; > + }; As far as I can see, it would be simpler to simply carve these out of the memory node. I don't see why you need reserved-memory here, given you're not referring to these regions by phandle anyway. Thanks, Mark. > }; > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > index 3f03380..9ff25bc 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > @@ -167,5 +167,13 @@ > clocks = <&ao_ctrl 36>, <&ao_ctrl 36>; > clock-names = "uartclk", "apb_pclk"; > }; > + > + mailbox: mailbox@f7510000 { > + #mbox-cells = <1>; > + compatible = "hisilicon,hi6220-mbox"; > + reg = <0x0 0xf7510000 0x0 0x1000>, /* IPC_S */ > + <0x0 0x06dff800 0x0 0x0800>; /* Mailbox buffer */ > + interrupts = ; > + }; > }; > }; > -- > 1.9.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH v1 3/3] arm64: dts: add Hi6220 mailbox node Date: Fri, 21 Aug 2015 19:40:59 +0100 Message-ID: <20150821184059.GB2000@svinekod> References: <1439977055-1747-1-git-send-email-leo.yan@linaro.org> <1439977055-1747-4-git-send-email-leo.yan@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1439977055-1747-4-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leo Yan Cc: Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon , Jassi Brar , Bintian Wang , Haojian Zhuang , Yiping Xu , Wei Xu , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "guodong.xu-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , Jian Zhang , Zhenwei Wang , Haoju Mo , Dan Zhao , "kongfei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org" , Guangyu List-Id: devicetree@vger.kernel.org On Wed, Aug 19, 2015 at 10:37:35AM +0100, Leo Yan wrote: > On Hi6220, below memory regions in DDR have specific purpose: > > 0x05e0,0000 - 0x05ef,ffff: For MCU firmware using at runtime; > 0x0740,f000 - 0x0740,ffff: For MCU firmware's section; > 0x06df,f000 - 0x06df,ffff: For mailbox message data. > > This patch reserves these memory regions and add device node for > mailbox in dts. > > Signed-off-by: Leo Yan > --- > arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 20 +++++++++++++++++--- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 8 ++++++++ > 2 files changed, 25 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > index e36a539..d5470d3 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > @@ -7,9 +7,6 @@ > > /dts-v1/; > > -/*Reserved 1MB memory for MCU*/ > -/memreserve/ 0x05e00000 0x00100000; > - > #include "hi6220.dtsi" > > / { > @@ -28,4 +25,21 @@ > device_type = "memory"; > reg = <0x0 0x0 0x0 0x40000000>; > }; > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + mcu-buf@05e00000 { > + no-map; > + reg = <0x0 0x05e00000 0x0 0x00100000>, /* MCU firmware buffer */ > + <0x0 0x0740f000 0x0 0x00001000>; /* MCU firmware section */ > + }; > + > + mbox-buf@06dff000 { > + no-map; > + reg = <0x0 0x06dff000 0x0 0x00001000>; /* Mailbox message buf */ > + }; > + }; As far as I can see, it would be simpler to simply carve these out of the memory node. I don't see why you need reserved-memory here, given you're not referring to these regions by phandle anyway. Thanks, Mark. > }; > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > index 3f03380..9ff25bc 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > @@ -167,5 +167,13 @@ > clocks = <&ao_ctrl 36>, <&ao_ctrl 36>; > clock-names = "uartclk", "apb_pclk"; > }; > + > + mailbox: mailbox@f7510000 { > + #mbox-cells = <1>; > + compatible = "hisilicon,hi6220-mbox"; > + reg = <0x0 0xf7510000 0x0 0x1000>, /* IPC_S */ > + <0x0 0x06dff800 0x0 0x0800>; /* Mailbox buffer */ > + interrupts = ; > + }; > }; > }; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.rutland@arm.com (Mark Rutland) Date: Fri, 21 Aug 2015 19:40:59 +0100 Subject: [PATCH v1 3/3] arm64: dts: add Hi6220 mailbox node In-Reply-To: <1439977055-1747-4-git-send-email-leo.yan@linaro.org> References: <1439977055-1747-1-git-send-email-leo.yan@linaro.org> <1439977055-1747-4-git-send-email-leo.yan@linaro.org> Message-ID: <20150821184059.GB2000@svinekod> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Aug 19, 2015 at 10:37:35AM +0100, Leo Yan wrote: > On Hi6220, below memory regions in DDR have specific purpose: > > 0x05e0,0000 - 0x05ef,ffff: For MCU firmware using at runtime; > 0x0740,f000 - 0x0740,ffff: For MCU firmware's section; > 0x06df,f000 - 0x06df,ffff: For mailbox message data. > > This patch reserves these memory regions and add device node for > mailbox in dts. > > Signed-off-by: Leo Yan > --- > arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 20 +++++++++++++++++--- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 8 ++++++++ > 2 files changed, 25 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > index e36a539..d5470d3 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > @@ -7,9 +7,6 @@ > > /dts-v1/; > > -/*Reserved 1MB memory for MCU*/ > -/memreserve/ 0x05e00000 0x00100000; > - > #include "hi6220.dtsi" > > / { > @@ -28,4 +25,21 @@ > device_type = "memory"; > reg = <0x0 0x0 0x0 0x40000000>; > }; > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + mcu-buf at 05e00000 { > + no-map; > + reg = <0x0 0x05e00000 0x0 0x00100000>, /* MCU firmware buffer */ > + <0x0 0x0740f000 0x0 0x00001000>; /* MCU firmware section */ > + }; > + > + mbox-buf at 06dff000 { > + no-map; > + reg = <0x0 0x06dff000 0x0 0x00001000>; /* Mailbox message buf */ > + }; > + }; As far as I can see, it would be simpler to simply carve these out of the memory node. I don't see why you need reserved-memory here, given you're not referring to these regions by phandle anyway. Thanks, Mark. > }; > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > index 3f03380..9ff25bc 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > @@ -167,5 +167,13 @@ > clocks = <&ao_ctrl 36>, <&ao_ctrl 36>; > clock-names = "uartclk", "apb_pclk"; > }; > + > + mailbox: mailbox at f7510000 { > + #mbox-cells = <1>; > + compatible = "hisilicon,hi6220-mbox"; > + reg = <0x0 0xf7510000 0x0 0x1000>, /* IPC_S */ > + <0x0 0x06dff800 0x0 0x0800>; /* Mailbox buffer */ > + interrupts = ; > + }; > }; > }; > -- > 1.9.1 >