* [PATCH] ipv6: send only one NEWLINK when RA causes changes
@ 2015-08-31 23:57 Marius Tomaschewski
2015-09-01 4:23 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Marius Tomaschewski @ 2015-08-31 23:57 UTC (permalink / raw)
To: netdev
Signed-off-by: Marius Tomaschewski <mt@suse.de>
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index 99ea9dd..8456c75 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -1075,6 +1075,7 @@ static void ndisc_router_discovery(struct sk_buff *skb)
int optlen;
unsigned int pref = 0;
__u32 old_if_flags;
+ bool send_ifinfo_notify = false;
__u8 *opt = (__u8 *)(ra_msg + 1);
@@ -1154,7 +1155,7 @@ static void ndisc_router_discovery(struct sk_buff *skb)
IF_RA_OTHERCONF : 0);
if (old_if_flags != in6_dev->if_flags)
- inet6_ifinfo_notify(RTM_NEWLINK, in6_dev);
+ send_ifinfo_notify = true;
if (!in6_dev->cnf.accept_ra_defrtr) {
ND_PRINTK(2, info,
@@ -1259,7 +1260,7 @@ skip_defrtr:
rtime = HZ/10;
NEIGH_VAR_SET(in6_dev->nd_parms, RETRANS_TIME, rtime);
in6_dev->tstamp = jiffies;
- inet6_ifinfo_notify(RTM_NEWLINK, in6_dev);
+ send_ifinfo_notify = true;
}
rtime = ntohl(ra_msg->reachable_time);
@@ -1276,11 +1277,17 @@ skip_defrtr:
GC_STALETIME, 3 * rtime);
in6_dev->nd_parms->reachable_time = neigh_rand_reach_time(rtime);
in6_dev->tstamp = jiffies;
- inet6_ifinfo_notify(RTM_NEWLINK, in6_dev);
+ send_ifinfo_notify = true;
}
}
}
+ /*
+ * Send a notify if RA changed managed/otherconf flags or timer settings
+ */
+ if (send_ifinfo_notify)
+ inet6_ifinfo_notify(RTM_NEWLINK, in6_dev);
+
skip_linkparms:
/*
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipv6: send only one NEWLINK when RA causes changes
2015-08-31 23:57 [PATCH] ipv6: send only one NEWLINK when RA causes changes Marius Tomaschewski
@ 2015-09-01 4:23 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-09-01 4:23 UTC (permalink / raw)
To: mt; +Cc: netdev
From: Marius Tomaschewski <mt@suse.de>
Date: Tue, 1 Sep 2015 01:57:30 +0200
> Signed-off-by: Marius Tomaschewski <mt@suse.de>
Applied, thanks.
I wonder what to do about the situations right before the first
assignment of send_ifinfo_notify to true where the dst_neigh_lookup()
fails.
Since we updated if_flags, we probably should still emit the
notification.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-01 4:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-31 23:57 [PATCH] ipv6: send only one NEWLINK when RA causes changes Marius Tomaschewski
2015-09-01 4:23 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.