From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752158AbbHaUbU (ORCPT ); Mon, 31 Aug 2015 16:31:20 -0400 Received: from mail.kernel.org ([198.145.29.136]:47963 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751129AbbHaUbT (ORCPT ); Mon, 31 Aug 2015 16:31:19 -0400 Date: Mon, 31 Aug 2015 17:31:15 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: kan.liang@intel.com, jolsa@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] perf,tools: open event on evsel cpus and threads Message-ID: <20150831203115.GI4423@kernel.org> References: <1440138194-17001-1-git-send-email-kan.liang@intel.com> <20150821135436.GD27650@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150821135436.GD27650@krava.brq.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Aug 21, 2015 at 03:54:36PM +0200, Jiri Olsa escreveu: > On Fri, Aug 21, 2015 at 02:23:14AM -0400, kan.liang@intel.com wrote: > > From: Kan Liang > > > > evsel may have different cpus and threads as evlist's. > > Use it's own cpus and threads, when open evsel in perf record. > > Acked-by: Jiri Olsa Applying, I wonder if this isn't affecting other tools as well... And also perf_evlist__open(), that has to be fixed as well, right? - Arnaldo > thanks, > jirka > > > > > Signed-off-by: Kan Liang > > --- > > tools/perf/builtin-record.c | 2 +- > > tools/perf/util/evlist.c | 4 ++++ > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > > index 25cf6b4..a0178bf 100644 > > --- a/tools/perf/builtin-record.c > > +++ b/tools/perf/builtin-record.c > > @@ -279,7 +279,7 @@ static int record__open(struct record *rec) > > > > evlist__for_each(evlist, pos) { > > try_again: > > - if (perf_evsel__open(pos, evlist->cpus, evlist->threads) < 0) { > > + if (perf_evsel__open(pos, pos->cpus, pos->threads) < 0) { > > if (perf_evsel__fallback(pos, errno, msg, sizeof(msg))) { > > if (verbose) > > ui__warning("%s\n", msg); > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > > index 373f65b..be6fde9 100644 > > --- a/tools/perf/util/evlist.c > > +++ b/tools/perf/util/evlist.c > > @@ -1179,6 +1179,10 @@ int perf_evlist__apply_filters(struct perf_evlist *evlist, struct perf_evsel **e > > if (evsel->filter == NULL) > > continue; > > > > + /* > > + * filters only work for tracepoint event, which doesn't have cpu limit. > > + * So evlist and evsel should always be same. > > + */ > > err = perf_evsel__apply_filter(evsel, ncpus, nthreads, evsel->filter); > > if (err) { > > *err_evsel = evsel; > > -- > > 1.8.3.1 > >