From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 2/3] soc: qcom: smd: Use __iowrite32_copy() instead of open-coding it Date: Mon, 31 Aug 2015 21:59:45 -0700 Message-ID: <20150901045945.GC13472@usrtlx11787.corpusers.net> References: <1441071594-15941-1-git-send-email-sboyd@codeaurora.org> <1441071594-15941-3-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <1441071594-15941-3-git-send-email-sboyd@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Boyd Cc: Andy Gross , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-arm-msm@vger.kernel.org On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote: > We already have a function to do this and it silences some sparse > warnings along the way. > Didn't know that, thanks. Do you know why there's no equivalent for transfers in the other direction? Should we hack one up to do the same simplification in smd_copy_from_fifo()? Reviewed-by: Bjorn Andersson > Signed-off-by: Stephen Boyd Regards, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753961AbbIAFAE (ORCPT ); Tue, 1 Sep 2015 01:00:04 -0400 Received: from seldrel01.sonyericsson.com ([37.139.156.2]:1172 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753919AbbIAFAA (ORCPT ); Tue, 1 Sep 2015 01:00:00 -0400 Date: Mon, 31 Aug 2015 21:59:45 -0700 From: Bjorn Andersson To: Stephen Boyd CC: Andy Gross , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 2/3] soc: qcom: smd: Use __iowrite32_copy() instead of open-coding it Message-ID: <20150901045945.GC13472@usrtlx11787.corpusers.net> References: <1441071594-15941-1-git-send-email-sboyd@codeaurora.org> <1441071594-15941-3-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1441071594-15941-3-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote: > We already have a function to do this and it silences some sparse > warnings along the way. > Didn't know that, thanks. Do you know why there's no equivalent for transfers in the other direction? Should we hack one up to do the same simplification in smd_copy_from_fifo()? Reviewed-by: Bjorn Andersson > Signed-off-by: Stephen Boyd Regards, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 From: bjorn.andersson@sonymobile.com (Bjorn Andersson) Date: Mon, 31 Aug 2015 21:59:45 -0700 Subject: [PATCH 2/3] soc: qcom: smd: Use __iowrite32_copy() instead of open-coding it In-Reply-To: <1441071594-15941-3-git-send-email-sboyd@codeaurora.org> References: <1441071594-15941-1-git-send-email-sboyd@codeaurora.org> <1441071594-15941-3-git-send-email-sboyd@codeaurora.org> Message-ID: <20150901045945.GC13472@usrtlx11787.corpusers.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote: > We already have a function to do this and it silences some sparse > warnings along the way. > Didn't know that, thanks. Do you know why there's no equivalent for transfers in the other direction? Should we hack one up to do the same simplification in smd_copy_from_fifo()? Reviewed-by: Bjorn Andersson > Signed-off-by: Stephen Boyd Regards, Bjorn