From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 3/3] soc: qcom: smd: Handle big endian CPUs Date: Mon, 31 Aug 2015 22:06:44 -0700 Message-ID: <20150901050644.GD13472@usrtlx11787.corpusers.net> References: <1441071594-15941-1-git-send-email-sboyd@codeaurora.org> <1441071594-15941-4-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <1441071594-15941-4-git-send-email-sboyd@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Boyd Cc: Andy Gross , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-arm-msm@vger.kernel.org On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote: > The smd structures are always in little endian, but the smd > driver is not capable of being used on big endian CPUs. Annotate > the little endian data members and update the code to do the > proper byte swapping. > I think this looks good, but I think it would be better to reference the 8-bit entries of the info struct as "flags" rather than INFO8s. Could you please change the name of the macros to {G,S}ET_{R,T}X_CHANNEL_FLAG() to make the code slightly easier to follow? Regards, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752750AbbIAFGu (ORCPT ); Tue, 1 Sep 2015 01:06:50 -0400 Received: from seldrel01.sonyericsson.com ([37.139.156.2]:3670 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbbIAFGt (ORCPT ); Tue, 1 Sep 2015 01:06:49 -0400 Date: Mon, 31 Aug 2015 22:06:44 -0700 From: Bjorn Andersson To: Stephen Boyd CC: Andy Gross , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 3/3] soc: qcom: smd: Handle big endian CPUs Message-ID: <20150901050644.GD13472@usrtlx11787.corpusers.net> References: <1441071594-15941-1-git-send-email-sboyd@codeaurora.org> <1441071594-15941-4-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1441071594-15941-4-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote: > The smd structures are always in little endian, but the smd > driver is not capable of being used on big endian CPUs. Annotate > the little endian data members and update the code to do the > proper byte swapping. > I think this looks good, but I think it would be better to reference the 8-bit entries of the info struct as "flags" rather than INFO8s. Could you please change the name of the macros to {G,S}ET_{R,T}X_CHANNEL_FLAG() to make the code slightly easier to follow? Regards, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 From: bjorn.andersson@sonymobile.com (Bjorn Andersson) Date: Mon, 31 Aug 2015 22:06:44 -0700 Subject: [PATCH 3/3] soc: qcom: smd: Handle big endian CPUs In-Reply-To: <1441071594-15941-4-git-send-email-sboyd@codeaurora.org> References: <1441071594-15941-1-git-send-email-sboyd@codeaurora.org> <1441071594-15941-4-git-send-email-sboyd@codeaurora.org> Message-ID: <20150901050644.GD13472@usrtlx11787.corpusers.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote: > The smd structures are always in little endian, but the smd > driver is not capable of being used on big endian CPUs. Annotate > the little endian data members and update the code to do the > proper byte swapping. > I think this looks good, but I think it would be better to reference the 8-bit entries of the info struct as "flags" rather than INFO8s. Could you please change the name of the macros to {G,S}ET_{R,T}X_CHANNEL_FLAG() to make the code slightly easier to follow? Regards, Bjorn