From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 3/3] soc: qcom: smd: Handle big endian CPUs Date: Tue, 1 Sep 2015 11:04:54 -0700 Message-ID: <20150901180453.GC19120@codeaurora.org> References: <1441071594-15941-1-git-send-email-sboyd@codeaurora.org> <1441071594-15941-4-git-send-email-sboyd@codeaurora.org> <20150901050644.GD13472@usrtlx11787.corpusers.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:32787 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753799AbbIASEz (ORCPT ); Tue, 1 Sep 2015 14:04:55 -0400 Content-Disposition: inline In-Reply-To: <20150901050644.GD13472@usrtlx11787.corpusers.net> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Bjorn Andersson Cc: Andy Gross , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" On 08/31, Bjorn Andersson wrote: > On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote: > > > The smd structures are always in little endian, but the smd > > driver is not capable of being used on big endian CPUs. Annotate > > the little endian data members and update the code to do the > > proper byte swapping. > > > > I think this looks good, but I think it would be better to reference > the 8-bit entries of the info struct as "flags" rather than INFO8s. > > Could you please change the name of the macros to > {G,S}ET_{R,T}X_CHANNEL_FLAG() to make the code slightly easier to Sure. I also found another missing __le32 marking on the "hdr" stack structure. I'll test out some smd sending before resending the patches. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755354AbbIASE5 (ORCPT ); Tue, 1 Sep 2015 14:04:57 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:32787 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753799AbbIASEz (ORCPT ); Tue, 1 Sep 2015 14:04:55 -0400 Date: Tue, 1 Sep 2015 11:04:54 -0700 From: Stephen Boyd To: Bjorn Andersson Cc: Andy Gross , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 3/3] soc: qcom: smd: Handle big endian CPUs Message-ID: <20150901180453.GC19120@codeaurora.org> References: <1441071594-15941-1-git-send-email-sboyd@codeaurora.org> <1441071594-15941-4-git-send-email-sboyd@codeaurora.org> <20150901050644.GD13472@usrtlx11787.corpusers.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150901050644.GD13472@usrtlx11787.corpusers.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/31, Bjorn Andersson wrote: > On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote: > > > The smd structures are always in little endian, but the smd > > driver is not capable of being used on big endian CPUs. Annotate > > the little endian data members and update the code to do the > > proper byte swapping. > > > > I think this looks good, but I think it would be better to reference > the 8-bit entries of the info struct as "flags" rather than INFO8s. > > Could you please change the name of the macros to > {G,S}ET_{R,T}X_CHANNEL_FLAG() to make the code slightly easier to Sure. I also found another missing __le32 marking on the "hdr" stack structure. I'll test out some smd sending before resending the patches. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Tue, 1 Sep 2015 11:04:54 -0700 Subject: [PATCH 3/3] soc: qcom: smd: Handle big endian CPUs In-Reply-To: <20150901050644.GD13472@usrtlx11787.corpusers.net> References: <1441071594-15941-1-git-send-email-sboyd@codeaurora.org> <1441071594-15941-4-git-send-email-sboyd@codeaurora.org> <20150901050644.GD13472@usrtlx11787.corpusers.net> Message-ID: <20150901180453.GC19120@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/31, Bjorn Andersson wrote: > On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote: > > > The smd structures are always in little endian, but the smd > > driver is not capable of being used on big endian CPUs. Annotate > > the little endian data members and update the code to do the > > proper byte swapping. > > > > I think this looks good, but I think it would be better to reference > the 8-bit entries of the info struct as "flags" rather than INFO8s. > > Could you please change the name of the macros to > {G,S}ET_{R,T}X_CHANNEL_FLAG() to make the code slightly easier to Sure. I also found another missing __le32 marking on the "hdr" stack structure. I'll test out some smd sending before resending the patches. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project