From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752738AbbIBHIl (ORCPT ); Wed, 2 Sep 2015 03:08:41 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:16850 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751624AbbIBHIk (ORCPT ); Wed, 2 Sep 2015 03:08:40 -0400 Date: Wed, 2 Sep 2015 15:04:42 +0800 From: Jisheng Zhang To: Vaibhav Hiremath CC: , , , Subject: Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages Message-ID: <20150902150442.118d3305@xhacker> In-Reply-To: <1441135938-8056-3-git-send-email-vaibhav.hiremath@linaro.org> References: <1441135938-8056-1-git-send-email-vaibhav.hiremath@linaro.org> <1441135938-8056-3-git-send-email-vaibhav.hiremath@linaro.org> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-09-02_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=inbound_notspam policy=inbound score=0 kscore.is_bulkscore=0 kscore.compositescore=1 compositescore=0.9 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 rbsscore=0.9 spamscore=0 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1509020128 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath wrote: > Currently, the sdhci_do_start_signal_voltage_switch() function invokes > controller specific voltage switch configuration only for 1.8v usecase; > but it is required for others as well. > > For example, in case of PXA1928 SDH controller, we need to set different > configuration for 3.3, 1.8 and 1.2 volt support (I/O domain power > control register). > > Signed-off-by: Vaibhav Hiremath > --- > Note: > Currently ->voltage_switch() callback is only supported > in f_sdh30 driver. And I am not sure on the dependency of execution > sequence for that device. I could have moved ->voltage_switch() call > at one common place (above/below), but was not quite sure about it. > So, replicated/duplicated the call for other voltages. > > drivers/mmc/host/sdhci.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index 3dd295f..b59b76d 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -1753,6 +1753,10 @@ static int sdhci_do_start_signal_voltage_switch(struct sdhci_host *host, > /* Wait for 5ms */ > usleep_range(5000, 5500); > > + /* Some controller need to do more when switching */ > + if (host->ops->voltage_switch) > + host->ops->voltage_switch(host, MMC_SIGNAL_VOLTAGE_330); Could this be implemented by regulator API? From patch set 3/3, the pxa1928 voltage_switch hook is to operate the IO pad registers, this seems not belong to the SDHC IP core. Thanks, Jisheng > + > /* 3.3V regulator output should be stable within 5 ms */ > ctrl = sdhci_readw(host, SDHCI_HOST_CONTROL2); > if (!(ctrl & SDHCI_CTRL_VDD_180)) > @@ -1803,6 +1807,10 @@ static int sdhci_do_start_signal_voltage_switch(struct sdhci_host *host, > return -EIO; > } > } > + /* Some controller need to do more when switching */ > + if (host->ops->voltage_switch) > + host->ops->voltage_switch(host, MMC_SIGNAL_VOLTAGE_120); > + > return 0; > default: > /* No signal voltage switch required */ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jisheng Zhang Subject: Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages Date: Wed, 2 Sep 2015 15:04:42 +0800 Message-ID: <20150902150442.118d3305@xhacker> References: <1441135938-8056-1-git-send-email-vaibhav.hiremath@linaro.org> <1441135938-8056-3-git-send-email-vaibhav.hiremath@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:16850 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751624AbbIBHIk (ORCPT ); Wed, 2 Sep 2015 03:08:40 -0400 In-Reply-To: <1441135938-8056-3-git-send-email-vaibhav.hiremath@linaro.org> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Vaibhav Hiremath Cc: linux-mmc@vger.kernel.org, ulf.hansson@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath wrote: > Currently, the sdhci_do_start_signal_voltage_switch() function invokes > controller specific voltage switch configuration only for 1.8v usecase; > but it is required for others as well. > > For example, in case of PXA1928 SDH controller, we need to set different > configuration for 3.3, 1.8 and 1.2 volt support (I/O domain power > control register). > > Signed-off-by: Vaibhav Hiremath > --- > Note: > Currently ->voltage_switch() callback is only supported > in f_sdh30 driver. And I am not sure on the dependency of execution > sequence for that device. I could have moved ->voltage_switch() call > at one common place (above/below), but was not quite sure about it. > So, replicated/duplicated the call for other voltages. > > drivers/mmc/host/sdhci.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index 3dd295f..b59b76d 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -1753,6 +1753,10 @@ static int sdhci_do_start_signal_voltage_switch(struct sdhci_host *host, > /* Wait for 5ms */ > usleep_range(5000, 5500); > > + /* Some controller need to do more when switching */ > + if (host->ops->voltage_switch) > + host->ops->voltage_switch(host, MMC_SIGNAL_VOLTAGE_330); Could this be implemented by regulator API? From patch set 3/3, the pxa1928 voltage_switch hook is to operate the IO pad registers, this seems not belong to the SDHC IP core. Thanks, Jisheng > + > /* 3.3V regulator output should be stable within 5 ms */ > ctrl = sdhci_readw(host, SDHCI_HOST_CONTROL2); > if (!(ctrl & SDHCI_CTRL_VDD_180)) > @@ -1803,6 +1807,10 @@ static int sdhci_do_start_signal_voltage_switch(struct sdhci_host *host, > return -EIO; > } > } > + /* Some controller need to do more when switching */ > + if (host->ops->voltage_switch) > + host->ops->voltage_switch(host, MMC_SIGNAL_VOLTAGE_120); > + > return 0; > default: > /* No signal voltage switch required */ From mboxrd@z Thu Jan 1 00:00:00 1970 From: jszhang@marvell.com (Jisheng Zhang) Date: Wed, 2 Sep 2015 15:04:42 +0800 Subject: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages In-Reply-To: <1441135938-8056-3-git-send-email-vaibhav.hiremath@linaro.org> References: <1441135938-8056-1-git-send-email-vaibhav.hiremath@linaro.org> <1441135938-8056-3-git-send-email-vaibhav.hiremath@linaro.org> Message-ID: <20150902150442.118d3305@xhacker> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath wrote: > Currently, the sdhci_do_start_signal_voltage_switch() function invokes > controller specific voltage switch configuration only for 1.8v usecase; > but it is required for others as well. > > For example, in case of PXA1928 SDH controller, we need to set different > configuration for 3.3, 1.8 and 1.2 volt support (I/O domain power > control register). > > Signed-off-by: Vaibhav Hiremath > --- > Note: > Currently ->voltage_switch() callback is only supported > in f_sdh30 driver. And I am not sure on the dependency of execution > sequence for that device. I could have moved ->voltage_switch() call > at one common place (above/below), but was not quite sure about it. > So, replicated/duplicated the call for other voltages. > > drivers/mmc/host/sdhci.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index 3dd295f..b59b76d 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -1753,6 +1753,10 @@ static int sdhci_do_start_signal_voltage_switch(struct sdhci_host *host, > /* Wait for 5ms */ > usleep_range(5000, 5500); > > + /* Some controller need to do more when switching */ > + if (host->ops->voltage_switch) > + host->ops->voltage_switch(host, MMC_SIGNAL_VOLTAGE_330); Could this be implemented by regulator API? From patch set 3/3, the pxa1928 voltage_switch hook is to operate the IO pad registers, this seems not belong to the SDHC IP core. Thanks, Jisheng > + > /* 3.3V regulator output should be stable within 5 ms */ > ctrl = sdhci_readw(host, SDHCI_HOST_CONTROL2); > if (!(ctrl & SDHCI_CTRL_VDD_180)) > @@ -1803,6 +1807,10 @@ static int sdhci_do_start_signal_voltage_switch(struct sdhci_host *host, > return -EIO; > } > } > + /* Some controller need to do more when switching */ > + if (host->ops->voltage_switch) > + host->ops->voltage_switch(host, MMC_SIGNAL_VOLTAGE_120); > + > return 0; > default: > /* No signal voltage switch required */